Giter VIP home page Giter VIP logo

enjin-godot-sdk's Issues

Git submodule makes distribution harder (missing from GitHub ZIP archives)

Hi,

I was reviewing the inclusion of this SDK in the Godot Asset Library, but I noticed that it uses a Git submodule at addons/enjin/sdk/graphql/templates, which makes distribution more difficult. Particularly, the "Download ZIP" / archive generation feature of GitHub (powered by git-archive) does not include submodules, so archives of this repository lack the necessary templates.

Godot's Asset Library requires on those generated ZIP archives to download assets locally (it doesn't use Git / libgit2 - for now), so the Enjin SDK couldn't be installed as is.

While I think it's a real shame and GitHub should fix this, for the time being I would suggest making a hard copy of your templates in the enjin-godot-sdk repository instead of using a submodule. Submodules are the correct technical solution for such a dependency, but sadly the Git ecosystem doesn't support them as well as it should.

On a side note - https://github.com/enjin/enjin-godot-sdk/blob/master/.gitmodules uses [email protected]:, which requires authentication and is thus only available for people with permissions on this repository. If you were to keep the submodule, it should be changed to https://github.com/ to be available to unprivileged users.


Note: Once this is fixed, the user who submitted https://godotengine.org/asset-library/asset/edit/1968 should be able to edit this pending asset to change the commit hash for the new version. I'll approve it then so that it becomes public.

Add XinFin XDC Network support in Enjin EcoSystem

Hello,

Looks interesting, unable to get a good wallet option like Enjin EcoSystem, would you consider adding ETH (1000 times better then ethereum/bitcoin) compatible DPOS chain (XinFin XDC.Network) ?

Github:- https://github.com/XinFinOrg/XDPoSChain
CMC :- https://coinmarketcap.com/currencies/xinfin-network/
Circulating Supply:- https://explorerapi.xinfin.network/publicAPI?module=balance&action=getcirculatingsupply
Total Supply:- https://explorerapi.xinfin.network/publicAPI?module=balance&action=totalXDC
Docker FullNode:- https://github.com/xinfinorg/XinFin-Node
Integration Code example: https://xinfin.org/exchange-listing-resource

Technical Community Support available at:

Telegram Community: https://t.me/XinFinDevelopers
Slack Community: https://xinfin-public.slack.com/messages/CELR2M831/
Slack Invitation Link: https://launchpass.com/xinfin-public
Technical help Resource: http://howto.xinfin.org/

Happy to talk commercials as well as ready to support with large XinFin Community members support to grow adoption with Enjin EcoSystem team.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.