Giter VIP home page Giter VIP logo

egoimageloading's People

Contributors

javisoto avatar jpm avatar shnhrrsn avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

egoimageloading's Issues

Retina image resources?

Any advice or information on how to use this to handle loading up retina (@2x) vs. standard resolution images?

Undefined symbols for architecture i386

Hello,

I am getting this error message when using EGOImageLoading

Undefined symbols for architecture i386:
"OBJC_CLASS$_EGOCache", referenced from:
objc-class-ref in EGOImageLoader.o
ld: symbol(s) not found for architecture i386
clang: error: linker command failed with exit code 1 (use -v to see invocation)

What can i do?

Thanks!

Demo crashed after click on "Clear Cache" button

Demo crashed after click on "Clear Cache" button.
(Simulator 3.1, Debug)

2009-12-17 16:41:23.007 EGOImageLoadingDemo[2016:207] Starting: <NSURLConnection: 0x3b67e80, http://farm4.static.flickr.com/3511/4008358164_a5def010c7_s.jpg>
2009-12-17 16:41:23.655 EGOImageLoadingDemo[2016:207] * Terminating app due to uncaught exception 'NSGenericException', reason: '* Collection <NSCFDictionary: 0x75055d0> was mutated while being enumerated.'
2009-12-17 16:41:23.656 EGOImageLoadingDemo[2016:207] Stack: (
30794843,
2427860233,
31169806,
15469,
13277,
2782297,
4696053,
2782297,
3189666,
3198403,
3193615,
2887219,
2795548,
2822325,
37445361,
30579584,
30575688,
37439405,
37439602,
2826243,
10692,
10546
)

crash on 404 image not found

Hello,

how can I skip if file not found on url,

*** Terminating app due to uncaught exception 'NSInvalidArgumentException', reason: 'Invalid domain=nil in -[NSError initWithDomain:code:userInfo:]'
*** First throw call stack:
(0x1b2b022 0x1cbccd6 0x1ad3a48 0x1ad39b9 0x170247e 0x17120a3 0x5f67e 0x5e3e6 0x17aca49 0x17aae84 0x17abea7 0x17aae3f 0x17aafc5 0x16eff5a 0xbaaa39 0xc77596 0xba1120 0xc77117 0xba0fbf 0x1aff94f 0x1a62b43 0x1a62424 0x1a61d84 0x1a61c9b 0x23817d8 0x238188a 0xda9626 0x2d39 0x2cb5)
terminate called throwing an exception

Functions in EGOImageViewDelegate not called

- (void)imageViewLoadedImage:(EGOImageView *)imageView;
- (void)imageViewFailedToLoadImage:(EGOImageView *)imageView error:(NSError *)error;

These two functions declared in EGOImageView.h not called even the image is already loaded and delegate is set to that view controller implemented.

(On Xcode4.6.2, iOS SDK 6.1)

Please add semantic version tags

I’ve recently added EGOImageLoading to the CocoaPods package manager repo.

CocoaPods is a tool for managing dependencies for OSX and iOS Xcode projects and provides a central repository for iOS/OSX libraries. This makes adding libraries to a project and updating them extremely easy and it will help users to resolve dependencies of the libraries they use.

However, EGOImageLoading doesn't have any version tags. I’ve added the current HEAD as version 0.0.1, but a version tag will make dependency resolution much easier.

Semantic version tags (instead of plain commit hashes/revisions) allow for resolution of cross-dependencies.

In case you didn’t know this yet; you can tag the current HEAD as, for instance, version 1.0.0, like so:

$ git tag -a 1.0.0 -m "Tag release 1.0.0"
$ git push --tags

EGOImageView imageView.imageURL performance

Hi all,

I'm noticing that using the imageView.imageURL of EGOImageView is downloading images too slow.

The images are available on CDN Akamai (Cloud Files from Rackspace Cloud) and even in Wifi, the download is too slow.

How I'm implementing:

  • (void)awakeFromNib {

    [super awakeFromNib];

    imageView = [[EGOImageView alloc] initWithPlaceholderImage:[UIImage imageNamed:@"placeholder.png"]];
    imageView.frame = CGRectMake(50, 36, 268, 205);
    [self.contentView addSubview:imageView];

}

And after this:

imageView.imageURL = [NSURL URLWithString:url];

My images have on average 300kb and are taking almost a minute to load on wifi.

Is there anything wrong on my implementation? Any suggestions?

Thank you in advance!

Disk Fetch in background?

Hello,

Is there any plans to defer disk fetch into a background thread/queue? This would help scrolling performance tremendously.

handlers inexistant for EGOImageLoadConnection

When using blocks, app crashes when trying to use :
- (void)loadImageForURL:(NSURL_)aURL completion:(void (^)(UIImage_ image, NSURL* imageURL, NSError* error))completion;

 -[EGOImageLoadConnection handlers]: unrecognized selector sent to instance 0x5d58e00

I fixed importing EGOImageLoader.h in EGOImageLoadConnection.h

EGOImaveView doesn't show its image when the "setImageURL:" method is called after a successful EGOHTTPRequest asynchronous request

Hi guys,

Suppose you have something like this, using the (great) EGOHTTPRequest library:

EGOHTTPRequest * request = [[EGOHTTPRequest alloc] initWithURL:[NSURL URLWithString:@"http://www.google.com"]];
[request setDelegate:self];
[request setDidFinishSelector:@selector(requestDidFinish:)];
[request startAsynchronous];

If you then call the "setImageURL:" message of an EGOImageView inside the "requestDidFinish:" method (that gets called when the HTTP request is finished) the image will never be loaded.

Here's a minimal application that fires the bug. Just run these steps to download the app:
git clone git://github.com/andmej/EGOBug.git
cd EGOBug
git checkout 8ad29fe
cat README

Then run it in the iPhone simulator and you will see what I'm talking about.

No EGOCache files on repository

Hey guys,
I've just cloned the repo, opened the xCode demo project and found that the files EGOCache.h and .m are not in the EGOCache directory.

EGOCache.h Missing

When compiling the Demo project, it seems that the EGOCache files are missing, there is just an empty directory.

Network operation still running when object deallocated

Hello everybody,

I noticed that if you alloc a EGOImageView (for example view controller in a pushed inside a navigation controller) and it gets deallocated (view controller popped), network operations are still running, and this make all my other network operations get slower.
I fixed that in the dealloc method in EGOImageView.m just adding: [self cancelImageLoad];

Image loading indicator

I want to add an activity indicator to a custom table view cell to indicate an image is loading. It doesn't seem like the notifications that the image loaded are being fired if they get pulled from the EGOCache. Any thoughts on how to handle this? Does the notification just need to be fired directly when the image is found in the cache?

Unable to Cancel Image Loading in UITableViewCell on iOS 6

iOS 6 has changed the UITableViewCell subclass's willMoveToSuperview: method so that it is no longer called when the cell get's reused. This breaks the following code:

- (void)willMoveToSuperview:(UIView *)newSuperview {
    [super willMoveToSuperview:newSuperview];

    if(!newSuperview) {
        [imageView cancelImageLoad];
    }
}

Also see:

http://stackoverflow.com/questions/12519156/difference-in-uitableviewcell-willmovetosuperview-behavior-between-ios-5-and-io

As a result using a EGOImageView in a UITableView will not only cause the image loading to not get cancelled when scrolled, but when the cells containing EGOImages are scrolled offscreen, images that load in when the tableview finishes moving will often get drawn in the wrong cells.

Can anyone recommend a workaround? I've tried a few things to cancel (overriding prepareForReuse, canceling in cellForRow...) the image loads that get sent offscreen without success.

How to know if the image is loaded?

I'm try to use the delegate method:-(void)imageViewLoadedImage:(EGOImageView *)imageView
but I don't know how to use it correctly. It seems can execute automatically after the image loaded but doesn't work.

Delayed Loading Behavior in UITableView

First off, thanks so much for making this great resource available.

So I'm loading my remote EGOImageView images in a UITableView with custom cells, if the user is currently scrolling, the images will not display until the scrolling motion comes to a complete stop. It looks as though the images are already downloaded however something is blocking them from displaying until the scrolling ends. I'd like to not have this behavior and just load the images in once ready if it is not too much of a performance hit...

I can't seem to spot where/why this is happening in the code. Can anyone enlighten me on this?

One thing I did try is to delay the _connection and schedule it to start on the main runloop in EGOImageLoadConnection.m start as per:

http://www.cocoanetics.com/2011/05/and-now-lazy-loading-with-nsurlconnection/

However I still get the delayed image loading.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.