The 2023-cy-fi from entelectchallenge

ElapsedTime in bot state is not calculated correctly.

Hi There,

I seems that the ElapsedTime value in the BotState is not being calculated correctly.
The calculation of the value being sent to bots is done in BotStateDTO.cs:

2023-Cy-Fi/2023-CyFi/CyFi/Runner/BotStateDTO.cs

Line 33 in ebf159c

this.ElapsedTime = hero.End.Subtract(hero.Start).ToString("g");

This calculation uses the Start and End values as defined in HeroEntity.cs:

2023-Cy-Fi/2023-CyFi/CyFi/Entity/HeroEntity.cs

Lines 18 to 19 in ebf159c

 public DateTime Start; 

 public DateTime End;

The Start value on the hero entity is set when a bot gets registered:

2023-Cy-Fi/2023-CyFi/CyFi/CyFiEngine.cs

Line 82 in ebf159c

bot.Hero.Start = DateTime.Now;

The End value is never given a value after being created as part of HeroEntity.
This leads to the following situation when trying to calculate ElapsedTime:

One possible place to update the End value on HeroEntities is in the root state Update function:

2023-Cy-Fi/2023-CyFi/CyFi/RootState/CyFiState.cs

Lines 40 to 54 in ebf159c

 public void Update() 

 { 

 //What order do we want to update the bots in? 

 //Fastest bot?  

 Bots.ForEach((bot) => 

  { 

  Console.WriteLine("Running Physics component"); 

  bot.Hero.PhysicsComponent.Update(bot.Hero, Bots.Except(new List<Bot>() { bot }).Select((bot) => bot.Hero).ToList(), Levels[bot.CurrentLevel]); 

  bot.LastUpdated = DateTime.Now; 

  }); 

 //Save to file 

 }

Another possible place to update the End value is in the GameLoop function where the BotStateDTO is created:

2023-Cy-Fi/2023-CyFi/CyFi/CyFiEngine.cs

Lines 124 to 139 in ebf159c

 private void GameLoop() 

 { 

 //Send updated bot state 

 Logger.Log(LogLevel.Information, $"Tick: {cyFiState.Tick} ************************************************* "); 

 List<BotStateDTO> botStates = new List<BotStateDTO>(); 

 foreach (var bot in cyFiState.Bots) 

 { 

 var oppositionBotsOnSameLevel = cyFiState.Bots.Except(new List<Bot> { bot }).Where(b => b.CurrentLevel == bot.CurrentLevel).ToList(); 

 botStates.Add(new BotStateDTO(bot, oppositionBotsOnSameLevel, bot.Hero, cyFiState.Levels[bot.CurrentLevel])); 

 Logger.Log(LogLevel.Information, $"bot States: X {bot.Hero.XPosition}, Y {bot.Hero.YPosition}"); 

 }

Alternatively, the End value could be removed from HeroEntities since it is not used anywhere in the program except to calculate ElapsedTime. Instead, the LastUpdated value from the Bot itself could be used since it gets updated every tick:

Depending on how / where you want to handle this I can put together a PR.

entelectchallenge / 2023-cy-fi Goto Github PK

2023-cy-fi's People

Contributors

Stargazers

Watchers

Forkers

2023-cy-fi's Issues

ElapsedTime in bot state is not calculated correctly.

Recommend Projects

React

Vue.js

Typescript

TensorFlow

Django

Laravel

D3

Recommend Topics

javascript

web

server

Machine learning

Visualization

Game

Recommend Org

Facebook

Microsoft

Google

Alibaba

D3

Tencent

	public void Update()
	{

	//What order do we want to update the bots in?
	//Fastest bot?
	Bots.ForEach((bot) =>
	{
	Console.WriteLine("Running Physics component");

	bot.Hero.PhysicsComponent.Update(bot.Hero, Bots.Except(new List<Bot>() { bot }).Select((bot) => bot.Hero).ToList(), Levels[bot.CurrentLevel]);
	bot.LastUpdated = DateTime.Now;
	});

	//Save to file
	}

	private void GameLoop()
	{
	//Send updated bot state

	Logger.Log(LogLevel.Information, $"Tick: {cyFiState.Tick} ************************************************* ");

	List<BotStateDTO> botStates = new List<BotStateDTO>();
	foreach (var bot in cyFiState.Bots)
	{

	var oppositionBotsOnSameLevel = cyFiState.Bots.Except(new List<Bot> { bot }).Where(b => b.CurrentLevel == bot.CurrentLevel).ToList();

	botStates.Add(new BotStateDTO(bot, oppositionBotsOnSameLevel, bot.Hero, cyFiState.Levels[bot.CurrentLevel]));
	Logger.Log(LogLevel.Information, $"bot States: X {bot.Hero.XPosition}, Y {bot.Hero.YPosition}");

	}