episerver / foundation-mvc-cms Goto Github PK

It appears Find indexing of pages in Foundation MVC CMS does not read into blocks on the page. This is problematic because we have some pages that are built entirely from blocks that should be returning in search results. They will only return if the search term is in the page name or teaser. If we want this content structure to work, then the indexing rules should include some recursion into nested blocks in order to accurately return results

Foundation CMS MVC - Search results summaries contain configuration values that probably should be excluded from index and summary information. For example, "10-5" on all these pages...

The Search textbox in the header in Foundation CMS is different from Foundation with Commerce. It defaults to any delay redirection to the results page. This is disabled by default in Foundation Commerce, and enabled by default here. Unfortunately, there's no configuration for this behavior in Foundation CMS. At the very least, it would be nice to have configuration option parity between the two sites.

When using the Card as a template for PageListBlock the layout doesnt respect the selected preview option (1, 1/2, 1/3).

When deploying using the Moseybank 2.0 content pack as soon as you try and create a new page it throws a 500 Unexpected Error unless there is a teaser image attached.

`Invalid URI: The URI is empty.

at System.Uri.CreateThis(String uri, Boolean dontEscape, UriKind uriKind) at Foundation.Infrastructure.SchemaMarkup.BlogItemPageSchemaMapper.Map(BlogItemPage content) in E:\sitebuilder-sites\westernpower\Foundation\Src\Foundation\Infrastructure\SchemaMarkup\BlogItemPageSchemaMapper.cs:line 17 at Foundation.Features.Shared.ContentViewModel1.get_SchemaMarkup() in E:\sitebuilder-sites\westernpower\Foundation\Src\Foundation\Features\Shared\ContentViewModel.cs:line 71 at ASP._Page_Features_Shared_Views__Layout_cshtml.Execute() in E:\sitebuilder-sites\westernpower\Foundation\src\Foundation\Features\Shared\Views\_Layout.cshtml:line 43 at System.Web.WebPages.WebPageBase.ExecutePageHierarchy() at System.Web.Mvc.WebViewPage.ExecutePageHierarchy() at System.Web.WebPages.WebPageBase.ExecutePageHierarchy(WebPageContext pageContext, TextWriter writer, WebPageRenderingBase startPage) at System.Web.WebPages.WebPageBase.<>c__DisplayClass40_0.<RenderPageCore>b__0(TextWriter writer) at System.Web.WebPages.WebPageBase.Write(HelperResult result) at System.Web.WebPages.WebPageBase.RenderSurrounding(String partialViewName, Action1 body) at System.Web.WebPages.WebPageBase.PopContext() at System.Web.Mvc.ViewResultBase.ExecuteResult(ControllerContext context) at System.Web.Mvc.ControllerActionInvoker.InvokeActionResultFilterRecursive(IList1 filters, Int32 filterIndex, ResultExecutingContext preContext, ControllerContext controllerContext, ActionResult actionResult) at System.Web.Mvc.ControllerActionInvoker.InvokeActionResultFilterRecursive(IList1 filters, Int32 filterIndex, ResultExecutingContext preContext, ControllerContext controllerContext, ActionResult actionResult) at System.Web.Mvc.ControllerActionInvoker.InvokeActionResultFilterRecursive(IList1 filters, Int32 filterIndex, ResultExecutingContext preContext, ControllerContext controllerContext, ActionResult actionResult) at System.Web.Mvc.ControllerActionInvoker.InvokeActionResultFilterRecursive(IList1 filters, Int32 filterIndex, ResultExecutingContext preContext, ControllerContext controllerContext, ActionResult actionResult) at System.Web.Mvc.ControllerActionInvoker.InvokeActionResultFilterRecursive(IList1 filters, Int32 filterIndex, ResultExecutingContext preContext, ControllerContext controllerContext, ActionResult actionResult) at System.Web.Mvc.ControllerActionInvoker.InvokeActionResultFilterRecursive(IList1 filters, Int32 filterIndex, ResultExecutingContext preContext, ControllerContext controllerContext, ActionResult actionResult) at System.Web.Mvc.ControllerActionInvoker.InvokeActionResultFilterRecursive(IList1 filters, Int32 filterIndex, ResultExecutingContext preContext, ControllerContext controllerContext, ActionResult actionResult) at System.Web.Mvc.ControllerActionInvoker.InvokeActionResultFilterRecursive(IList1 filters, Int32 filterIndex, ResultExecutingContext preContext, ControllerContext controllerContext, ActionResult actionResult) at System.Web.Mvc.ControllerActionInvoker.InvokeActionResultFilterRecursive(IList1 filters, Int32 filterIndex, ResultExecutingContext preContext, ControllerContext controllerContext, ActionResult actionResult) at System.Web.Mvc.ControllerActionInvoker.InvokeActionResultFilterRecursive(IList1 filters, Int32 filterIndex, ResultExecutingContext preContext, ControllerContext controllerContext, ActionResult actionResult) at System.Web.Mvc.ControllerActionInvoker.InvokeActionResultWithFilters(ControllerContext controllerContext, IList1 filters, ActionResult actionResult) at System.Web.Mvc.Async.AsyncControllerActionInvoker.<>c__DisplayClass3_1.<BeginInvokeAction>b__1(IAsyncResult asyncResult) at System.Web.Mvc.Async.AsyncControllerActionInvoker.EndInvokeAction(IAsyncResult asyncResult) at System.Web.Mvc.Controller.<>c.<BeginExecuteCore>b__152_1(IAsyncResult asyncResult, ExecuteCoreState innerState) at System.Web.Mvc.Async.AsyncResultWrapper.WrappedAsyncVoid1.CallEndDelegate(IAsyncResult asyncResult) at System.Web.Mvc.Controller.EndExecuteCore(IAsyncResult asyncResult) at System.Web.Mvc.Async.AsyncResultWrapper.WrappedAsyncVoid1.CallEndDelegate(IAsyncResult asyncResult) at System.Web.Mvc.Controller.EndExecute(IAsyncResult asyncResult) at System.Web.Mvc.MvcHandler.<>c.<BeginProcessRequest>b__20_1(IAsyncResult asyncResult, ProcessRequestState innerState) at System.Web.Mvc.Async.AsyncResultWrapper.WrappedAsyncVoid1.CallEndDelegate(IAsyncResult asyncResult) at System.Web.Mvc.MvcHandler.EndProcessRequest(IAsyncResult asyncResult) at System.Web.HttpApplication.CallHandlerExecutionStep.System.Web.HttpApplication.IExecutionStep.Execute() at System.Web.HttpApplication.ExecuteStepImpl(IExecutionStep step) at System.Web.HttpApplication.ExecuteStep(IExecutionStep step, Boolean& completedSynchronously)`

The fix appears to be to comment out the following line in ..\Src\Foundation\Features\Shared\Views_Layout.cshtml
@*Model.SchemaMarkup*@

episerver/Foundation#596
also merge episerver.config into the web.config

The following line prevents Find to work: https://github.com/episerver/foundation-mvc-cms/blob/main/src/Foundation/Startup.cs#L53

Please just remove the line to make Find work as it should

If using -U <user> -P <password> in the sqlcmd in setup.cmd (instead of the default), this part won't be stored as arguments to the setup call from resetup.

Clone feature from episerver/Foundation#506

I am running setup.cmd as an administrator, and providing the following for SQL server name:
(LocalDb)\MSSQLLocalDB

Get the following output, before script terminates:

## Clean and build ##
## Dropping databases ##
## Dropping user ##
## Creating databases ##
\MSSQLLocalDB was unexpected at this time.

The logfile Build\Logs\Database.log contrains:

## Dropping databases ## 
## Dropping user ## 
## Creating databases ## 

I was, however, able to create the database running the scripts manually.

episerver/Foundation#619

Is your feature request related to a problem? Please describe.
As a developer I would like to have all the parts of a feature self contained in the features folder. Currently the models, view models, styles, and scripts are separated from the features folder.

Describe the solution you'd like
The feature folder should contain everything. The building of style sheets and JavaScript should automatically look in these folders.

Kestrel may treat URLs case-sensitive. Therefore, naming the folder as below causes issue in CMS when deploying to Linux while CMS expects the path to be all lowercase "contentediting": https://github.com/episerver/foundation-mvc-cms/tree/net5/src/Foundation/wwwroot/ClientResources/Scripts/ContentEditing.

We should probably remove the Episerver logo and update with the Optimizely one.

Secondly, the readme references this starter package including Commerce components which appears to be in error.

According to MDN, the DNT header use is not recommended: https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/DNT

But it is used in the SearchService:
https://github.com/episerver/foundation-mvc-cms/blob/net5/src/Foundation/Features/Search/SearchService.cs#L62

And this check actually doesn't work so that tracking is never enabled.

Content security policy does not allow YouTube block to work (I assume others as well). I don't know how to add it correctly, but I had to disable these lines in web.config to get YouTube block to work correctly.

The site works just fine locally on Windows OS (both IIS and Kestrel) but shows 404 when loading various of client resources when running on DXP Linux env. Some JS for TinyMCE also failed to load.
Tested on CMS 12.2 and 12.3.

Steps to reproduce:

1. Set up site, runs at localhost:5000 (default)
2. Go to CMS admin, manage websites and change all host name to a non-existing domain, except wildcard host
3. Back to edit mode at localhost:5000

Observed error:
System.NullReferenceException: Object reference not set to an instance of an object. at Foundation.Features.Settings.ButtonBackgroundColorSelectionFactory.GetSelections(ExtendedMetadata metadata) in ...\Src\Foundation\Features\Settings\CollectionSettings.cs:line 122 at EPiServer.Shell.UI.Rest.DefaultMetadataStoreModelCreator.GetSelections(ExtendedMetadata metadata, MetadataStoreModel metadataDTO, ISelectionFactory[] selectionFactories) at EPiServer.Shell.UI.Rest.DefaultMetadataStoreModelCreator.CreateFromModelMetadata(ExtendedMetadata metadata, LocalizationService localizationService, UIDescriptorRegistry uiDescriptorRegistry, ISelectionFactory[] selectionFactories, Boolean alwaysCreateChildProperties) at EPiServer.Shell.UI.Rest.DefaultMetadataStoreModelCreator.ExtractMetadataFromProperties(ExtendedMetadata metadata, MetadataStoreModel MetadataStoreModel, LocalizationService localizationService, UIDescriptorRegistry uiDescriptorRegistry, ISelectionFactory[] selectionFactories) at EPiServer.Shell.UI.Rest.DefaultMetadataStoreModelCreator.CreateFromModelMetadata(ExtendedMetadata metadata, LocalizationService localizationService, UIDescriptorRegistry uiDescriptorRegistry, ISelectionFactory[] selectionFactories, Boolean alwaysCreateChildProperties) at EPiServer.Shell.UI.Rest.DefaultMetadataStoreModelCreator.Create(ExtendedMetadata metadata) at EPiServer.Shell.UI.Rest.MetadataStore.Get(String id, String modelAccessor) at lambda_method814(Closure , Object , Object[] )
Suggestion: Needs null check or fault-tolerance logic.

Hi,
After deploying a site completely and create some new users.
I may not able to login using that new user (it already have WebAdmins or WebEditors or both role)
It just redirects to the home page without logging in.

Could you please take a look at it?

in Foundation MVC CMS. Not sure if this is already addressed and will be merged, but please add [Searchable(false)] attributes to page properties that don't belong in the index. They're showing up in the teaser/summary information in the search results page and in the Custom Search block. Things like "p-1", "m-0" or "light transparent" that stand out poorly in demos

Foundation CMS MVC - Search results summaries contain configuration values that probably should be excluded from index and summary information. For example, "10-5" on all these pages...

1. Bookmark feature missing
2. Remove ProfilePage in My Account in DB
3. Adding Settings page Uncomment <!--<add namespace="Foundation.Features.Settings"/>--> in Web.config
4. Lost login session when browser closed

DisplayWidth implementation in the Foundation Content Area Renderer breaks rows functionality of Bootstrap Content Area Renderer.

A nice feature of Valdis Bootstrap aware content area renderer is automatically inserted rows when 12 columns is to be passed.

However, the implementation of the foundation content area renderer breaks that.

So, that’s kind of a deal-breaker for some. We could just kick the FullWidth-rendering out and do our custom stuff in RenderContentAreaItem before calling base.RenderContentAreaItem to work WITH Valdis implementation of the base-renderer, and not against it.

So, either remove that fullwidth code or make it work WITH the base class implementation...

Fix page list block and blog list page template selection.
Separate SCSS

It looks like the display options are not respected when applied to form fields when in view mode. Seems to work in edit mode

<appData basePath="./appdata" />
should be

<appData basePath="./App_Data" />

Make view in TinyMCE and the view look the same

Since _MasterLayout renders metadata, title and OpenGraph metadata.

@Html.RenderMetaData(Model.CurrentContent)
<title> @Model.CurrentContent.Name</title>
@Html.RenderOpenGraphMetaData(Model)

And that you render title in opengraph as og:title and description as og:description using <meta property="{0}" content="{1}" />-syntax.

You should render title, description and keywords using <meta name="{0}" content="{1}" />-syntax.

Maybe there is a slim chance that name and property could both exist.

Tip for others:
I had node.js errors when running the setup.cmd.

I am using nvm, and I resolved the issue by installing the latest stable version on NodeJs 14.18.1.
The setup script failed with versions: 9.5.0 and 16.8.0

Use setting pages instead of settings in homepage

Step to reproduce

1. Checkout entire solution
2. Switch NET5 branch
3. Run Setup.cmd with administrative privilege encountered error while executing build.ps1
   

My environment execution policy configuration

Make sure to remove any and all inline styling that is hard coded. We should use CSS classes where possible

Foundation CMS MVC TeaserBlock does not appear to handle conditions where a user might only want a single image. The View assumes if one is present, then both are, which won't always be the case.
Foundation MVC CMS Teaser Block configuration for Elements Order doesn't appear to have any affect on the visual output of the block. If it doesn't do anything it should be removed. If it should do something then this is a bug to be fixed.

sessionState etc. is not a good option for load balanced environments.
What components in the current state of Foundation is dependent on sessionState?

We are currently very close to deployment of a Foundation-based project and are experience problems only in load balanced environments (and reverse proxy, Nginx). We are currently suspecting sessionState for our odd behaviors when working on custom error pages etc. (we have replaced Geta/404handler with a custom handler).

Is there more considerations needed to be taken when putting a Foundation-based project in a load balanced environment?

I would like to just turn sessionState to Off but don't know if there is any known huge implications other than what can be read here?

First block in News has text cutoff.