Giter VIP home page Giter VIP logo

Comments (5)

Akkadius avatar Akkadius commented on May 28, 2024

This is waiting on mysqldump to complete - which has no inherent feedback and can take some time depending on the database size. We could add a CLI loader to at least give feedback to the user

from server.

joligario avatar joligario commented on May 28, 2024

It used to say “updates needed” and “backing up database” or something similar.

from server.

Akkadius avatar Akkadius commented on May 28, 2024

I'll take a look in the next few days

from server.

Akkadius avatar Akkadius commented on May 28, 2024

Took a look at this, we do message to the user what is happening

 World |    Info    | CheckVersionsUpToDate ---------------------------------------------------------------------- 
 World |    Info    | CheckVersionsUpToDate   Server | database [9245] binary [9247] checking updates 
 World |    Info    | CheckVersionsUpToDate   Config | [server.auto_database_updates] [true] 
 World |    Info    | CheckVersionsUpToDate ---------------------------------------------------------------------- 
 World |    Info    | UpdateManifest [9246]       [ok] | [2023_12_07_keyring_id.sql] 
 World |    Info    | UpdateManifest [9247]  [missing] | [2023_12_14_starting_items_fix.sql] 
 World |    Info    | UpdateManifest ---------------------------------------------------------------------- 
 World |    Info    | UpdateManifest Automatically backing up database before applying updates 
 World |    Info    | UpdateManifest ---------------------------------------------------------------------- 
 World |    Info    | DatabaseDump MySQL installed [mysql  Ver 15.1 Distrib 10.11.4-MariaDB, for debian-linux-gnu (x86_64) using  EditLine wrapper] 
 World |    Info    | DatabaseDump Database [peq] Host [mariadb] Username [eqemu] 
 World |    Info    | DatabaseDump Database dump created at [backups/peq-2023-12-15.sql] 
 World |    Info    | DatabaseDump Compression requested. Compressing dump [backups/peq-2023-12-15.sql] 
 World |    Info    | DatabaseDump Compressed dump created at [backups/peq-2023-12-15.tar.gz] 
 World |    Info    | UpdateManifest ---------------------------------------------------------------------- 
 World |    Info    | UpdateManifest Running database migrations. Please wait... 
 World |    Info    | UpdateManifest ---------------------------------------------------------------------- 
 World |    Info    | UpdateManifest [9247] [2023_12_14_starting_items_fix.sql] [ok] 
 World |    Info    | UpdateManifest ---------------------------------------------------------------------- 
 World |    Info    | CheckDbUpdates Updates ran successfully, setting database version to [9247] from [9245] 

What might be confusing is there are a few lines of other info afterwards

 World |    Info    | CheckVersionsUpToDate ---------------------------------------------------------------------- 
 World |    Info    | CheckVersionsUpToDate   Server | database [9245] binary [9247] checking updates 
 World |    Info    | CheckVersionsUpToDate   Config | [server.auto_database_updates] [true] 
 World |    Info    | CheckVersionsUpToDate ---------------------------------------------------------------------- 
 World |    Info    | UpdateManifest [9246]       [ok] | [2023_12_07_keyring_id.sql] 
 World |    Info    | UpdateManifest [9247]  [missing] | [2023_12_14_starting_items_fix.sql] 
 World |    Info    | UpdateManifest ---------------------------------------------------------------------- 
 World |    Info    | UpdateManifest Automatically backing up database before applying updates 
 World |    Info    | UpdateManifest ---------------------------------------------------------------------- 
 World |    Info    | DatabaseDump MySQL installed [mysql  Ver 15.1 Distrib 10.11.4-MariaDB, for debian-linux-gnu (x86_64) using  EditLine wrapper] 
 World |    Info    | DatabaseDump Database [peq] Host [mariadb] Username [eqemu] 

^ so this is what a user sees and can easily miss a few lines above

from server.

Akkadius avatar Akkadius commented on May 28, 2024

Added some more lines to make it a little more obvious to users

 World |    Info    | LoadRules Loaded [721] rules(s) in rule_set [default] id [1] 
 World |    Info    | CheckVersionsUpToDate ---------------------------------------------------------------------- 
 World |    Info    | CheckVersionsUpToDate   Server | database [9247] binary [9248] checking updates 
 World |    Info    | CheckVersionsUpToDate   Config | [server.auto_database_updates] [true] 
 World |    Info    | CheckVersionsUpToDate ---------------------------------------------------------------------- 
 World |    Info    | UpdateManifest [9248]  [missing] | [some_new_migration.sql] 
 World |    Info    | UpdateManifest ---------------------------------------------------------------------- 
 World |    Info    | UpdateManifest Automatically backing up database before applying updates 
 World |    Info    | UpdateManifest ---------------------------------------------------------------------- 
 World |    Info    | DatabaseDump MySQL installed [mysql  Ver 15.1 Distrib 10.11.4-MariaDB, for debian-linux-gnu (x86_64) using  EditLine wrapper] 
 World |    Info    | DatabaseDump Database [peq] Host [mariadb] Username [eqemu] 
 World |    Info    | DatabaseDump Backing up database [mysqldump --defaults-extra-file=login.my.cnf peq --allow-keywords --extended-insert --max-allowed-packet=1G --net-buffer-length=32704 --skip-lock-tables   > backups/peq-2023-12-15.sql] 
 World |    Info    | DatabaseDump This can take a few minutes depending on the size of your database 
 World |    Info    | DatabaseDump LOADING... PLEASE WAIT... 

from server.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.