equalgames / game-scanner Goto Github PK

Expected Behavior

game-scanner should build on Linux with no issues.

Current Behavior

There are missing modules and other implementations (due to the use of cfg os-gating) that are not available on Linux:

error[E0583]: file not found for module `utils`
  --> /home/philpax/.cargo/registry/src/github.com-1ecc6299db9ec823/game-scanner-1.1.2/src/epicgames/mod.rs:14:1
   |
14 | mod utils;
   | ^^^^^^^^^^
   |
   = help: to create the module `utils`, create file "/home/philpax/.cargo/registry/src/github.com-1ecc6299db9ec823/game-scanner-1.1.2/src/epicgames/utils.rs" or "/home/philpax/.cargo/registry/src/github.com-1ecc6299db9ec823/game-scanner-1.1.2/src/epicgames/utils/mod.rs"

error[E0583]: file not found for module `utils`
  --> /home/philpax/.cargo/registry/src/github.com-1ecc6299db9ec823/game-scanner-1.1.2/src/gog/mod.rs:10:1
   |
10 | mod utils;
   | ^^^^^^^^^^
   |
   = help: to create the module `utils`, create file "/home/philpax/.cargo/registry/src/github.com-1ecc6299db9ec823/game-scanner-1.1.2/src/gog/utils.rs" or "/home/philpax/.cargo/registry/src/github.com-1ecc6299db9ec823/game-scanner-1.1.2/src/gog/utils/mod.rs"

(so on and so forth, there's more errors like this)

Possible Solution

Implement the relevant utils for Linux, or disable these modules on Linux.

Steps to Reproduce (for bugs)

Try to build game-scanner by itself, or as a dependency, on x86-64 Linux.

Context

Was just testing my existing code on Linux and noticed this. Not at all an issue - going to be running in Wine anyway - but I figured it was worth calling out. For now, I'm only including game-scanner on Windows as a workaround.

Your Environment

• Version used: 1.1.2
• Operating System and version: Arch Linux, HEAD all packages

With Rust 1.69 some logic in ntapi is considered no longer supported and as such compilation fails.

Expected Behavior

game-scanner fails to compile with Rust 1.69 due to one of its dependencies being outdated.

Current Behavior

game-scanner should compile fine on Rust 1.69

Possible Solution

Merge #109

Steps to Reproduce (for bugs)

1. Build any project that has game-scanner = "1.1.4" in it's Cargo.toml with Rust 1.69 on Windows

Context

I'm using game-scanner as a dependency for my modding tool: https://github.com/R2NorthstarTools/FlightCore/

I noticed a recent CI run failing and started investigating the issue.

Failing CI run: https://github.com/R2NorthstarTools/FlightCore/actions/runs/4756368935/jobs/8458495132#step:8:722

Your Environment

• Version used: 1.1.4
• Operating System and version: Windows 10 (GitHub runner, windows-latest)
• Link to your project: https://github.com/R2NorthstarTools/FlightCore/

wrong launch path to Fortnite, it shows epicgames launcher instead of FortniteClient-Win64-Shipping.exe

Expected Behavior

There should be documentation available for game-scanner 1.1.0 here.

Current Behavior

Documentation generation appears to have failed due to libsqlite3-sys attempting to build outside of OUT_DIR here.

Possible Solution

Not sure, but I assume this isn't a problem for other crates using rusqlite. Maybe try updating rusqlite and see if that fixes it?

Steps to Reproduce (for bugs)

Publish a version to crates.io and wait for docs.rs to generate the docs pages.

Context

I use docs.rs daily to look up how to operate libraries, but I wasn't able to do that with game-scanner due to the docs. Instead, I had to look at the code, which is always informative but not as efficient as having the docs available.