equalsraf / neovim-qt Goto Github PK

During some tests in a headless machine connected to a remote display server, I found scrolling to be pretty slow. Could this be a consequence of copying the entire scroll region on every scroll notification? Note that if this copying is performed by Qt in memory then a lot of data is transferred between the X server and client.

I'm going to try a shot in the dark(not familiar with Qt), but perhaps this would be faster if you performed a coordinate translation using setClipRect and translate? I think this kind of transformation can be directly mapped to the backend graphics engine(X11 in my case) APIs, and if so, it would be much more efficient.

Coordinate translation is what pynvim does, and the performance is pretty good despite the UI logic being implemented in python.

vim_request_screen is not autogenerated for me when I do make neovim_auto. I tried looking for this function in neovim sources, but I can't find any traces of it anywhere, even in the history. Do you have it in your own neovim clone perhaps? Am I doing something wrong?
If I try to compile without running neovim_auto, I get "Cannot connect to this instance of Neovim, its version is likely too old, or the API has changed", so the commited autogenerated files are out of date (autogenerated files shouldn't be commited in the first place in my opinion...)

%USERPROFILE%/.nvimrc file in windows isn't getting loaded. It stopped working after I upgraded to this version:

In the meantime where I temporarily move my .nvimrc file?

Hi

I'm planning to make some changes in the "builtin UI" infrastructure for the next month(after 0.1 release). My goal is to make every UI an external program that is spawned by nvim at startup so projects like neovim-qt are basically on the same layer as the builtin TUI.

The idea is to have nvim spawn the UI program and communicate to it via stdin/stdout, so the UI program doesn't have to worry about connecting to neovim.

This also lets one use the nvim binary to spawn any UI, all nvim command line options will be readily available to neovim-qt. For example, here's an idea of how neovim-qt could be used to edit files from stdin(the exact mechanism used to select which UI will be spawned is still going to be determined):

echo "file contents"  | nvim -u NONE --ui=neovim-qt -

I'm also preparing to implement nvim "remote mode" where nvim will be able to connect to other instances, so no UIs have to worry about connectivity beyond stdin/stdout.

Can you prepare neovim-qt to work in this scenario? I think this will only simplify things since it will no longer be necessary to worry about sockets or named pipes.

From r/neovim

$ make
Scanning dependencies of target neovim-qt_automoc
[  3%] Automoc for target neovim-qt
Generating moc_neovimconnector.cpp
Generating moc_neovim.cpp
Generating moc_neovimrequest.cpp
[  3%] Built target neovim-qt_automoc
Scanning dependencies of target neovim-qt
[  7%] Building CXX object src/CMakeFiles/neovim-qt.dir/util.cpp.o
/home/mike/root/projects/neovim-qt/src/util.cpp: In function ‘QByteArray NeovimQt::toByteArray(const msgpack_object&)’:
/home/mike/root/projects/neovim-qt/src/util.cpp:71:19: error: ‘MSGPACK_OBJECT_BIN’ was not declared in this scope
  if ( obj.type != MSGPACK_OBJECT_BIN ) {
                   ^
compilation terminated due to -Wfatal-errors.
make[2]: *** [src/CMakeFiles/neovim-qt.dir/util.cpp.o] Error 1
make[1]: *** [src/CMakeFiles/neovim-qt.dir/all] Error 2
make: *** [all] Error 2

The msgpack library seems too old. If you are already building neovim in the same machine you point cmake to the version in the neovim folder .e.g

cmake -DMSGPACK_INCLUDE_DIR=../../neovim/.deps/usr/include/ -DMSGPACK_LIBRARY=../../neovim/.deps/usr/lib/libmsgpack.a

Related #5. There may also be some errors if the library version is too new, because the API changed.

Not a big problem since it correctly loads the runtime files.

_nvimrc file:

set runtimepath+='C:/Program Files/NEOVIM/share/nvim/runtime'

set runtimepath?

Notice how the full runtimepath isn't shown. It stops at space.

I mean thing like:

(in the tb-remote-ui branch) resizing the GUI may have some unexpected effects e.g.

1. We drag the window to resize and afterwards the window is resized back
2. We resize the window, but the actual Neovim work area remains the same size, with a wide margin around it

There are multiple reasons for this issue

1. try_resize_ui does not guarantee a resize and SHOULD NOT be called simultaneously - Neovim will ignore paralell calls
2. When the user is dragging the window it will cause multiple calls to try_resize_ui, emphasizing the previous point
3. resizing can be expensive in drawing operations (i.e. takes time)

There are ways around these issues, but I would prefer to wait until the Neovim API becomes a bit more stable and the UI functions are place in the API metadata object (so the bindings generate signals for those calls as well). Preliminary suggestions

1. Collapse multiple calls to try_resize_ui and only make a single call at a time - this is similar to what was done for vim-qt
2. Delay repainting due to window resizing.

useful when pinning neovim-qt to taskbark

not sure if this is the right place to ask this since there isn't a place to file a bug for neovim in your repo.

Is it possible to create neovim builds in appveyor with python3 support? https://ci.appveyor.com/project/equalsraf/neovim

As we are not in a terminal any more, it should be possible to map key sequences using fine events like key press and key release.

If you are wondering about the use case, I have a vim extension that allows switching buffers in most recently used order. The goal is to mimic the Ctrl-Tab and Ctrl-Shift-Tab of others editors. Allowing to register an event on the Ctrl key released would allow me to register more appropriately when the buffer is used and have more reliable ordering of the buffers. Something similar to this question on Stack Overflow: Distinguishing between the hold and release of a modifier key between two keystrokes in Vim.

Reported by @jonaias in https://gist.github.com/jonaias/f02566d2aabd760edbe9

QWARN : TestConnector::spawn() Attempting to decode as QByteArray when type is 8 [Uknown msgpack type]
QWARN : TestConnector::spawn() "Found unexpected data type for metadata key" 

I have not verified this yet but it is probably a consequence of the STR/BIN changes in msgpack (type 8 is BIN, where the old type RAW(now STR) was 5 ). The solution would be to use BIN where RAW was used.

I updated neovim and neovim-qt to latest git versions, and I get this error when starting neovim-git:

QWidget::setMinimumSize: (/QDockWidget) Negative sizes (0,-1) are not possible
QWidget::setMaximumSize: (/QDockWidget) Negative sizes (0,-1) are not possible
Unsupported function attribute "async" QVariant(bool, false)
Unsupported function attribute "async" QVariant(bool, false)
Unsupported function attribute "async" QVariant(bool, true)
...
Neovim fatal error "The Neovim process has crashed"

[ 31%] Built target neovim-qt_automoc
Scanning dependencies of target neovim-qt
[ 33%] Building CXX object src/CMakeFiles/neovim-qt.dir/util.cpp.o
[ 35%] Building CXX object src/CMakeFiles/neovim-qt.dir/neovimconnector.cpp.o
In file included from /home/brix/neovim-qt/src/neovimconnector.cpp:1:
In file included from /home/brix/neovim-qt/src/neovimconnector.h:6:
In file included from /usr/include/qt5/QtCore/QProcess:1:
/usr/include/qt5/QtCore/qprocess.h:105:5: fatal error: 'metaObject' overrides a member function but is not marked 'override' [-Winconsistent-missing-override]
Q_OBJECT
^
/usr/include/qt5/QtCore/qobjectdefs.h:150:32: note: expanded from macro 'Q_OBJECT'
virtual const QMetaObject metaObject() const;
^
/usr/include/qt5/QtCore/qiodevice.h:70:5: note: overridden virtual function is here
Q_OBJECT
^
/usr/include/qt5/QtCore/qobjectdefs.h:150:32: note: expanded from macro 'Q_OBJECT'
virtual const QMetaObject *metaObject() const;
^
1 error generated.
make[2]: ** [src/CMakeFiles/neovim-qt.dir/neovimconnector.cpp.o] Error 1
make[1]: *** [src/CMakeFiles/neovim-qt.dir/all] Error 2
make: *** [all] Error 2

I'm getting this error message: Neovim fatal error "The Neovim process has crashed"

Note that GUI doesn't terminate when this happens, I have to kill it manually.

OS: Ubuntu 14.04
Qt: 5.5.1

I use neovim-qt as main editor (it is specified as default editor loading by click on file). When I click on file lying under the folder which name contains space character, Neovim-qt freezes.

Reproducing:

• Create folder with name test test
• Create file with name test.txt under it.
• Load file (using nautilus by click)

Neovim freezes and offers to retry.

Hi
I have started neovim in headless mode in remote server and connect from local laptop using tcp/ip msgpack.

Everything is working fine. But when i close the neovim-qt (which i will do accidently most of the time), it closes the nvim server which is running in the server. I am expecting only the connection get closed so that I can connect to the same nvim server after sometime.

Can we change the behavior of close button to just disconnect the session without actually closing the nvim running in headless mode.

This is very likely not a neovim-qt issue but a neovim. Just starting here to be sure.
I just downloaded the latest neovim and neovim-qt from appveyor.

When issuing :help command i get:

E433: No tags file
E149: sorry no help for help.txt

Not sure who should provide these.

Update: after looking around i found those files but it does not matter how i start neovim-qt it does not find the files. I guess i'd have to modify runtimepath for it to work? But it seems a bit to cumbersome for something that should be a package.

I'm not aware of how far this project has come, but I assume it should be handle plugins as the ones I've tried work decently. The Typescript plugin I use however fails to start. It communicates with a CLI server that provides syntax highlighting and autocomplete suggestions (clausreinke/typescript-tools.vim).

Error message when calling :TSSstarthere:

starting TSS...
['tss', 'stores.ts']

Error detected while processing function TSSstart..TSSshowErrors:
line   21:
TSS not running - start with :TSSstarthere on main file

I am not a vim expert, but it seems to point to function! TSSstart(...) at line 466 here: https://github.com/clausreinke/typescript-tools.vim/blob/master/ftplugin/typescript_tss.vim#L466

When running neovim-qt.exe without neovim in the path produces no output or error messages.
Nothing at all happens, not even when trying to run from cmd.exe.

Maybe some indication as to why it is not starting would be helpful. Maybe a messagebox?

The theme is wombat256, just open a file and scroll down.

We are not setting (or resetting) the bg colors properly, it also seems to apply to font attributes being missed

e.g. this diff

diff --git a/src/gui/shell.cpp b/src/gui/shell.cpp
index 83942b9..b0ccaf3 100644
--- a/src/gui/shell.cpp
+++ b/src/gui/shell.cpp
@@ -305,6 +305,7 @@ void Shell::handleScroll(const QVariantList& args, QPainter& painter)
 /** Ready a painter with Neovim settings */
 void Shell::setupPainter(QPainter& painter)
 {
+       m_hg_background = m_background;
        painter.setFont(m_font);
        painter.setPen(m_hg_foreground);
        painter.setBackground(m_hg_background);

helps a bit with a background, but not completely, it also causes other issues

TLDR; we are setting or unsetting the drawing properties when we shouldn't.

I am testing out my .vimrc with neovim.

First i transferred it to the new XDG_CONFIG_HOME location and renamed it.

Now when i tried to start neovim-qt it would just state that neovim was not responding.

After some fiddling in the command line i was able to start neovim and it printed:

Error detected while processing C:\Users\uidw8099\AppData\Roaming\nvim\init.vim:
line   90:
E484: Can't open file d:\Playground\neovim\Neovim\bin\syntax\syntax.vim
line  563:
E185: Cannot find color scheme 'zenburn'
Press ENTER or type command to continue

Well now it is clear why neovim-qt said it was stuck but there was no indication on neovim-qt's window.

Is there any way to forward this console information from neovim to the user?

I am using neovim with qt-neovim (linux arch). On gvim i could launch a maximized window with:

if has("gui_running")
    set lines 999 columns 999
endif

That is not working now tho. I tried removing the condition with no success.
Is there any way i can achieve that?

Hi Everyone. Longtime vim/linux user. Just starting w/ neovim/nvim-qt.

Neovim is built. ( /Code/VIM/NeoVim/build/bin/nvim)
nvim-qt is built (/Code/VIM/neovim-qt/build/bin/nvim-qt)

I've copied nvim into both neovim-qt ( and neovim-qt/build/bin/ )
I've copied ~/Code/VIM/NeoVim/runtime/* into neovim-qt (and neovim-qt/build/bin)

When I invoke nvim-qt I see the following message on my console:
$> ~/Code/VIM/neovim-qt/build/bin => ./nvim-qt
QWidget::setMinimumSize: (/QDockWidget) Negative sizes (0,-1) are not possible
QWidget::setMaximumSize: (/QDockWidget) Negative sizes (0,-1) are not possible
Neovim fatal error "No such file or directory"

In the popup window I see: "Unable to start nvim: No such file or directory"

Where does nvim-qt expect nvim to exist?

Thank you.

--Mike

Just tried the current master (311070f) with the current nvim package (NVIM 0.0.0-alpha (compiled Sep 23 2015 21:21:47)) and I am getting the following errors on the terminal:

QWidget::setMinimumSize: (/QDockWidget) Negative sizes (0,-1) are not possible
QWidget::setMaximumSize: (/QDockWidget) Negative sizes (0,-1) are not possible
Unknown Neovim function "Object vim_call_function(String fname, Array args) !fail" 
Unknown Neovim function "Dictionary vim_get_color_map()" 
Unknown Neovim function "Array vim_get_api_info()" 

The effect of this seems to be that it fails to render the colors that I configured.

I am using https://github.com/altercation/vim-colors-solarized with pathogen.

Example:

(in the tb-remote-ui branch) the text cursor is painted over existing characters. However for fullwidth characters, since we assume the cursor width is one cell it only covers half of the char.

I just updated my build from source and noticed these warnings. It looks like these are warnings about libraries necessary for tests. If they are just necessary for tests then I won't worry about it. If not, then it should probably be documented what to do about them.

> cmake ..                                                           /h/j/l/n/build (git)-[master] 
-- Downloading Msgpack...
-- Could NOT find GTest (missing:  GTEST_LIBRARY GTEST_INCLUDE_DIR GTEST_MAIN_LIBRARY) 
-- Could NOT find ZLIB (missing:  ZLIB_LIBRARY ZLIB_INCLUDE_DIR) 
-- Could NOT find Doxygen (missing:  DOXYGEN_EXECUTABLE) 
-- Could NOT find Doxygen (missing:  DOXYGEN_EXECUTABLE) 
-- Configuring done
-- Generating done

So I'm new at this CMake based build system and I'm failing to build the project.

It says something like not having Qt5NetworkConfig.cmake, I'm installing one from the internets and putting it under $CMAKE_MODULE_PATH but then it's saying

CMake Error at /home/omer/CMAKE_PREFIX_PATH/Qt5NetworkConfig.cmake:15 (message):
  The imported target "Qt5::Network" references the file

     "//include/"

  but this file does not exist.  Possible reasons include:
...

etc.

Any ideas?

Using a fresh version of neovim and neovim-qt on Ubuntu 14.04. As a package manager using NeoBundle. Config for installing nerdtree looks like this:

if has('vim_starting')
  if &compatible
    set nocompatible               " Be iMproved
  endif

  " Required:
  set runtimepath+=/home/lodin/.nvim/bundle/neobundle.vim/
endif

" Required:
call neobundle#begin(expand('/home/lodin/.nvim/bundle'))

" Let NeoBundle manage NeoBundle
" Required:
NeoBundleFetch 'Shougo/neobundle.vim'

" Add or remove your Bundles here:
NeoBundle 'scrooloose/nerdtree'

" Required:
call neobundle#end()

" Required:
filetype plugin indent on

" If there are uninstalled bundles found on startup,
" this will conveniently prompt you to install them.
NeoBundleCheck

" NERDTree config for opening nerdtree in every tab
autocmd StdinReadPre * let s:std_in=1
autocmd VimEnter * if argc() == 0 && !exists("s:std_in") | NERDTree | endif

Neovim-qt fails on start. Neovim console and :NERDTree command in Neovim-qt works fine.

I've just pushed support for busy_start and busy_stop GUI events, e.g. when Neovim blocks running a shell command the GUI knows about it. Currently it only changes the mouse cursor.

It might be useful to consider other things to do on busy_start:

1. Other types of visual feedback
2. Prevent user from sending keyboard input to Neovim, while it is busy (maybe not see next point)
3. (hypothetical) The user can cancel shell commands with ctrl-c, should we provide other means to send ctrl-c
4. how do we repaint the widget while busy? resize events wont be handled, etc (which takes us back to 1.)

A font changing dialog would be nice, but how do we trigger without risking shadowing a neovim mapping.

Otherwise if neovim/neovim#2203 is implemented we can wait for a notification for a predefined variable.

Earlier today when I was debugging neovim I blocked the nvim process on a trace - the obvious outcome on the GUI side was that the interface blocked completely - hardly a responsive feedback:

1. We need to setup some policy on the msgpack-rpc bits for request timeouts - dropping the request is likely not the best option, but at least a way to know something is wrong
2. Give the user some feedback

@Mariappan, fowlloing up on your comment in gitter.

@equalsraf I am using nvim-qt from appveyor build. Every time I try to open nvimqt in windows7, it opens one command prompt and then gui. Really annoying. Is there a way to suppress opening command prompt ??

Yes the prompt can and should be gone. I keep it around because it is helpful for debugging. Can be fixed by adding WIN32 to add_executable command.

diff --git a/src/gui/CMakeLists.txt b/src/gui/CMakeLists.txt
index 01a4e4b..1965549 100644
--- a/src/gui/CMakeLists.txt
+++ b/src/gui/CMakeLists.txt
@@ -2,7 +2,7 @@ set(QTLIBS Qt5::Network Qt5::Widgets)

 include_directories(..)
 qt5_add_resources(NEOVIM_RCC_SOURCES data.qrc)
-add_executable(nvim-qt main.cpp shell.cpp input.cpp errorwidget.cpp mainwindow.cpp
+add_executable(nvim-qt WIN32 main.cpp shell.cpp input.cpp errorwidget.cpp mainwindow.cpp
        ${NEOVIM_RCC_SOURCES}
        ${CMAKE_SOURCE_DIR}/third-party/konsole_wcwidth.cpp)
 target_link_libraries(nvim-qt ${QTLIBS} ${MSGPACK_LIBRARIES} neovim-qt)

It works fine in gvim, but when run in neovim-qt I get an error when running commands, such as "Gitv" or "Gstatus":

Not sure if this is a bug for neovim itself or for neovim-qt. Of course, it could be I am missing something :)

So I thought I might see something interesting for a Windows 10 machine with HiDPI and a scale factor of 250%. Unfortunately, this is my first time out with NeoVim and instead I think I have a non-working installation.

I installed using these instructions https://github.com/neovim/neovim/wiki/Installing-Neovim#windows

The running of nvim-qt.exe results in a small windows barely 3 title bars high and wide enough for an N logo, Maximize, and close button in the title bar. It can be expanded to show a larger N logo hidden within.
It does not appear to be interactive beyond placement and sizing, nor does it contain menus or options.

When i startup the window is quite small, about 210x130 px. Is there a way to configure the startup size?

The greates problem is that i cannot see the error messages, just some gibberish pixels:

This is also the startup size.

To reproduce:

Open neovim-qt
type :q<CR>
observe that the window doesn't close
click the mouse, or press any key
observe that only now does the window close.

I'm using HEAD of both neovim and neovim-qt

gvim shows cursor similar to this.

With #30 the UI can now keep track of the current Neovim mode (insert, normal, replace, etc). e.g. the Vim UIs use different text cursors for normal/replace/insert mode.

I'm not sure if this is a problem wtih neovim-qt or neovim reporting the wrong colors.

What I see in neovim-qt is:

What i expect to see is (this was taken from vim under cygwin:

If this is a neovim problem i will gladly post it there.

I'm getting this error during build. I believe I have Qt5 installed since Qt Creator works. The error:

CMake Error at CMakeLists.txt:32 (find_package):
  By not providing "FindQt5Widgets.cmake" in CMAKE_MODULE_PATH this project
  has asked CMake to find a package configuration file provided by
  "Qt5Widgets", but CMake did not find one.

  Could not find a package configuration file provided by "Qt5Widgets" with
  any of the following names:

    Qt5WidgetsConfig.cmake
    qt5widgets-config.cmake

  Add the installation prefix of "Qt5Widgets" to CMAKE_PREFIX_PATH or set
  "Qt5Widgets_DIR" to a directory containing one of the above files.  If
  "Qt5Widgets" provides a separate development package or SDK, be sure it has
  been installed.

I'll try updating it...

Not sure if this belongs to neovim or neovim-qt. When using "*y I get this message.

need <--> cursor in near the window split zone. Although mouse split does work already.

...would be nice :)

This is about your neovim build at AppVeyor. I would have liked to create an issue in your neovim repository but there you have Issues disabled.

it seems that neovim is build without python2 support. i have not checked for Python3 as i don't use it.

It is very convient being able to download ready built versions and yours seem to be the only one available for windows. Thank you.

With python support enabled i'd be able to test many more things under windows as that is my only development platform.

When I start neovim-qt my ginit.vim file in ~/.config/nvim is not sourced. I can source it manually with runtime ginit.vim so rtp should be ok.

nvim: 0.1.1
nvim-qt: 85dd35b

The value of v:windowid is not properly defined on Windows. It should be the number corresponding to Neovim-Qt window handle. I am not sure if GetActiveWindow() is the correct function to get the window handle in this case, but once you get it you can cast it to long (32 bit) or long long (64 bit).

On Linux, nvim running in a terminal emulator does not set the value of v:windowid, but we can use the value of $WINDOWID.

38644b9 introduced a bug in data handling, the master branch already includes a fix for MsgpackIODevice::dataAvailable() from #66, but the other functions need similar. fixes.

Trying to compile this under windows but it is failing.

Cmake aborts with the following message:

By not providing "FindQt5Widgets.cmake" in CMAKE_MODULE_PATH this project
  has asked CMake to find a package configuration file provided by
  "Qt5Widgets", but CMake did not find one.

  Could not find a package configuration file provided by "Qt5Widgets" with
  any of the following names:

    Qt5WidgetsConfig.cmake
    qt5widgets-config.cmake

  Add the installation prefix of "Qt5Widgets" to CMAKE_PREFIX_PATH or set
  "Qt5Widgets_DIR" to a directory containing one of the above files.  If
  "Qt5Widgets" provides a separate development package or SDK, be sure it has
  been installed.

I guess i need the Qt5 sources? Is it not possible to just use the windows binaries for Qt?

It would be nice if windows compilation instructions could be added.