erasaur / binary Goto Github PK

e.g lifecycle hooks

Hi,

I saw there is a Follow button on each question, but I can't find a place which list all the questions I am following. Would it be ok to add it to the user's following tab?

Several consequences as a result:

• shown reply boxes will not be removed
• infinite scroll will not be rerun

Both can be relatively easily worked around but we should think of a way to do the transition better. (Maybe we can have a separate template for the single comment page?)

See https://github.com/meteor/meteor/blob/devel/packages/accounts-base/accounts_server.js. The onCreateUser hooks are run before validation happens (e.g duplicate email).

• currentTab can be a reactiveVar on a parent template (e.g pageLayout), with child templates accessing the var with template extension (template.get('currentTab').get()) rather than part of controller state

Using a session to store the token and immediately calling done when the link is clicked (onResetPasswordLink and onEmailVerificationLink) is not exactly the best way. Also, customize the urls for these links (e.g remove the #)

E.g tracking pageviews and clicks. Eventually, we would want to display analytics to topic creators as well -- maybe have some metrics about the response to the topic.

Related to #2

Edit: This is an untested pattern but it seems like it might work.

• in topic route, subscribe to a static number of comments (e.g 15) -- the main purpose is just to allow fast-render to work (also subs manager)
• handle all other subscriptions within the topic template: use an autorun with a reactiveVar (holding the "limit" of comments) defaulted to same number as the amount fast-rendered (e.g 15)
• invalidating autorun (e.g changing the limit with infinite scrolling) will cause subscription to more docs

Even for things like showing the list of comments in a topic, subscribing at the route-level is problematic. When infinite scrolling causes Session.get('itemsLimit') to change, the layout-related calls (e.g this.render('nav', { to: 'nav' })) are re-run so the entire page 'flashes' and shoots back up to the top. Handling the topic comments as a component is a convenient way to fix this.

Alternatively, for things like topic lists that don't seem to fit well within template subs (or that we want to handle with subs-manager or fast-render), we could store the limit on the controller and handle subscriptions as usual. The drawback is that rendering any templates outside of this.ready() block in the action hook will cause the page 'flash' issue so there is less flexibility with the loading template.

Maybe use nested layouts, where the wrapping layout won't rerun? (e.g things like the container and the nav shouldn't have to be rerendered)

Also preserve original value

Toastr errors are quick and easy but not the greatest looking.

As of now including the signup modal in the dom by default is problematic since it can be easily triggered even when the user is logged in. With a package that handles modals with Blaze.render we can make things a bit cleaner and make it harder to accidentally trigger a modal we shouldn't see.