Giter VIP home page Giter VIP logo

pvparena's People

Contributors

chrislane avatar eredrim avatar ffaen avatar iaccidentally avatar nodiusc avatar oruss7 avatar oskarkk avatar slipcor avatar zyxep avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar

pvparena's Issues

NullPointerException LateLounge.hasSpawn

Paper dev 138 (Spigot 1.14.4)
PVPArena dev 316

Player mis-typed CTF and this exception occurred.

[12:32:17] [Server thread/INFO]: player issued server command: /pa cft
[12:32:17] [Server thread/ERROR]: null
org.bukkit.command.CommandException: Unhandled exception executing command 'pa' in plugin pvparena v1.14.1-SNAPSHOT-b316
	at org.bukkit.command.PluginCommand.execute(PluginCommand.java:47) ~[patched_1.14.4.jar:git-Paper-138]
	at org.bukkit.command.SimpleCommandMap.dispatch(SimpleCommandMap.java:159) ~[patched_1.14.4.jar:git-Paper-138]
	at org.bukkit.craftbukkit.v1_14_R1.CraftServer.dispatchCommand(CraftServer.java:739) ~[patched_1.14.4.jar:git-Paper-138]
	at net.minecraft.server.v1_14_R1.PlayerConnection.handleCommand(PlayerConnection.java:1800) ~[patched_1.14.4.jar:git-Paper-138]
	at net.minecraft.server.v1_14_R1.PlayerConnection.a(PlayerConnection.java:1608) ~[patched_1.14.4.jar:git-Paper-138]
	at net.minecraft.server.v1_14_R1.PacketPlayInChat.a(PacketPlayInChat.java:47) ~[patched_1.14.4.jar:git-Paper-138]
	at net.minecraft.server.v1_14_R1.PacketPlayInChat.a(PacketPlayInChat.java:5) ~[patched_1.14.4.jar:git-Paper-138]
	at net.minecraft.server.v1_14_R1.PlayerConnectionUtils.lambda$ensureMainThread$0(PlayerConnectionUtils.java:23) ~[patched_1.14.4.jar:git-Paper-138]
	at net.minecraft.server.v1_14_R1.TickTask.run(SourceFile:18) ~[patched_1.14.4.jar:git-Paper-138]
	at net.minecraft.server.v1_14_R1.IAsyncTaskHandler.executeTask(IAsyncTaskHandler.java:136) ~[patched_1.14.4.jar:git-Paper-138]
	at net.minecraft.server.v1_14_R1.IAsyncTaskHandlerReentrant.executeTask(SourceFile:23) ~[patched_1.14.4.jar:git-Paper-138]
	at net.minecraft.server.v1_14_R1.IAsyncTaskHandler.executeNext(IAsyncTaskHandler.java:109) ~[patched_1.14.4.jar:git-Paper-138]
	at net.minecraft.server.v1_14_R1.MinecraftServer.aX(MinecraftServer.java:1014) ~[patched_1.14.4.jar:git-Paper-138]
	at net.minecraft.server.v1_14_R1.MinecraftServer.executeNext(MinecraftServer.java:1007) ~[patched_1.14.4.jar:git-Paper-138]
	at net.minecraft.server.v1_14_R1.IAsyncTaskHandler.executeAll(IAsyncTaskHandler.java:95) ~[patched_1.14.4.jar:git-Paper-138]
	at net.minecraft.server.v1_14_R1.MinecraftServer.sleepForTick(MinecraftServer.java:990) ~[patched_1.14.4.jar:git-Paper-138]
	at net.minecraft.server.v1_14_R1.MinecraftServer.run(MinecraftServer.java:924) ~[patched_1.14.4.jar:git-Paper-138]
	at java.lang.Thread.run(Thread.java:748) [?:1.8.0_212]
Caused by: java.lang.NullPointerException
	at net.slipcor.pvparena.modules.latelounge.LateLounge.hasSpawn(LateLounge.java:141) ~[?:?]
	at net.slipcor.pvparena.PVPArena.onCommand(PVPArena.java:347) ~[?:?]
	at org.bukkit.command.PluginCommand.execute(PluginCommand.java:45) ~[patched_1.14.4.jar:git-Paper-138]
	... 17 more

Several Arenas now requiring exit spawns

Several arenas, which before would simply deposit players to the spot where they joined from, now require exit spawns. These include Spleef and FFA arenas.

image

Version: the latest snapshot (324)

Option to delay scoreboard setting.

Paper dev 273 (Spigot 1.15.2)
PVPArena dev 319

Example Config
https://paste.ubuntu.com/p/rnw2MWyQkw/

https://prnt.sc/se7os2
https://prnt.sc/se7o68
https://imgur.com/a/6q7mGq2

I'm running into an issue where PVPArena is not colorizing team colors or player names correctly when players join the arena. It doesn't seem to happen for everyone but happens a good portion of the time that there is breakage every game, enough that it is breaking colors being set and causing confusion with white player names.

I use the plugin TAB to colorize nametags outside of arenas. However TAB is configured to not auto-refresh and is set to disable in the arena world void to prevent conflict.
https://www.spigotmc.org/resources/tab-1-5-x-1-15-x-free-version.57806/
https://github.com/NEZNAMY/TAB

TAB Config Reference
https://paste.ubuntu.com/p/zVQVY5KYrd/

Removing TAB's disabled nametag world feature lets players keep their "outside" scoreboard group colors when they join the arena world, but PVPArena does not override the scoreboard with the game's own colors when they join. So I keep TAB's world disabled setting enabled in the arena world.

My guess why there is a problem;

  • PVPArena does not set scoreboard groups that override on arena join if they are already part of a scoreboard group. Because of this, it's important to disable any scoreboards in the same world to prevent conflict.
  • When joining an arena, PVPArena tries to assign scoreboards at the same tick time that TAB tries to "disable" its own scoreboard when entering that world. Thus it assumes it has already assigned someone to the correct team when they may not be part of it.

Assumed solution would be adding an option to delay scoreboard setting / restoring by x number of ticks.

Questions respect rewards

Can i make that with a command give money to my users? also I have this error when run in 1.15.2

.... [20:38:54 WARN]: [PVP Arena] Task #416231 for pvparena v1.14.0 generated an exception
java.lang.ArithmeticException: null

UnsupportedOperationException: null

PVPArena compiled as of commit f8da5ec
PVPArena Modules compiled as of Eredrim/pvparena_modules@30e5188
WorldEdit dev 4997 (bukkit-7.2.0-SNAPSHOT)
Tuinity dev 78 (Paper Fork - Spigot 1.15.2)

@Eredrim Broke in commit Eredrim/pvparena_modules@8c6a61d ?

[10:43:18] [Server thread/WARN]: [PVP Arena] Task #313969 for pvparena v1.15.0-SNAPSHOT generated an exception
java.lang.UnsupportedOperationException: null
	at com.google.common.collect.UnmodifiableIterator.remove(UnmodifiableIterator.java:46) ~[patched_1.15.2.jar:git-Tuinity-"90d3772"]
	at com.sk89q.worldedit.extent.world.SideEffectExtent$1.resume(SideEffectExtent.java:113) ~[?:?]
	at com.sk89q.worldedit.function.operation.OperationQueue.resume(OperationQueue.java:92) ~[?:?]
	at com.sk89q.worldedit.function.operation.Operations.completeBlindly(Operations.java:74) ~[?:?]
	at com.sk89q.worldedit.EditSession.flushSession(EditSession.java:829) ~[?:?]
	at net.slipcor.pvparena.modules.worldedit.PAWE.load(PAWE.java:289) ~[?:?]
	at net.slipcor.pvparena.modules.worldedit.PAWE.load(PAWE.java:254) ~[?:?]
	at net.slipcor.pvparena.modules.worldedit.PAWE.reset(PAWE.java:344) ~[?:?]
	at net.slipcor.pvparena.loadables.ArenaModuleManager.reset(ArenaModuleManager.java:266) ~[?:?]
	at net.slipcor.pvparena.arena.Arena.reset(Arena.java:1454) ~[?:?]
	at net.slipcor.pvparena.runnables.EndRunnable.commit(EndRunnable.java:53) ~[?:?]
	at net.slipcor.pvparena.runnables.ArenaRunnable.run(ArenaRunnable.java:161) ~[?:?]
	at org.bukkit.craftbukkit.v1_15_R1.scheduler.CraftTask.run(CraftTask.java:84) ~[patched_1.15.2.jar:git-Tuinity-"90d3772"]
	at org.bukkit.craftbukkit.v1_15_R1.scheduler.CraftScheduler.mainThreadHeartbeat(CraftScheduler.java:461) ~[patched_1.15.2.jar:git-Tuinity-"90d3772"]
	at net.minecraft.server.v1_15_R1.MinecraftServer.b(MinecraftServer.java:1310) ~[patched_1.15.2.jar:git-Tuinity-"90d3772"]
	at net.minecraft.server.v1_15_R1.DedicatedServer.b(DedicatedServer.java:431) ~[patched_1.15.2.jar:git-Tuinity-"90d3772"]
	at net.minecraft.server.v1_15_R1.MinecraftServer.a(MinecraftServer.java:1227) ~[patched_1.15.2.jar:git-Tuinity-"90d3772"]
	at net.minecraft.server.v1_15_R1.MinecraftServer.run(MinecraftServer.java:958) ~[patched_1.15.2.jar:git-Tuinity-"90d3772"]
	at java.lang.Thread.run(Thread.java:834) [?:?]

Powerups not working

PVP Arena version 1.15.0-SNAPSHOT-b323
Powerups version 1.14.1-SNAPSHOT
Server version: git-Paper-280 (MC: 1.15.2)

Arena config in attach.

Powerup "Heal" don't spawn at spawnpoint powerupX.
There is no errors in servver logs.

CTFArena.txt

BetterClasses module - respawnCommand runs twice and runs on initial spawn into the arena.

PVPArena dev 341
Modules dev 213
Paper dev 101 (Spigot 1.16.1)
LibsDisguises dev 674

Arena Config - BlockHunt
https://paste.ubuntu.com/p/FYMh7TrnGm/

The BetterFight respawnCommand setting seems to run twice when it occurs and also runs on initial spawn into the arena.

  1. Can the respawnCommand only run once?

  2. Can it only run for actual respawns and not any spawns, i.e. initial spawning into the arena on game start?


Per my server logs;

Was an initial infected.

[19:39:44] [Server thread/INFO]: Gurrecool not disguised!
[19:39:44] [Server thread/INFO]: Gurrecool not disguised!

Was an initial survivor who got infected.

[19:39:59] [Server thread/INFO]: TheFinalSnow is no longer disguised
[19:39:59] [Server thread/INFO]: TheFinalSnow not disguised!

Was an initial infected.

[19:45:45] [Server thread/INFO]: PoopSecret not disguised!
[19:45:45] [Server thread/INFO]: PoopSecret not disguised!

Was an initial survivor who got infected.

[19:46:04] [Server thread/INFO]: brynhill is no longer disguised
[19:46:04] [Server thread/INFO]: brynhill not disguised!

Was an initial infected.

[20:07:26] [Server thread/INFO]: TheFinalSnow not disguised!
[20:07:26] [Server thread/INFO]: TheFinalSnow not disguised!

Was an initial infected.

[20:09:14] [Server thread/INFO]: Beary325 not disguised!
[20:09:14] [Server thread/INFO]: Beary325 not disguised!

Was an initial survivor who got infected.

[20:21:56] [Server thread/INFO]: brynhill is no longer disguised
[20:21:56] [Server thread/INFO]: brynhill not disguised!

Turrets Not Working

Running Paper-164
Running pvparena-b317
Turrets don't seem to function, even with pressure plates down, turret locations identified and the mod installed. Only tested on a team CTF arena so far.

specialjoin mod doesnt work

unable to use the command to /pa (arena) setjoin

It give you the message "Setting join Block!"
but no matter what you do, right or left click.. using wand, using stick... cant make a selection. I'm trying on all the blocks it says works - lever, button, sign.

Typing the command again ends the selection

Possibility to avoid respawning with death screen

Forked from #25

By spam clicking and assumed being able to click the respawn screen before PVPArena hides it, players are able to respawn exactly where they died if they have multiple lives. Basically cancelling any teleport events the arena is trying to handle (i.e. respawn in spawn locations or respawn in spectator location).

Faction Enhancement not working

Im using Paper v88 1.15.2 on Linux and installed factions enhancement but is not working.
i have no error logs, also the only plugin restricting pvp in that area is SavageFactions (nearly the same core of MassiveCore Factions)

teleportProtect parametr not working

I need to switch off teleportProtect for some teleportation class abilities.
At the moment, such abilities cause temporary invulnerability (~3 sec). Changing the parameter by 0 seconds does not bring any result.

PVP Arena version 1.15.0-SNAPSHOT-b323
Server version: git-Paper-307 (MC: 1.15.2)

{loungeinteract: true} not working

What steps will reproduce the problem?

  1. Create arena
  2. set loungeinteract: true
  3. join arena and attempt interactions with various items/blocks (for example, chests, buttons, etc..).

What type of arena are you using? (ctf? teams? free?)
Teams, specifically team deathmatch.

What is the expected output? What do you see instead?
Some sort of interaction with buttons, chests, barrels. Nothing happens.

What version of PVP Arena // CraftBukkit are you using? ("latest" will flag this as invalid!!)
1.14.0

What does "/pa version" print out? (screenshot or via console and copy from logfile)

https://pastebin.com/nWj4AKbu

Do you have an error log of what happened? (www.pastebin.com)
No error

Please post your arena arena yml(s). (www.pastebin.com)

https://pastebin.com/LEVXg9fm

Please provide any additional information below:
I am specifically trying to get commandsigns to work while in the arena, however as of now, it does not. I first thought this was an issue of the compatebility between the two different plugins, but then I noticed that the player is not able to interact with regular chests/barrels too.

Inventory loss due to BattlefieldGuard module when entering region from outside.

PVPArena dev 336
Modules as of dev 209

@Eredrim I managed to find a reproductive step leading to loss of inventory / wiping / cloning!

If a non-admin player get's out of the lounge without tp, and then climbs up any of the island arenas. When half-way up climbing, the player gets automatically kicked out of the duel arena and is then teleported to /spawn for a split second. After that split second, the player is then teleported back to the original area the player was before joining /duel . Their whole inventory is wiped and replaced with the arena kit.

When entering.
In the lounge -> walk into a map’s battlefield region -> kicked to spawn -> tped back to lounge -> leave using /pa leave = inventory glitch

More specifically;

link

It happens when players somehow manage to leave the lounge and try to "enter" from outside into a region / arena that is protected with BattlefieldGuard. I'm unsure if they were trying to enter the same arena they were in the lounge for or just any existing in the area (but part of same shortcut rotation) -- or if that even matters. But they were trying to enter from outside while in a readying state.

This might also happen if you try to leave a battlefieldguard region when readying or in battle state -- still testing though.

Players are invisible to others when killed and infected, respawning the same tick as death while disguised.

PVPArena dev 341
Modules dev 213
Paper dev 101 (Spigot 1.16.1)
LibsDisguises dev 674

FREE players spawn with an item that opens a custom GUI that lets them disguise as a block from console via commands such as /disguiseplayer %player% falling_block MELON setGridLocked.

Example Disguise GUI
https://paste.ubuntu.com/p/Y4kmq7wYWs/

Arena Config - BlockHunt
https://paste.ubuntu.com/p/FYMh7TrnGm/

LibsDisguise Config
https://paste.ubuntu.com/p/nKD7mFSG7V/

When an INFECTED player kills a FREE player, they respawn on the infected team and undisguised, per the betterclasses module;

    respawnCommand:
      free: ''
      custom: ''
      '%infected%': undisguiseplayer %player%

However upon respawning / dying while disguised, they are invisible to other infected players. I assume this is caused by handling respawning and undisguising at the same tick/time. As when players are killed while not disguised, they respawn being visible to others on the infected team perfectly fine.

Toggling the setting preventDeath: false and removing the respawnCommand does not fix the issue, as players are not undisguised when killed and sometimes end up in a death loop / visual glitch.

Edit: Had a death respawn bug / loop even with preventDeath: true, so assume it's also caused by teleporting and undisguising same tick? :(

Duel arena requires more spawns than the maximum players allowed.

PVPArena dev 324

Config Example
https://paste.ubuntu.com/p/VK7J5J8HdZ/

Arena seems to require more spawns available than the maximum player count to be able to join. I only allow 2 people to fight in my duel arena, however I'm forced to set additional spawns that overlap each other since it claims spawns are missing.

i.e.

  spawn1: void,-1235,75,1256,269.9588317871094,0.8553600311279297
  spawn2: void,-1195,76,1259,89.9615478515625,0.11487597972154617
  spawn3: void,-1235,75,1256,269.9588317871094,0.8553600311279297
  spawn4: void,-1195,76,1259,89.9615478515625,0.11487597972154617

Assuming this is caused by using the smartspawn algorithm? If it requires an additional spawn above the number of maximum players for calculations.

For reference, I use smart instead of quick spawning because I always want the dueling partner to spawn the furthest away from the alive player.

[1.15] CTF issue

Opened by mibby

Players are still not able to claim captured flags in CTF using the Flags goal. Maybe "touchdown" was in quotes for a reason in the source?

Upon testing, red team was able to grab blue team's flag at the start of the game. However blue's flag was white when the game started. After grabbing it and bringing it home, the flag returned and the white wool turned blue properly. Once the first claim was done, red was unable to grab the flag again. I think there may be an issue with returned flags not being able to be grabbed or turned in after the initial spawn. Such as if someone dies with the flag or makes a touchdown.

Config Example
https://paste.ubuntu.com/p/b3hJg2pZpn/


Ah, yep, that's definitely the issue. Blue's flag turns white at game start but can be grabbed. It is light_blue wool on the player's head and can be turned in. Once the source flag block is returned, blue's flag block properly goes back to what it is defined as instead of white. However no one can claim or turn in the block if it's light_blue wool. If I set the wool to white with worldedit, it properly can be claimed or turned in at.

So the dev branch is setting one of the team's flag location colors improperly.

BetterFight module - Option to add knockback registering events when throwing snowballs / eggs.

Once upon a time, there was a bukkit bug that had snowballs and eggs thrown at players cause pvp knockback. This was never originally part of vanilla minecraft but this bug existed long enough that people always assumed it was part of it -- until bukkit finally fixed it. This bug was used in games such as Spleef to prevent corner camping by allowing snowballs to be thrown at players to knock them backwards, off the platform.

The plugin OldCombatMechanics tries to re-implement this bug as a legacy combat option. However I personally do not use legacy mechanics and at this point of time, try to embrace current version combat.
https://github.com/kernitus/BukkitOldCombatMechanics

https://github.com/kernitus/BukkitOldCombatMechanics/blob/10a790a3cfd2cdc38b40ee6dddeaf235647df87b/src/main/java/kernitus/plugin/OldCombatMechanics/module/ModuleProjectileKnockback.java

They also tried re-implementing fishing rod knockback that was used in very old server games as well. For reference;
https://github.com/kernitus/BukkitOldCombatMechanics/blob/10a790a3cfd2cdc38b40ee6dddeaf235647df87b/src/main/java/kernitus/plugin/OldCombatMechanics/module/ModuleFishingKnockback.java

Would it be possible for the BetterFight module to get an option to listen for snowball/egg pvp interact events and throw a damage event to cause knockback only while players are inside the arena (such as spleef)?

Reloading specific arenas does not reload the class chest contents.

PVPArena dev 319

If you reload a specific arena with /pa <arena> reload, the class chest location contents do not get refreshed. You have to join the arena, play in it, then have it end to refresh.

However if you reload with /pa reload, the chest contents do seem to get reloaded.

Unable to join an arena on a specific team anymore.

PVPArena dev 340

Players are unable to join an arena on a specific time anymore with the command /pa <arena> <team>. Such as /pa ctf red when joining from outside. If this is intended, could you perhaps add a command to switch teams from within the lobby?

Broke in commit e5c0e58 ?

Unable to use ender pearl in BATTLE region

I have tried disabling TELEPORT and ALL protections and I am still unable to use ender pearl. Ender pearl works just fine right outside of the region, so it's definitely due to PVP Arena. Back when I used War plugin, I used to give one of my classes some ender pearls so he can teleport around the map and I wanted to recreate that class. Is this due to a bug, or is it part of the feature? Thank you.

RespawnRelay - Infect arena ends when all infected are "respawning"

I've got an infect arena using RespawnRelay where each infected has multiple lives.

Despite the infected having lives left, the game will end when every infected player has to "respawn" at the same time. The message "The infected have been killed" displays to players, and the console spits out [WARN] [PVP Arena] player null!. If there's at least one infected that stays alive while others are respawning, the game functions normally. They are only safe to die when another infected has respawned.

This issue is easily reproducible with the one infected player at the start of the game. Kill that player before they can infect anyone. They'll die and it'll display their lives remaining, but then the game will end.

Question - Are players kicked out of the arena first before teleporting to old location on restore?

PVPArena dev 341
Modules dev 213
Paper dev 101 (Spigot 1.16.1)

Arena Config - BlockHunt
https://paste.ubuntu.com/p/FYMh7TrnGm/

I've been getting some reports from players that they are brought to my spawn location on game end, and only then after are brough back to their old joining location.

tp:
  death: old
  exit: old
  lose: old
  win: old

My spawn is set as an exit location, but all tp is configured to teleport to old on end.

spawns:
  exit: spawn,9,58,0,-269.92340087890625,13.349924087524414

The BattlefieldGuard module is enabled, which leads me to believe that it is protecting the arena and teleporting players out due to being inside the region on game end. Thus leads to the question -- are players kicked out of the arena playing state before they are restored and teleported to old?

InventoryRefillRunnable - ArrayIndexOutOfBoundsException

Greetings,
Just want to keep the items the player has when they die, tried using refillInventory: true and refillCustomInventory: true and even set preventDeath: false (just in case).

The items are "unique" however, nothing crazy. I have added a picture of the test item.

[10:26:07] [Server thread/WARN]: [PVP Arena] Task #1340 for pvparena v1.13.9.301 generated an exception java.lang.ArrayIndexOutOfBoundsException: -1 at net.slipcor.pvparena.arena.ArenaClass.equip(ArenaClass.java:166) ~[?:?] at net.slipcor.pvparena.runnables.InventoryRefillRunnable.run(InventoryRefillRunnable.java:88) ~[?:?] at org.bukkit.craftbukkit.v1_13_R2.scheduler.CraftTask.run(CraftTask.java:81) ~[spigot-1.13.2_LATEST.jar:git-Spigot-573cdf2-dff66df] at org.bukkit.craftbukkit.v1_13_R2.scheduler.CraftScheduler.mainThreadHeartbeat(CraftScheduler.java:391) [spigot-1.13.2_LATEST.jar:git-Spigot-573cdf2-dff66df] at net.minecraft.server.v1_13_R2.MinecraftServer.b(MinecraftServer.java:893) [spigot-1.13.2_LATEST.jar:git-Spigot-573cdf2-dff66df] at net.minecraft.server.v1_13_R2.DedicatedServer.b(DedicatedServer.java:417) [spigot-1.13.2_LATEST.jar:git-Spigot-573cdf2-dff66df] at net.minecraft.server.v1_13_R2.MinecraftServer.a(MinecraftServer.java:835) [spigot-1.13.2_LATEST.jar:git-Spigot-573cdf2-dff66df] at net.minecraft.server.v1_13_R2.MinecraftServer.run(MinecraftServer.java:733) [spigot-1.13.2_LATEST.jar:git-Spigot-573cdf2-dff66df] at java.lang.Thread.run(Thread.java:748) [?:1.8.0_131]

https://i.gyazo.com/85b7bf64bfcc575725241278a0d91497.png

Spigot Version: 1.13.2
PA Version: v1.13.9.301

Let me know if there is anymore info you need.

Thanks!

Edit: The item does have NBT data if that helps. Uses ItemFlags HIDE_ATTRIBUTES, HIDE_UNBREAKABLE, HIDE_POTION_EFFECTS
Config: https://pastebin.com/PFKAtM0m

NPCs (fake players) are showing up in PVPArena stats.

Citizens2 dev 1982
PVPArena dev 328

Typing /pa stats damage after players have played in some arenas shows players who aren't actually participating in any of the arenas. Citizen NPCs are showing up in the output.

link

Would it be possible to filter out players who contain the meta NPC flag or only actually register participating players? For reference, I keep the global config.yml stat setting disabled - stats: false.

Could not pass event InventoryClickEvent to pvparena

PVPArena dev 341
Modules dev 213

[19:43:10] [Server thread/ERROR]: Could not pass event InventoryClickEvent to pvparena v1.15.0-SNAPSHOT-b341
java.lang.NullPointerException: null
	at net.slipcor.pvparena.goals.GoalInfect.checkInventory(GoalInfect.java:201) ~[?:?]
	at net.slipcor.pvparena.loadables.ArenaGoalManager.checkInventory(ArenaGoalManager.java:131) ~[?:?]
	at net.slipcor.pvparena.listeners.InventoryListener.onInventoryClick(InventoryListener.java:58) ~[?:?]
	at com.destroystokyo.paper.event.executor.asm.generated.GeneratedEventExecutor1053.execute(Unknown Source) ~[?:?]
	at org.bukkit.plugin.EventExecutor.lambda$create$1(EventExecutor.java:69) ~[patched_1.16.1.jar:git-Tuinity-"014232b"]
	at co.aikar.timings.TimedEventExecutor.execute(TimedEventExecutor.java:76) ~[patched_1.16.1.jar:git-Tuinity-"014232b"]
	at org.bukkit.plugin.RegisteredListener.callEvent(RegisteredListener.java:70) ~[patched_1.16.1.jar:git-Tuinity-"014232b"]
	at org.bukkit.plugin.SimplePluginManager.callEvent(SimplePluginManager.java:607) ~[patched_1.16.1.jar:git-Tuinity-"014232b"]
	at net.minecraft.server.v1_16_R1.PlayerConnection.a(PlayerConnection.java:2434) ~[patched_1.16.1.jar:git-Tuinity-"014232b"]
	at net.minecraft.server.v1_16_R1.PacketPlayInWindowClick.a(SourceFile:32) ~[patched_1.16.1.jar:git-Tuinity-"014232b"]
	at net.minecraft.server.v1_16_R1.PacketPlayInWindowClick.a(SourceFile:10) ~[patched_1.16.1.jar:git-Tuinity-"014232b"]
	at net.minecraft.server.v1_16_R1.PlayerConnectionUtils.lambda$ensureMainThread$1(PlayerConnectionUtils.java:43) ~[patched_1.16.1.jar:git-Tuinity-"014232b"]
	at net.minecraft.server.v1_16_R1.TickTask.run(SourceFile:18) ~[patched_1.16.1.jar:git-Tuinity-"014232b"]
	at net.minecraft.server.v1_16_R1.IAsyncTaskHandler.executeTask(IAsyncTaskHandler.java:136) ~[patched_1.16.1.jar:git-Tuinity-"014232b"]
	at net.minecraft.server.v1_16_R1.IAsyncTaskHandlerReentrant.executeTask(SourceFile:23) ~[patched_1.16.1.jar:git-Tuinity-"014232b"]
	at net.minecraft.server.v1_16_R1.IAsyncTaskHandler.executeNext(IAsyncTaskHandler.java:109) ~[patched_1.16.1.jar:git-Tuinity-"014232b"]
	at net.minecraft.server.v1_16_R1.MinecraftServer.aZ(MinecraftServer.java:1191) ~[patched_1.16.1.jar:git-Tuinity-"014232b"]
	at net.minecraft.server.v1_16_R1.MinecraftServer.executeNext(MinecraftServer.java:1184) ~[patched_1.16.1.jar:git-Tuinity-"014232b"]
	at net.minecraft.server.v1_16_R1.IAsyncTaskHandler.awaitTasks(IAsyncTaskHandler.java:119) ~[patched_1.16.1.jar:git-Tuinity-"014232b"]
	at net.minecraft.server.v1_16_R1.MinecraftServer.sleepForTick(MinecraftServer.java:1160) ~[patched_1.16.1.jar:git-Tuinity-"014232b"]
	at net.minecraft.server.v1_16_R1.MinecraftServer.v(MinecraftServer.java:1004) ~[patched_1.16.1.jar:git-Tuinity-"014232b"]
	at net.minecraft.server.v1_16_R1.MinecraftServer.lambda$a$0(MinecraftServer.java:177) ~[patched_1.16.1.jar:git-Tuinity-"014232b"]
	at java.lang.Thread.run(Thread.java:832) [?:?]

Death screen shows up on final death, bringing you to spectate location.

PVPArena dev 316 (https://ci.craftyn.com/view/Spigot%20PVP%20Arena/)
Modules as of dev 198
Paper dev 155 (Spigot 1.15.2)

Arena Config
https://paste.ubuntu.com/p/4MKwG5PCJh/

On your final death that teleports you to the spectate lounge, the death respawn screen appears. Clicking the respawn button doesn't do anything, the screen just goes away and you are still in the spectate lounge.

@Eredrim Would it be possible to not have the death screen appear on last life death to spectate teleport? Normal deaths inside the arena properly do not show the death screen.

FlySpectate not allowing flight

Paper version git-Paper-350 (MC: 1.15.2) (Implementing API version 1.15.2-R0.1-SNAPSHOT)
PVP version - 1.15.0-SNAPSHOT-b336
FlySpectate - 1.15.0-SNAPSHOT

As a default player or as admin with full permissions, when accessing spectate through /pa [arena] spectate, the hotbar changes to creative, you are invisible to players in the arena, but unable to fly; double tapping space has no effect.

Expand joinInBattle settings to only allow players to rejoin the same team if previously played.

I use the joinInBattle: true setting for a few of my arenas. I would like to continue using this setting and let players join if they missed the initial queue, however it is being abused to switch teams in the middle or end of the game to stack to the winning side for rewards.

Would it be possible to allow for new people to join the arena and expand the logic of rejoining to the same team they were playing previously?

maxhealth arena config setting damaging players on arena join

The maxhealth arena config setting seems to have strange results. Players' max health is correctly set, but any value below 20 will also damage players on arena join. Even worse, it seems that the lower the number, the more damage they take. A value of 10 or below will kill players instantly on join, and it's impossible to click respawn. The only real way out is to go back to the title screen or close the game.

It's important to note that the first player that joins the arena doesn't take any damage. Only every player that joins after them.

(Using build 316)

IllegalArgumentException: Cannot set to an empty path

PVPArena dev 328

Noticed this error in my logs. Should the exception be caught and outputting a nicer warning in-game?

[11:14:38] [Server thread/INFO]: player issued server command: /pa ctf8 flag
[11:14:40] [Server thread/INFO]: player issued server command: /pa ctf8 flags
[11:14:44] [Server thread/ERROR]: Could not pass event PlayerInteractEvent to pvparena v1.15.0-SNAPSHOT-b328
java.lang.IllegalArgumentException: Cannot set to an empty path
	at org.apache.commons.lang.Validate.notEmpty(Validate.java:321) ~[patched_1.15.2.jar:git-Tuinity-"188307c"]
	at org.bukkit.configuration.MemorySection.set(MemorySection.java:188) ~[patched_1.15.2.jar:git-Tuinity-"188307c"]
	at org.bukkit.configuration.MemorySection.set(MemorySection.java:222) ~[patched_1.15.2.jar:git-Tuinity-"188307c"]
	at net.slipcor.pvparena.core.Config.setManually(Config.java:850) ~[?:?]
	at net.slipcor.pvparena.managers.SpawnManager.setBlock(SpawnManager.java:769) ~[?:?]
	at net.slipcor.pvparena.goals.GoalFlags.commitSetFlag(GoalFlags.java:645) ~[?:?]
	at net.slipcor.pvparena.classes.PACheck.handleSetFlag(PACheck.java:688) ~[?:?]
	at net.slipcor.pvparena.listeners.PlayerListener.onPlayerInteract(PlayerListener.java:491) ~[?:?]
	at com.destroystokyo.paper.event.executor.asm.generated.GeneratedEventExecutor1067.execute(Unknown Source) ~[?:?]
	at org.bukkit.plugin.EventExecutor.lambda$create$1(EventExecutor.java:69) ~[patched_1.15.2.jar:git-Tuinity-"188307c"]
	at co.aikar.timings.TimedEventExecutor.execute(TimedEventExecutor.java:76) ~[patched_1.15.2.jar:git-Tuinity-"188307c"]
	at org.bukkit.plugin.RegisteredListener.callEvent(RegisteredListener.java:70) ~[patched_1.15.2.jar:git-Tuinity-"188307c"]
	at org.bukkit.plugin.SimplePluginManager.callEvent(SimplePluginManager.java:607) ~[patched_1.15.2.jar:git-Tuinity-"188307c"]
	at org.bukkit.craftbukkit.v1_15_R1.event.CraftEventFactory.callPlayerInteractEvent(CraftEventFactory.java:471) ~[patched_1.15.2.jar:git-Tuinity-"188307c"]
	at org.bukkit.craftbukkit.v1_15_R1.event.CraftEventFactory.callPlayerInteractEvent(CraftEventFactory.java:438) ~[patched_1.15.2.jar:git-Tuinity-"188307c"]
	at net.minecraft.server.v1_15_R1.PlayerInteractManager.a(PlayerInteractManager.java:164) ~[patched_1.15.2.jar:git-Tuinity-"188307c"]
	at net.minecraft.server.v1_15_R1.PlayerConnection.a(PlayerConnection.java:1505) ~[patched_1.15.2.jar:git-Tuinity-"188307c"]
	at xuan.cat.XuanCatAPI.code.b.c.a.g.a(Unknown Source) ~[?:?]
	at xuan.cat.XuanCatAPI.code.b.c.a.g.a(Unknown Source) ~[?:?]
	at xuan.cat.XuanCatAPI.code.b.c.a.g.a(Unknown Source) ~[?:?]
	at net.minecraft.server.v1_15_R1.PacketPlayInBlockDig.a(SourceFile:40) ~[patched_1.15.2.jar:git-Tuinity-"188307c"]
	at net.minecraft.server.v1_15_R1.PacketPlayInBlockDig.a(SourceFile:10) ~[patched_1.15.2.jar:git-Tuinity-"188307c"]
	at net.minecraft.server.v1_15_R1.PlayerConnectionUtils.lambda$ensureMainThread$0(PlayerConnectionUtils.java:43) ~[patched_1.15.2.jar:git-Tuinity-"188307c"]
	at net.minecraft.server.v1_15_R1.TickTask.run(SourceFile:18) ~[patched_1.15.2.jar:git-Tuinity-"188307c"]
	at net.minecraft.server.v1_15_R1.IAsyncTaskHandler.executeTask(IAsyncTaskHandler.java:136) ~[patched_1.15.2.jar:git-Tuinity-"188307c"]
	at net.minecraft.server.v1_15_R1.IAsyncTaskHandlerReentrant.executeTask(SourceFile:23) ~[patched_1.15.2.jar:git-Tuinity-"188307c"]
	at net.minecraft.server.v1_15_R1.IAsyncTaskHandler.executeNext(IAsyncTaskHandler.java:109) ~[patched_1.15.2.jar:git-Tuinity-"188307c"]
	at net.minecraft.server.v1_15_R1.MinecraftServer.ba(MinecraftServer.java:1161) ~[patched_1.15.2.jar:git-Tuinity-"188307c"]
	at net.minecraft.server.v1_15_R1.MinecraftServer.executeNext(MinecraftServer.java:1154) ~[patched_1.15.2.jar:git-Tuinity-"188307c"]
	at net.minecraft.server.v1_15_R1.IAsyncTaskHandler.awaitTasks(IAsyncTaskHandler.java:119) ~[patched_1.15.2.jar:git-Tuinity-"188307c"]
	at net.minecraft.server.v1_15_R1.MinecraftServer.sleepForTick(MinecraftServer.java:1130) ~[patched_1.15.2.jar:git-Tuinity-"188307c"]
	at net.minecraft.server.v1_15_R1.MinecraftServer.run(MinecraftServer.java:973) ~[patched_1.15.2.jar:git-Tuinity-"188307c"]
	at java.lang.Thread.run(Thread.java:832) [?:?]

No Damage with Bow and Trident (Ranged) when player.collision:false

Greetings,

It seems I am unable to damage the enemy team with a bow or Trident when thrown. There are no issues with melee or when not actively in an area.

I have removed any other software that could be conflicting (not a normal server using vanilla damage etc) and I am able to replicate the issue.
I have added below PA/Server version, arena and spigot config as well as a screenshot of plugins that were active within testing time.

Spigot: This server is running CraftBukkit version git-Spigot-1a3504a-dfa7583 (MC: 1.13.2) (Implementing API version 1.13.2-R0.1-SNAPSHOT) (FINAL BUILD)
PA: v1.13.9.301
PA Config: https://pastebin.com/2sCUtqu6
Plugins: https://i.gyazo.com/9b48bf52fbde1a20af3d53037235b76b.png
Example: https://i.gyazo.com/e3c910f23f0cb63f4fcc182a514ca7a1.gif

Seems that having player.collision:false causes this issue (tested it before submit), ill keep it here incase you can fix it.

Adding space in inventory not possible

I was wondering if you could add space between your items in your inventory, such as having all your arrows be on one side separately from your other weapons.

Squad Throwing Error

Having the Squads enhancement enabled in an arena throws this error on startup:

[17:55:21] [Server thread/INFO]: [PVP Arena] Enabling pvparena v1.14.1-SNAPSHOT-b318 [17:55:21] [Server thread/INFO]: [PVP Arena] debugging: off [17:55:21] [Server thread/WARN]: java.lang.NullPointerException [17:55:21] [Server thread/WARN]: at net.slipcor.pvparena.modules.squads.Squads.configParse(Squads.java:50) [17:55:21] [Server thread/WARN]: at net.slipcor.pvparena.loadables.ArenaModuleManager.configParse(ArenaModuleManager.java:123) [17:55:21] [Server thread/WARN]: at net.slipcor.pvparena.managers.ConfigurationManager.configParse(ConfigurationManager.java:298) [17:55:21] [Server thread/WARN]: at net.slipcor.pvparena.arena.Arena.<init>(Arena.java:115) [17:55:21] [Server thread/WARN]: at net.slipcor.pvparena.managers.ArenaManager.load_arenas(ArenaManager.java:299) [17:55:21] [Server thread/WARN]: at net.slipcor.pvparena.PVPArena.onEnable(PVPArena.java:501) [17:55:21] [Server thread/WARN]: at org.bukkit.plugin.java.JavaPlugin.setEnabled(JavaPlugin.java:263) [17:55:21] [Server thread/WARN]: at org.bukkit.plugin.java.JavaPluginLoader.enablePlugin(JavaPluginLoader.java:337) [17:55:21] [Server thread/WARN]: at org.bukkit.plugin.SimplePluginManager.enablePlugin(SimplePluginManager.java:483) [17:55:21] [Server thread/WARN]: at org.bukkit.craftbukkit.v1_15_R1.CraftServer.enablePlugin(CraftServer.java:470) [17:55:21] [Server thread/WARN]: at org.bukkit.craftbukkit.v1_15_R1.CraftServer.enablePlugins(CraftServer.java:384) [17:55:21] [Server thread/WARN]: at net.minecraft.server.v1_15_R1.MinecraftServer.a(MinecraftServer.java:487) [17:55:21] [Server thread/WARN]: at net.minecraft.server.v1_15_R1.DedicatedServer.init(DedicatedServer.java:298) [17:55:21] [Server thread/WARN]: at net.minecraft.server.v1_15_R1.MinecraftServer.run(MinecraftServer.java:890) [17:55:21] [Server thread/WARN]: at java.base/java.lang.Thread.run(Thread.java:834)

The arena is then disabled.

Escaping an arena

When i join an arena with no one else there, i get trapped, and even if I tp myself out, I can't break/place blocks. How do I escape the arena after joining when there is nobody else to start the game?

itemsonkill config setting not using new serializer.

Compiled PVPArena as of commit 3ef4b52

itemsonkill config setting still seems to use the full itemstack output, not your new serializer.

Tested with /pa test set itemsonkill hand while holding an arrow (which didn't seem to set anything) and /pa test set itemsonkill inventory which set the arrow with the full inventory itemstack.

Infected team set does not set scoreboard color.

PVPArena dev 341
Modules dev 213

I created a concept BlockHunt minigame using the INFECT goal. Infected team color does not seem to set the infected player's color properly on the scoreboard.

I tried both

teams:
  free: LIGHT_BLUE
  infected: RED

&

teams:
  free: LIGHT_BLUE
  '%infected%': RED

Regardless of what is set, the infected team is colored white.

Config Example
https://paste.ubuntu.com/p/XbRyN3NPxG/

Edit: Specifically the scoreboard on the right here. Though the screenshot is of a player who was visually stuck dying.
link

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.