erhosen-libs / pydjantic Goto Github PK

We should be able to set conn_max_age & ssl_require in BaseDBConfig.

Right now we're testing Pydantic's serialization only with no Pydjantic code.
It should be DatabaseConfig(BaseDBConfig).

Hello, from what I can see, types are implemented, so, would it be possible to add the py.typed file for pylance, mypy and other type checker to work with this lib ?

Consider the following settings.py:

import os
from pydantic import BaseSettings, SecretStr
from pydjantic import to_django

class Settings(BaseSettings):
    MY_SECRET: SecretStr

# Define a secret in the env so that Pydantic validation passes
os.environ["MY_SECRET"] = "i am a secret"

settings = Settings()
print(settings.dict())   # ✅ Will NOT print the actual secret value, which is good

to_django(settings)

print(MY_SECRET)         # ❌ Prints "**********", which is incorrect

Here is the output of running the above snippet:

{'MY_SECRET': SecretStr('**********')}
**********

The second print should have yielded i am a secret instead. Otherwise there is no way of using the secret value in the rendered settings.

Even when running tests:

tests/test_to_django.py::test_to_django_settings
  D:\NVIDIA\third-party\_python\pydjantic\.venv\Lib\site-packages\pydantic\main.py:308: UserWarning: Pydantic serializer warnings:
    Expected `multi-host-url` but got `dict` - serialized value may not be as expected
    return self.__pydantic_serializer__.to_python(

tests/test_db_config.py::test_dsn_and_exact_config
  D:\NVIDIA\third-party\_python\pydjantic\.venv\Lib\site-packages\pydantic\main.py:308: UserWarning: Pydantic serializer warnings:
    Expected `str` but got `dict` - serialized value may not be as expected
    return self.__pydantic_serializer__.to_python(

Seems to come from database configuration, e.g. (in test_dsn_and_exact_config):

class DatabaseConfig(BaseDBConfig):
    # declared as str, but actually deserialized as dict (Django database configuration)❓
    default: str = Field(default="postgres://user:password@hostname:5432/dbname")
    replica: PostgresDB = PostgresDB()

Applications still run, however:

• Users (like myself) might think that there is something wrong with their Django settings
• Application will fail to start under -Werror python interpreter flag

Would be great to be able to bootstrap a .env based of the defined structure. Ideally interactive and non-interactive.

Hi, would you mind changing minimal Requires-Python >=3.8?

I receive the following failure output:

SECRET_KEY
  field required (type=value_error.missing)

The SECRET_KET config looks as follows:

SECRET_KEY: str = Field(default=Undefined, env='DJANGO_SECRET_KEY')

Given I'm using environment variables to pass in the configuration I can not discern the issue from looking at the output, e.g. I don't know I have to provide a value in DJANGO_SECRET_KEY until looking into the code.

Would it be possible to provide more details, possibly the entire config for this field? I see there are title and description available, which could be helpful too:

SECRET_KEY: str = Field(default=Undefined, env='DJANGO_SECRET_KEY', title="Secret key", description="lorem ipsum...")

Possible solution:

SECRET_KEY
  Error: field required (type=value_error.missing)
  Title: Secret Key
  Description: Lorem ipsum dolor sit amet, consectetur adipiscing elit. Sed suscipit, orci
      nec facilisis tristique, nibh leo pretium mi, sed consequat nibh magna sit amet elit. Maecenas
      tempus porta tellus eu feugiat. Phasellus eget vehicula libero. Donec eget augue
      pellentesque, condimentum elit sed, lobortis est. Fusce eu risus placerat, mollis dolor at,
      convallis mi.
  Env: DJANGO_SECRET_KEY