Giter VIP home page Giter VIP logo

Comments (6)

peonor avatar peonor commented on September 25, 2024

The same problem when "OPT" occurs earlier in the file. Problematic, since earlier usage has been to include "OPT" also on parameters in main parameter section. At worst, should be ignored if occurring before Substructure section. At best, accept optimization also of main section parameters!

from q2mm.

ericchansen avatar ericchansen commented on September 25, 2024

What column from the van der Waals parameters are you looking to optimize? Radius, Eps, Offset, Charge or all of the above?

from q2mm.

peonor avatar peonor commented on September 25, 2024

Only radius and eps. The offset has to be a decision, not a parameterization (only rarely used, basically only for hydrogen in some environments). The charges are only there as a 20 year old remnant, it’s not actually used, but overwritten by the value in atom.typ.

/Per-Ola

From: Eric Hansen [mailto:[email protected]]
Sent: den 22 september 2015 17:01
To: ericchansen/q2mm
Cc: Norrby, Per-Ola
Subject: Re: [q2mm] OPT in vdW (#6)

What column from the van der Waals parameters are you looking to optimize? Radius, Eps, Offset, Charge or all of the above?


Reply to this email directly or view it on GitHubhttps://github.com//issues/6#issuecomment-142314649.


Confidentiality Notice: This message is private and may contain confidential and proprietary information. If you have received this message in error, please notify us and remove it from your system and note that you must not copy, distribute or take any action in reliance on it. Any unauthorized use or disclosure of the contents of this message is not permitted and may be unlawful.

from q2mm.

ericchansen avatar ericchansen commented on September 25, 2024

This issue should all be taken care of. Let me know if I introduced any new bugs. I had to change a lot of how I read and write force field files.

from q2mm.

peonor avatar peonor commented on September 25, 2024

Hi Eric,

I’ll be checking during the day.

There are a couple of things I’d like to discuss, I won’t have time to go through the code in detail to get all the answers.

· The parameter list no longer contains the differentiation step, how do you determine it?

· By default, you select all torsional parameters. In most cases, changing all will result in serious overfitting, we can only do this if we have good sampling over the entire 360 range. Mostly, we’d select one parameter only, v2 or v3 depending on hybridization. The way I usually do it is that I set most torsional parameters to zero in the FF, set a non-zero value for the ones I want to parameterize, and only pick out those for optimization. And torsions should always be allowed to become negative if the data requires it.

There are a few more things, but I’ll try to work my way through an example first.

I’ve managed to run parameters.py, calculate.py, and loop.py with an input file very similar to the one you provided. I’m right now stuck at compare.py, could be because of the data I’m using, only torsions for now. I found out that if I run ONLY

$SCHRODINGER/run calculate.py –p –jt D1.mae –f mm3.fld

I get an error because the com file does not contain an ELST command, and thus no mmo file is generated. I assume I can fix that by including more data types, will let you know what happens. BTW, the ‘-f mm3.fld’ feels unnecessary, can’t that be default? Crashing without it…

/Per-Ola

From: Eric Hansen [mailto:[email protected]]
Sent: den 22 september 2015 22:17
To: ericchansen/q2mm
Cc: Norrby, Per-Ola
Subject: Re: [q2mm] OPT in vdW (#6)

This issue should all be taken care of. Let me know if I introduced any new bugs. I had to change a lot of how I read and write force field files.


Reply to this email directly or view it on GitHubhttps://github.com//issues/6#issuecomment-142406320.


Confidentiality Notice: This message is private and may contain confidential and proprietary information. If you have received this message in error, please notify us and remove it from your system and note that you must not copy, distribute or take any action in reliance on it. Any unauthorized use or disclosure of the contents of this message is not permitted and may be unlawful.

from q2mm.

ericchansen avatar ericchansen commented on September 25, 2024

The parameter list no longer contains the differentiation step, how do you determine it?

The module constants contains the default step sizes, and you can change them in there. You can also have them use a relative step size rather than an absolute step size by entering the percentage in quotes. It's explained more in the doc string. opt handles any issues where a parameter tries to reach a value it's not allowed to.

By default, you select all torsional parameters. In most cases, changing all will result in serious overfitting, we can only do this if we have good sampling over the entire 360 range. Mostly, we’d select one parameter only, v2 or v3 depending on hybridization. The way I usually do it is that I set most torsional parameters to zero in the FF, set a non-zero value for the ones I want to parameterize, and only pick out those for optimization. And torsions should always be allowed to become negative if the data requires it.

Making a parameter file is simple, and then you can select whichever parameters you want. See the README for more on making a parameter file. Doing that via the command line would just get long and messy, which is why I limit command line parameter control to selecting entire parameter types.

I admit that it would be nice if the parameters module gave torsional parameters and charges the "neg" keyword by default. I think writing that in should only take a minute, so I'll get to it.

I get an error because the com file does not contain an ELST command, and thus no mmo file is generated. I assume I can fix that by including more data types, will let you know what happens. BTW, the ‘-f mm3.fld’ feels unnecessary, can’t that be default? Crashing without it…

I found out yesterday that when I reworked writing the .com files (~ 1 week ago), that I messed up all the Jaguar structural data types (ja, jb, jt). I think I fixed it yesterday. Can you update your repository and try this again?

For me, I don't keep my Q2MM code in the same directory as my data, so having to specify where the force field is makes sense. I think what I could do is have it try a few things before erroring if you don't include -f mm3.fld. For example, if -d somedir is provided, it could by default pick up somedir/mm3.fld, or if -d isn't provided, then it would check the current directory for mm3.fld.

from q2mm.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.