ericgio / weekday-golf Goto Github PK

• allowed shenanigans
• shenanigans for skins purposes?
• hole 9
• incomplete rounds

Zamore (and maybe raylene) had rounds that were not complete. Have the code be able to handle an incomplete round.

Right now the data entry process involves:

1. Makinde entering scores in the UDisc app
2. Makinde posting a screenshot of the round to the thread
3. Someone manually entering the data from the screenshot to the google spreadsheet

Would be nice to cut out a bunch of those steps and just be able to enter data directly in the app.

AFAICT, the dates stored for rounds are meant to represent a date, not a specific time. Well, I guess they are the time we started, but that info is only stored as a date on the site. If the plan is to only keep/show the date, I think it's best practice to store that as a string '2020-10-11'. This allows one to not worry about timezone and store something that more closely represents the intended purpose.

Right now we’re on the free tier of Heroku. This means we have a long startup time when the dyno goes to sleep. We also don’t get SSL.

The free tier on Vercel is well integrated with nextJS, so not only will the site always be on, they will store the pages in their CDN so its always fast. They also do free SSL carts. We can also have free review apps to run the app on different PR’s/branches. It’s also super easy to set up (I’d say much easier than Heroku. I set it up here: https://weekday-golf.vercel.app/rounds

The downside of Vercel is that only one person can manage the project for free. So we couldn’t all have access to the hosting like we do on Heroku. Since There’s rarely a need to tweak settings there, I think this is fine.

This could show the rounds they’ve played in, the players stats (maybe with #2 ), other things about the player themselves.

I think CSS modules are the default, built in way for doing component level CSS in nextJS. https://nextjs.org/docs/basic-features/built-in-css-support#adding-component-level-css Prob not a huge difference either way. Upside of switching is to be more in line with the default/require fewer external packages, and also avoid conflicting class names (which is a tiny chance of happening at this scale). @zeit/next-sass Also doesn’t seem to be updated anymore.

Also not sure if it matter, but CSS is currently flaky for me in dev. Sometimes it loads, other times not.

https://flaviocopes.com/nextjs-analyze-app-bundle/

There are several ways to style components; we currently use CSS modules, which have built-in support in NextJS. Documenting a few others in case we want to explore a different approach at some point.

• CSS Modules (current)
• JSS
• styled-components
• Emotion

I would say this is low-pri and mainly worth pursuing for personal interest.

Probably all the stuff from the "Stats By Player" table:

• Avg. Score
• Rounds Played
• Rounds Won
• Best Hole
• Worst Hole

bar graph of score distribution

This is for the recent stats summary.

We go to a playoff hole if there's a tie on the last hole (and maybe if the round is tied?) but the results aren't reflected in the data. There are also other tiebreaker methods that we haven't utilized, like looking at the last N holes. That kind of approach could be used going forward to break ties, though it's not nearly as fun as a playoff.

per-player line graph of scores mapped against date played

Right now each page has it’s own custom layout (usually a stack of tables/graphs). This layout requires a lot of thought to add something above the fold as it quickly displaces anything else, and also requires custom jobs to do anything beyond just stacking things on top of one another.

The proposal here to to move towards a setup where info is displayed in cards that can be tiles across the page, each containing some information/visualization. Then we can prioritize the cards after the fact, while people add cards as they see fit day to day.

[note, I don’t have any short terms plans here, just tracking the idea]

Next has pretty good built in support for typescript. It’s roughly as simple as making a file end with .tx instead of .js. Since we pass around so many arrays and dictionaries, it’ll be useful to have the compiler make sure the right fields are present.

https://nextjs.org/docs/basic-features/typescript

This way we can add the round that happened with Gio, Makinde, and Jess. This is probably a pretty extensive undertaking since it requires us to support different par scores and other things that are hard coded.

Heyo. Not sure which frameworks or anything. I guess the ideal would be something that is one codebase, but provides android and iOS? Or maybe just use ReactNative and just do iOS.