erickmorales3 / action-logging Goto Github PK

Just adding compile "org.grails.plugins:action-logging:1.1.1" in build.gradle is triggering errors. Any suggestion?

Hi,

I think it would be nice to update the README.md and tell developers that the ActionLoggingEvent is stored in the session. This approach won't work properly in a load balancing scenario without sticky sessions or session clustering. IMO mentioning that it's good enough to avoid a potential refactor

I noticed that you store the ActionLoggingEvent.groovy instance in the session in order to retrieve in the afterView and update endTime and totalTime.

I don't know if this could be a potential issue in memory at Tomcat level or if you store the session in a database such as MySQL (https://grails.org/plugin/database-session) or Redis (https://grails.org/plugin/redis-database-session) <- this one serializes the whole Session object in a byte array or JSON.

What do you think about storing the ActionLoggingEvent id in the session and then retrieve the object from the database in the afterView?

Hi @erickmorales3

I'm opening a few issues, hope that's ok.

https://github.com/erickmorales3/action-logging/blob/master/grails-app/conf/ActionLoggingFilters.groovy#L50

 if (!actionName) {
                        actionNameValue = "index"
                    }

Perhaps reading the static defaultAction first and then fallback to index would be better

I'm aware that a common use case would be storing the userId from Spring Security.

It would be nice to allow storing other fields from the authentication (such as email or account number) or also if they don't use Spring Security, allow them to plug their own logic to determine this field. It could be a cookie, session variable (in-house security framework), Apache Shiro.