erickuck / conductorglidedemo Goto Github PK

Hi, I'm a bit late but thanks for the example. Unfortunately it works only if you have exactly one Controller. Because the RequestManager used is the one for Activity. Glide uses just one instance per Activity / Fragment. If all controllers use one shared RequestManager then the first Controller who gets destroyed unregisters the the sahared RequestManager. The next destroyed Controller also attempts to unregister it and GlideException is thrown: "Cannot unregister not yet registered manager". Even if we swallow the exception there's no RequestManager left registered for the remaining Controllers. In other words every Controller needs to have own RequestManager for its own scope. So I tried to fix that:

https://gist.github.com/sevar83/7b5e151233481b629e3d1fb1be7327dc

Could you please take a look at my implementation? Specifically - the GlideSupport.collectRequestManagers() function. It simply traverses the Controller tree to see which controllers in the hierarchy support Glide. I'm not sure if this traversing is correct.