Giter VIP home page Giter VIP logo

farm-pvp's Introduction

Farm PvP

Farm PvP is a World of Warcraft addon for tracking how much honor and conquest are needed for a full set of seasonal PvP gear.

It is meant for the player to easily get an overview of what's required to be competitive in terms of gear. Currently, it shows three points of interest. First, the total amount of conquest for a full set of PvP gear. Secondly, the amount of total honor required to upgrade currently equipped gear based on the player's best rank during the week. Thirdly, the total amount of honor to upgrade to the highest effective rank for PvP (currently Duelist), also based on currently equipped items.

Commands

/fp or /farmpvp to get a list of commands. These are the currently supported commands:

  • /fp show to display the addon
  • /fp hide to hide it
  • /fp lock to unlock/hide the frame
  • /fp calc or /fp calculate to manually calculate upgrade cost based on currently equipped PvP gear

Author

NotAnotherJD/erikbrgn/Lyci

farm-pvp's People

Contributors

erikbrgn avatar

Watchers

 avatar

farm-pvp's Issues

Update cost on changed arena/rbg rating

Is your feature request related to a problem? Please describe.
We need an event listener for rating changed in arena and rated bg.

Describe the solution you'd like
Add an event listener.

GitHub workflow PR

It would be really useful with some GutHub workflows/actions. This issue could be for pull requests. Perhaps a lint check for committed changes

A compact frame option would be cool

Is your feature request related to a problem? Please describe.
Frame takes up too much space to have open at all times

Describe the solution you'd like

It would be cool to be able to make the frame smaller as an option, which would only show the numbers and perhaps rank icons. PU would know what they mean.

Tooltips

Is your feature request related to a problem? Please describe.
It would be really nice with some tooltips to get more information about what each "section" means.

Describe the solution you'd like
A question mark with information placed somewhere in line with the section. Or tooltip on the rank icon?

Conquest section doesn't subtract amount of conquest the player has

Describe the bug

The other two sections seem to subtract honor that the player has collected from the total shown. But this doesnt seem to be the case for conquest.

To Reproduce
Just look at the total conquest cost for missing pieces. When you earn conquest it doesnt change.

Expected behavior
Conquest earned by the player should be subtracted from the total conquest cost for missing pieces.

Only display addon for level 60s

Is your feature request related to a problem? Please describe.
No point in displaying costs and stuff if the character isn't 60.

Describe the solution you'd like
Hide the frame or show something to make it clear it's only relevant for level 60s.

Save position of the frame

Upon logging in the frame is always centered in the middle of the screen. We should save the position of the frame if the user moves it.

Show a "complete" section when done

Is your feature request related to a problem? Please describe.
No point in displaying an empty frame when all gear has been upgraded.

Describe the solution you'd like

A "complete" section

Close button

We need a way to close/hide the frame on the frame itself.

This can be achieved with a simple close button at the top right corner.

CLI commands

We need some CLI commands. Suggestion:

  • Show frame
  • Hide frame
  • Recalculate upgrade cost?
  • Lock frame
  • ...

Add options pane in Interface

It could be a good idea to have settings for this addon. A way to configure what the calculations should be based on. Right now, it's based on currently equipped gear, but should perhaps have an option for equipment sets, excluding certain equipment slots, etc.

However, this issue should only be to implement an Interface settings pane.

Addon doesn't work upon entering the world the 1st time

Describe the bug
Upon entering the world on any character for the first time, the addon doesn't display any information. It requires a reload.

To Reproduce
Steps to reproduce the behavior:

  1. Log in to any character
  2. Every section shows "-"
  3. /reload
  4. Now it works

Expected behavior
First time entering should display the correct information

Add Elite upgrade cost

Is your feature request related to a problem? Please describe.
Currently, the upgrade cost only covers Duelist rank at the highest. It could be useful for PvE purposes to display the last upgrade rank even if it has no use in PvP.

Describe the solution you'd like
Add upgrade cost for rank 9 (elite)

Restructure/refactor code

Code is in a bit of a mess at the moment. We should try split it up into pieces in separate scripts, especially the main script. Refactor frame, textures and strings into XML or at least its own script. Break apart frame:TotalUpgradeCost into smaller re-usable chunks. Perhaps introduce a script responsible for updating data.

Refactor method of getting PvP items.

At the moment, we do a pretty lazy check for "Unchained Gladiator's" to determine if the players has a current season PvP item or not. Perhaps it's better to just get the actual item IDs in a table and check against that.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.