esdmr / fish-completion Goto Github PK

They are currently only completed, which does not work, unlike aliases.

While calculating the replacement range, given the current token (which is currently coerced into one line), it assumes that the whole thing is in one line, which causes the range to have a negative column. Unfortunately, the output of completions are also split on that newline, so we cannot actually use the output. Again, this would be a non-issue with #209, but I have not figured it out yet. Regardless, to solve it without a parser, we can consider only the last line of the argument and modify that only, skipping the other lines in the completions.

Last time I tried it on GitHub Codespaces the completion part didn’t work (I think…).

Hi! I'm trying to use your extension with VSCode 1.81.1 running on mac os 13.4.1. No completions show up, and I'm getting the following errors in the output window:

Failure: Error: Command failed with exit code 1: script -e -q -c fish -iPC 'source $_FISH_COMPLETION_WORKER' /dev/null
script: illegal option -- e
usage: script [-adkpqr] [-t time] [file [command ...]]

With Mac OS, -e and -c are always implied, and the order of arguments is script <file> <command>..., so you need to do the following:

script -q /dev/null fish ...

For now, I've been able to make an ad-hoc fix by placing the following script python file into my path:

#! /usr/bin/env python

import os
import subprocess
import sys

if " ".join(sys.argv[1:]) == "-e -q -c fish -iPC 'source $_FISH_COMPLETION_WORKER' /dev/null":
    args = (
        "/usr/bin/script -q /dev/null fish -iPC source".split()
        + [os.environ['_FISH_COMPLETION_WORKER']]
    )
    exit(subprocess.run(args).returncode)
else:
    exit(subprocess.run(["/usr/bin/script"] + sys.argv[1:]).returncode)

Blocked by #209.

This issue lists Renovate updates and detected dependencies. Read the Dependency Dashboard docs to learn more.

Awaiting Schedule

These updates are awaiting their schedule. Click on a checkbox to get an update now.

• Update actions/cache digest to e12d46a
• Update actions/checkout digest to f43a0e5
• Update actions/setup-node digest to 1a4442c
• Update actions/cache action to v4
• Update actions/checkout action to v4
• Update actions/setup-node action to v4
• Lock file maintenance

Pending Status Checks

These updates await pending status checks. To force their creation now, click the checkbox below.

• Update dependency @types/node to v16.18.86
• Update dependency esbuild to v0.20.1
• Update pnpm to v8.15.4
• Update dependency @vscode/vsce to v2.24.0

Open

These updates have all been created already. Click a checkbox below to force a retry/rebase of any.

• Update dependency xo to v0.57.0
• Update dependency execa to v8
• Update dependency rollup to v4
• Update dependency rollup-plugin-esbuild to v6
• Click on this checkbox to rebase all open PRs at once

Detected dependencies

• Check this box to trigger a request for Renovate to run again on this repository

Currently, for completion, we send the whole script up to the cursor to fish, and for assistant we use a rather horrible RegExp to parse stuff, which has a ton of false negatives (and hopefully no false positives).

What if we were to create a parser for fish shell and use that to find functions and variables and only send the current command to fish to complete? It also fixes any problem with finding the selected argument and if and while statements, which are broken for some reason.

Edit: See https://github.com/esdmr/fish-parsing-parables

It should parse the output and show a progress notification.