always-catch: Consider two param `then` as the same as `catch` about eslint-plugin-promise HOT 9 CLOSED

@feross Yeah catch is maybe slightly better, because it will also catch programmer errors in the doSomething code, but it's certainly better than nothing. Maybe I can add an exception or something. Thanks for the idea. Will mull it over a bit.

from eslint-plugin-promise.

Yep, I understand. I just couldn't enable this rule without causing tons of standard users' code to fail. If there's a way to just check that there's any catch handler in then() or catch(), that would be a good candidate to enable for all standard users.

from eslint-plugin-promise.

I'll add a configurable exception "always-catch": [2, { allowThen: true }]. Think that might work?

from eslint-plugin-promise.

@xjamundx Yep, that'd work.

from eslint-plugin-promise.

K give me a week if it don't forget !

On Tue, Feb 23, 2016 at 1:07 PM, Feross Aboukhadijeh <
[email protected]> wrote:

@xjamundx https://github.com/xjamundx Yep, that'd work.

—
Reply to this email directly or view it on GitHub
#4 (comment)
.

from eslint-plugin-promise.

A lot of people are also saying if the promise is returned it doesn't need
to be caught. I may also add this exception

On Tue, Feb 23, 2016 at 1:07 PM, Jamund Ferguson [email protected] wrote:

K give me a week if it don't forget !

On Tue, Feb 23, 2016 at 1:07 PM, Feross Aboukhadijeh <
[email protected]> wrote:

@xjamundx https://github.com/xjamundx Yep, that'd work.

—
Reply to this email directly or view it on GitHub
#4 (comment)
.

from eslint-plugin-promise.

Started on this

from eslint-plugin-promise.

Closed by 41f1c02

from eslint-plugin-promise.

Nice, will try to release this in standard v7!

from eslint-plugin-promise.