ByteArrayCompressor.compress() allocates byte array that is too short if input buffer length > 2048 about kryo HOT 3 CLOSED

From [email protected] on April 22, 2010 13:04:52

Line 2 will return a buffer size of "bufferSize" bytes. The bufferSize value comes
from the Compressor constructor, which is 2048 if not otherwise specified. Please
specify a larger buffer size for your compressor.

Compressor does not currently support automatically growing the buffer size. Let me
know if this is necessary and I will reopen this issue. If this were to be
implemented, it would work just like ObjectBuffer.

Status: Invalid

from kryo.

From [email protected] on April 22, 2010 16:04:30

The difficulty is that my code doesn't constuct or invoke the compressor directly.
My code calls Kryo.writeClassAndObject(), which apparently constucts and invokes a
ByteArrayCompressor within this call using the default 'bufferSize' of 2048.

Making it so that the buffer can grow like ObjectBuffer might be ultimately the most
efficient option, I don't know how Kryo works well enough yet to say. But it seems
to me that since the problem with the above code is such a minor thing it would be
worth fixing this in the mean time.

Perhaps:

public void compress (ByteBuffer inputBuffer, Object object, ByteBuffer
outputBuffer) {
Context context = Kryo.getContext();
int inputLength = inputBuffer.remaining();
byte[] inputBytes = context.getBuffer(Math.max(bufferSize,inputLength)).array();
inputBuffer.get(inputBytes, 0, inputLength);
compress(inputBytes, inputLength, outputBuffer);
}

from kryo.

From [email protected] on April 23, 2010 11:57:22

Kryo will never use a compressor automatically, so someone has to be setting it up.

Ah, your proposed fix is a good improvement, thanks! In SVN r103.

Status: Fixed

from kryo.