esrever10 / remnote-plugin-roaming Goto Github PK

View Code? Open in Web Editor NEW

3.0 3.0 0.0 1.18 MB

Roaming in the knowledge.

License: MIT License

JavaScript 9.82% TypeScript 87.02% CSS 3.15%

remnote-plugin-roaming's People

Stargazers

Watchers

remnote-plugin-roaming's Issues

Calling rem.getAll every time user clicks the block/roam buttons

remnote-plugin-roaming/src/widgets/roaming_widget.tsx

Lines 168 to 169 in 7ccaeb8

 async function roaming() { 

 const allRems = await plugin.rem.getAll();

Calling rem.getAll every time user clicks the block/roam buttons might be slow for users with large KBs because it has to load all of the Rem in the user's knowledge base and serialize them and send to the plugin.

I think it's okay for now, but if users complain that it is slow, you could instead only set the total once when the widget first loads?

Plugin has started to render twice in sidebar

I just upgrade to Remnote 1.13.34 and the roaming plugin has started rendering twice in my sidebar.

Small bug with drawaCard function

remnote-plugin-roaming/src/widgets/roaming_widget.tsx

Lines 196 to 212 in 7ccaeb8

 const drawaCard = async () => { 

 var max = 50; 

 var rem = getRandomElement(allRems); 

 while (max > 0) { 

 console.log(`max: ${max}`); 

 const checklist = await check(rem); 

 console.log(checklist); 

 if (checklist.every((x) => x == false)) { 

 return rem; 

 } 

 setBlockSet(blockSet.add(rem._id)); 

 rem = getRandomElement(allRems); 

 max -= 1; 

 } 

 console.log('rem not found!'); 

 return rem; 

 };

If Rem is not found, it still returns the Rem, so it is possible to navigate to a Rem which fails the block check.

Reset button cut off

The left sidebar is at max width, but the reset button is still slightly cut off.

esrever10 / remnote-plugin-roaming Goto Github PK

remnote-plugin-roaming's People

Stargazers

Watchers

remnote-plugin-roaming's Issues

Calling rem.getAll every time user clicks the block/roam buttons

Plugin has started to render twice in sidebar

Small bug with drawaCard function

Reset button cut off

Recommend Projects

React

Vue.js

Typescript

TensorFlow

Django

Laravel

D3

Recommend Topics

javascript

web

server

Machine learning

Visualization

Game

Recommend Org

Facebook

Microsoft

Google

Alibaba

D3

Tencent

	async function roaming() {
	const allRems = await plugin.rem.getAll();

	const drawaCard = async () => {
	var max = 50;
	var rem = getRandomElement(allRems);
	while (max > 0) {
	console.log(`max: ${max}`);
	const checklist = await check(rem);
	console.log(checklist);
	if (checklist.every((x) => x == false)) {
	return rem;
	}
	setBlockSet(blockSet.add(rem._id));
	rem = getRandomElement(allRems);
	max -= 1;
	}
	console.log('rem not found!');
	return rem;
	};