esrf-bliss / lima-camera-andor3 Goto Github PK

Hello! There is a small typo here
https://github.com/esrf-bliss/Lima-camera-andor3/blob/master/src/Andor3Camera.cpp#L88
"TagetSensorTemperature" which means that the temperature_sp attribute is not implemented. Fixing that and all works well for my Andor Balor.
Best regards,
Paul

The enumerated trigger modes do not apply for the Andor Balor
https://github.com/esrf-bliss/Lima-camera-andor3/blob/master/include/Andor3Camera.h#L73

enum A3_TriggerMode { Internal = 0, ExternalLevelTransition = 1, ExternalStart = 2, ExternalExposure = 3, Software = 4, Advanced = 5, External = 6 };

These work for the Zyla (for example) but for the Balor the options in the SDK would be

enum A3_TriggerMode { Internal = 0, Software = 1, External = 2, ExternalStart = 3, ExternalExposure = 4 }

As it is, if one selects EXTERNAL_TRIGGER_MULTI in Lima for the Balor, the check here https://github.com/esrf-bliss/Lima-camera-andor3/blob/master/src/Andor3Camera.cpp#L1411 is failed since the SDK expects 2 not 6.