Installing Windows about chef-aws-inspector HOT 11 CLOSED

Windows Agent is working and I included test cases. I also added windows support to .kitchen.yml. I used the search feature instead of hard coding an AMI ID, to make it easier to work in different regions. I'm not that good with git so I hope the pull is correct.

from chef-aws-inspector.

Sorry for the late response I am on vacation this week. I will review the PR retroactively when I have some time.

from chef-aws-inspector.

Will work on this. No ETA yet, though. I'm not a Windows person and will take some time for me to test this. Any help is welcome !

from chef-aws-inspector.

There's a new WIP branch https://github.com/eternaltyro/chef-aws-inspector/tree/windows-agent

cc: @majormoses

from chef-aws-inspector.

Thanks. I played around with it some, broke the functions out into separate Linux and Windows cookbooks and put logic into the default recipe to call one or the other. The windows cookbook is pretty basic. I can fork the code if you like and share what I've done.

from chef-aws-inspector.

Actually it looks like you've already made a lot of progress. I'll clone it and give it a try.

from chef-aws-inspector.

you've already made a lot of progress.

I'll be surprised. But please, feel free to raise a pull-request

from chef-aws-inspector.

Working on it now. I had to make a few minor changes but it is looking good. Will submit a pull once I'm done testing.

from chef-aws-inspector.

Pull request: #7 fixes this issue.

from chef-aws-inspector.

Excellent. I didn’t bump the version so you’ll have to do that.

from chef-aws-inspector.

@chefbob Sure, will do.

from chef-aws-inspector.