eternaltyro / chef-aws-inspector Goto Github PK

even though there is a not_if for windows platform, it seems to still be failing at that stage.

Need to test for:

• installation and presence of awsagent binary
• removal and absence of awsagent binary
• PGP failures

I am not sure I understand why there is a requirement that these are normal attributes which persist chef client runs. I think during the guard it should be node as opposed to normal as it should resolve to whatever attribute precedence level is highest. This leave it to the user to decide whether they want to use normal, default, etc. Many AWS envs have ephemeral instances that come up and down on their own this makes it harder to use this cookbook.

Any chance of adding windows support to this cookbook?

I don't see centos 6.x in the readme file I was wondering if it would support it ?

An error is thrown when trying to use the cookbook with Chef-Client 13.8.5, "ERROR: Cannot find a resource for windows_package on redhat version 7.4". It does not seem to honor the only_if platform windows directive.

   107:  # Install for Windows
   108>> windows_package 'awsagent' do
   109:    source node[:inspector][:win_installer_url]
   110:    installer_type :custom
   111:    options '-silent'
   112:    only_if { platform?('windows') }
   113:  end

This does not happen with the latest 14.x version. I'll see if there is a way to fix this.

What is the upgrade path for AWS Inspector when using this cookbook? It appears it is being installed with the in-built upgrader disabled and does not have an obvious (to me) upgrade path available short of an uninstall/reinstall.