ethanaward / pianobar-skill Goto Github PK

Raised on behalf of @joshua-montgomery

Problem in object-deviation format

• The Pandora skill works after a couple of reboots, but crashes consistently after around 30 minutes.
• The skill will not come back without a reboot.
• Saying stop doesn't stop the Pianobar service

Start should:

1. Kill existing sessions
2. Start a new session

Stop should:

1. Kill existing sessions

Replicating the bug report

Unable to replicate the bug, Pandora services are no longer active in Australia

Pandora stations pretty much all have radio in it, so we can extract it our of the stations name so fuzzy matching will work with better probabilities.

But once, I had to kill the pianobar process.

Even though fuzzywuzzy is in the requirements.txt file, it wasn't properly installing when trying to install this skill. Also, python-Levenshtein needs to be added to requirements.txt. Once I installed these modules, the skill installed and worked fine.

Cannot log in to pandora, copy pasted the pasword into the pandora website so I know it's good and it works.

I get a "Pandora failed to load, please check your password...." message if I try to use the skill.

Found a small bug where if you have gotten to the last station synced from your Pandora account and then ask to go the the next station, the skill will fail.

Working on a PR for this, should just need to check if the next station is within the range of the index length and if it would go above that then reset the current station integer to 0 in order to restart the station loop.

When playing pandora, popping sounds sometime occur. This could be a sample rate issue or a hardware/driver issue.

requirements.sh breaks ability for Mycroft install by voice command.
specifically "pkcon install pianobar -y" fails due to pianobar not being installed by pkcon, whereas it can be installed by via apt-get

When you say Hey Mycroft play Pandora, it responds back with an error about my username and password are wrong, then is followed by an error in pianobar. This same issue happened with another one of my units and @Mn0491 found the issue that pianobar was looking for a folder, but it was turned into a directory.

Will send logs

Resume playback when recognition is falsely triggered (if no command given). Currently has to be resumed by user. Also ensure song title display is restored on resume.

This is what my Mark 1 says to me today. It was working fine before (well "fine" if you discount the constant freezes because pianobar/libao hates Pulseaudio :P) but I upgraded today and now I get this. Maybe the settings API has changed slightly in the latest mycroft core?

I checked, and my settings.json is still in place with email and password.

To recreate:
1: start mycroft
2: say "Hey Mycroft, play pandora
3: once radio starts, say "Hey Mycroft, skip song"

Expected result:
next song should start playing

Actual result:
pandora pauses and won't resume

Pianobar version:
2017.08.30

mycroft version:
18.2.5

Operating system:
Ubuntu 18.04(also happened on version 17)

Tried deleting the pianobarSkill folder, but Pandora won't reinstall.