ethanhou99 / ec601_api_project Goto Github PK

Hi Ethan, I read your code and I think you've done a great job.

• Your program is divided into three parts: tweepy, ffmpeg and google vision. The function of the API is declared clearly, which is friendly to the users.

• Your comments for the code are also readable. Those information are quite helpful for the users who do not familiar with the APIs used in our program.

• The tweeter_api program can conduct the whole function by presenting keys from google and tweet.

Here are some suggestions:

• I think it is a good idea to add some resources about environment settings and API install information.

• To make to output display the information more directly, I recommend you to try to use PIL image library to print text message on pictures.

Hi Ethan,

Seems like I am the second person providing code review.

First of all, your readme file was very helpful so that the documentation let me know where to look for files.

You code is well organized with additional readme files, but I noticed a lack of comments. Comments are helpful for you or for anyone who might want to adapt your code to their own application. For the Google Video Intelligence it is helpful to have comments even if you took the sample code directly from Google help files (including the link at the top would be nice too).

Your variable naming is very good and intuitive. Your code is also modular which makes it easy to read.

However instead of having the user edit your code, you can have the twitter handle passed as a command line argument. In addition the keys could be added to the environment so that you can push your code without worrying about accidentally posting your keys. On the user end this allows them to add all keys and credentials in the same place.

In addition, I suggest you use subprocess.call instead of os.system. It is totally fine to use os.system but I believe subprocess.call is meant to replace the older os.system.
https://docs.python.org/2/library/subprocess.html

Finally, I think your exception handling is comprehensive and deals with a lot of potential problems elegantly. It is clear that you thought about the potential problems a user could encounter. However I think there are a few cases such as when the twitter account has no media where it might get stuck telling the user to try again. Maybe you can specify that the account has no media and recommend the user tries another twitter handle.

I hope that provided you with helpful feedback on how to improve your project.

Great work!
Maha