Giter VIP home page Giter VIP logo

Comments (5)

wbnns avatar wbnns commented on July 24, 2024 1

Heya! Happy New Year! Just wanted to reopen this if that's ok!

Looks like there are around 50 PRs this has happened to.
https://github.com/ethereum-optimism/ethereum-optimism.github.io/pulls?q=is%3Apr+is%3Aclosed+label%3AStale

Cc: @stas

from ethereum-optimism.github.io.

tremarkley avatar tremarkley commented on July 24, 2024

Thanks for calling this out! To provide more details, if no updates have been made to a pull request it is marked stale after 7 days. Then after another 7 days, if no additional updates or comments are made on the pr, then it is auto-closed. Which means it is actually a 14 day window before the PR auto-closes. Additionally, an author can comment to remove the stale label.

Looking over the list of stale issues some of them are legitimate, but there were two recently that appear to be our fault and due to a slow review process for Base tokens. Currently, Base tokens have to go through a manually review process and we are working on moving this into an automated process. Additionally, on our end we make sure to review token list PR's at least once a week. I will bring this to the teams attention and make sure we do not drop the ball in the future and we remove the stale label for Base PR's where the staleness is due to slowness on our end.

For now, I am hesitant to increase the staleness as I think it is reasonable to expect an update within 14 days, and if that isn't happening due to slowness on our end, then we need to make an adjustment to our review process and not just extend the staleness period.

from ethereum-optimism.github.io.

wbnns avatar wbnns commented on July 24, 2024

Copy, thanks @tremarkley! Appreciate the review. Going to close this, then. 👍

from ethereum-optimism.github.io.

stas avatar stas commented on July 24, 2024

For now, I am hesitant to increase the staleness as I think it is reasonable to expect an update within 14 days, and if that isn't happening due to slowness on our end, then we need to make an adjustment to our review process and not just extend the staleness period.

Hey @tremarkley do you have any updates re this, doesn't look like the review process is efficient tbh. Related issue #385

from ethereum-optimism.github.io.

roninjin10 avatar roninjin10 commented on July 24, 2024

https://github.com/ethereum-optimism/ethereum-optimism.github.io/pull/611/files

from ethereum-optimism.github.io.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.