ethereum-optimism / ethereum-optimism.github.io Goto Github PK

Description

The balancer address is reflected as the new ERC-20 token, but there are multiple locations that still use the old BAL address.

Location

Additional context

This was a required item to launch Base on the product where I work. I've noticed that this ERC-20 address is not used as the official balancer token in other locations like Uniswap.

Evidence
To determine this, I initially sniffed out the address that is used by uniswap since I couldn't find the token addresses on the official Balancer reference guides.

I then reached out to confirm the ERC-20 address on Discord:

Describe the bug
Noticed a broken link in readme

To Reproduce
Click on link to the standard token factory

Expected behavior
Link should work

Screenshots
If applicable, add screenshots to help explain your problem.

System Specs:

• OS:
• Package Version (or commit hash):

Additional context
Add any other context about the problem here.

What is this value supposed to be, where is it used?

I think this should only result in an error if a user tries to withdraw, because they'd be attempting to withdraw from an address without a balance.

l2Receipt = await contracts.l2.bridge.connect(signer).withdraw(contracts.l2.token.address, amount, 0, '0x');

Hello everyone,

I wrote this into PR, but that PR is merged so I don't want to lose that.

I want to list token on BASE, but there is already token with same name and symbol. What should be the proper naming for data folder? Token symbol is "CHI".

I'm not 100% sure it's a bug, but didn't find another place to report it for help

Describe the bug
Last week, the token mpETH's PR was approved. I see the token ok the token list, and in the data folder. On https://app.optimism.io/bridge/deposit if I add the token as a custom token, it shows, but it isn't displayed on the main list on the website. I'm not sure if I have to wait longer, if there is an issue or if a step is missing.

To Reproduce
Steps to reproduce the behavior:

1. Go to https://app.optimism.io/bridge/deposit
2. Click on token selector
3. Token doesn't appear

==================================================================

1. Go to https://app.optimism.io/bridge/deposit
2. Click on token selector
3. Click on custom
4. Input 0x819845b60a192167ed1139040b4f8eca31834f27
5. Click on Add custom token
6. Check MetaPoolETH token is displayed

Expected behavior
I expect for the MetaPoolETH token to be displayed in the main list

System Specs:

• OS: Linux Zorin

Thanks in advance

Hi, I've just added PR #220 to include a token in the data folder. PR is under review but not sure how to grab attention of the maintainers on it. Hope writing here is the way.

the name of this repo is hard to search for. We should deprecate this repo and rename it superchain tokenlist

Is your feature request related to a problem? Please describe.
I'm kind of bummed out that Optimism and Base don't have better meme coins.

Describe the solution you'd like
Something funny and clever would be nice to interact with on the SuperChain.

Describe alternatives you've considered
I've considered spinning up my own memes but I'm not that funny.

Additional context
These videos might help

While submitting a PR for the SMT token support on BASE mainnet: #642
The validation of this PR failed with the description:

[ 'SMT' ]
 ELIFECYCLE  Command failed with exit code 1.
/home/runner/work/ethereum-optimism.github.io/ethereum-optimism.github.io/src/generate.ts:40
      const logoext = logofiles[0].endsWith('png') ? 'png' : 'svg'
                                   ^

TypeError: Cannot read properties of undefined (reading 'endsWith')
    at <anonymous> (/home/runner/work/ethereum-optimism.github.io/ethereum-optimism.github.io/src/generate.ts:40:36)
    at Array.map (<anonymous>)
    at generate (/home/runner/work/ethereum-optimism.github.io/ethereum-optimism.github.io/src/generate.ts:33:6)
    at validate (/home/runner/work/ethereum-optimism.github.io/ethereum-optimism.github.io/src/validate.ts:330:[16](https://github.com/ethereum-optimism/ethereum-optimism.github.io/actions/runs/7886893209/job/21778986640?pr=642#step:10:17))
    at processTicksAndRejections (node:internal/process/task_queues:96:5)
    at Command.<anonymous> (/home/runner/work/ethereum-optimism.github.io/ethereum-optimism.github.io/bin/cli.ts:25:[21](https://github.com/ethereum-optimism/ethereum-optimism.github.io/actions/runs/7886893209/job/21778986640?pr=642#step:10:22))

Is this validation error related to the provided .svg image or something else? And how can this problem be solved?

@roberto-bayardo , @roninjin10
Looking forward to your help 🙌

Hello, I have some questions about bridging on Base using the standard bridge. Is it possible to bridge an ethereum erc-20 to Base, where the new token on Base has a different name and ticker? I see the instructions say "Token name, symbol, and decimals matches on-chain data (auto-reject); If overrides are used (requires manual review)" which suggests this might be possible upon review.

I'm part of a renounced contract project which was taken over by the community 2 years ago after the original dev abandoned it. We have now built a product and are in a good position at multi million mcap and with a dedicated community. However, during our evolution we decided to rebrand away from the original name and ticker. We'd like to rebrand with a new name and ticker on Base but keep it linked to our existing renounced liquidity pool so as not to adversely affect current holders. It would be perfect if this could be achieved via the standard bridge.

Tagging @cfluke-cb as Base reviewer. Furthermore, if this is possible, what steps could we take to be listed on the official Base bridging UI? We have a professional product which we'd like to bring to Base and it would help us a lot to be listed in the UI. I would gladly discuss our project and team further and explore options to get listed in the UI.

Thanks for your kind attention

Maintainers: @kevinrolsen, @Kweiss, @enidavis

{
"l1ChainId": "11155111",
"l2ChainId": "58008",
"l1Addresses": {
"AddressManager": "0x0Ad91488288BBe60ff38258785568A6D1EB3B983",
"BondManager": "0x0000000000000000000000000000000000000000",
"CanonicalTransactionChain": "0x0000000000000000000000000000000000000000",
"L1CrossDomainMessenger": "0x97f3558Ce48FE71B8CeFA5497708A49531D5A8E1",
"L1StandardBridge": "0xFaE6abCAF30D23e233AC7faF747F2fC3a5a6Bfa3",
"L2OutputOracle": "0xD5bAc3152ffC25318F848B3DD5dA6C85171BaEEe",
"OptimismPortal": "0xF04BdD5353Bb0EFF6CA60CfcC78594278eBfE179",
"StateCommitmentChain": "0x0000000000000000000000000000000000000000"
}
}

Describe the bug
My recent PR was approved to add BANK token to OP bridge, but the issue is that BANK token only appears on gateway bridge and not the new v2 Optimism bridge.
https://app.optimism.io/bridge/deposit

To Reproduce
Steps to reproduce the behavior:

1. Go to 'https://app.optimism.io/bridge/deposit'
2. Click on 'the ETH dropdown'
3. Scroll down and TOKEN in this case BANK is suppose to appear on bridge

Expected behavior
I was expecting TOKEN in this case BANK to appear on v2 bridge after following the guide to add token to bridge.

Screenshots
If applicable, add screenshots to help explain your problem.

v2 Bridge

Gateway Bridge

Additional context

The Uniswap App is unable to perform color extraction on token logo images hosted at ethereum-optimism.github.io/logos due to the CORS policy.

Access to image at 'https://ethereum-optimism.github.io/logos/SNX.svg' from origin 'https://app.uniswap.org' has been blocked by CORS policy: No 'Access-Control-Allow-Origin' header is present on the requested resource.

Can we relax the CORS policy to support this use case?

To Reproduce
Steps to reproduce the behavior:

1. Go to the Add Liquidity page in uniswap app: https://app.uniswap.org/#/add/0x6fd9d7AD17242c41f7131d257212c54A0e816691/0x94b008aA00579c1307B0EF2c499aD98a8ce58e58/3000

Expected behavior
The slider handles on the price chart should match the color of the tokens. In the example above, pink for UNI and Green for USDT.
Uniswap/interface#2049

Screenshots

System Specs:

• OS: Chrome

Describe the bug
A clear and concise description of what the bug is.

To Reproduce
Steps to reproduce the behavior:

1. Go to '...'
2. Click on '....'
3. Scroll down to '....'
4. See error

Expected behavior
A clear and concise description of what you expected to happen.

Screenshots
If applicable, add screenshots to help explain your problem.

System Specs:

• OS:
• Package Version (or commit hash):

Additional context
Add any other context about the problem here.

Is your feature request related to a problem? Please describe.
There is currently a 7-day auto-close on all issues and pull requests; this might make it trickier to manage this repo as contribution volume increases, because maintainers who are only looking at open issues/pull requests may not realize there were some pending review that ended up getting automatically closed.

People who are trying to contribute/add assets will also need to reopen when this happens; looks like this has happened a couple of times.

Looks like there are a couple of recent PRs this may have inadvertently happened with: https://github.com/ethereum-optimism/ethereum-optimism.github.io/pulls?q=is%3Apr+is%3Aclosed+label%3AStale

Describe the solution you'd like
Consider increasing the timeout threshold for closing stale issues and pull requests to something greater, perhaps 14d or 30d.

Less of a feature request, but more of a curiosity after reading https://static.optimism.io.

Have you guys considered using a different naming layout to support more pragmatic assets/logo discovery?

We've switched our token assets to use the SmolDapp's layout since it's more intuitive and allows for an open collaboration across projects (atm it's Yearn, Velodrome, smold.app/tokenlistooor):

https://github.com/SmolDapp/tokenAssets

Thanks in advance for reviewing this.

@roberto-bayardo

As I understand

• The official base bridge only supports a small number of tokens. Tokens added to this repo under Base (eg. $ALI, $TETU, $SEAM) have not been whitelisted on bridge.base.org. Unlike Optimism's bridge page, the base page doesn't support custom addresses.
• Bridge aggregators like jumper.exchange and rango.exchange do not support Base's standard bridge. I tested this by trying to bridge out USDbC, it gets routed via stargate.

Is there a UI page, official or 3rd party to bridge custom ERC20 tokens? How are existing projects doing it? We do not want to build a custom UI.

Describe the bug
Here's the pr I submitted #419 (which has since been merged) The bridged token has 8 decimals on Ethereum mainnet, and a decimal of 8 was marked in the json file.

But I have just found out that 10000 BITCOIN bridged from mainnet, ended up with only 0.000001 BITCOIN on Optimism.
Deposit tx: https://etherscan.io/tx/0x24d9e06d1a5d352a001c7377e9bee7dc6408e18002cb2c81d03415e9f50ec322
Reception tx: https://optimistic.etherscan.io/tx/0x4625ed722941d3ba2b3196e740415222d02675c636757f5e5c7a51eca029a830

Presumably because there's a difference in decimals of the token on mainnet and Optimism's OptimismMintableERC20. (1e8 vs 1e18) However, when calling createStandardL2Token() on 0x4200000000000000000000000000000000000012 to create the standard L2 token contract on Optimism, no decimals are allowed in calldata so everything is in 1e18.

Expected behavior
The L2 token contract should be allowed to have 6 decimals as well

The "Generate Token List" action (https://github.com/ethereum-optimism/ethereum-optimism.github.io/actions/workflows/generate.yml) has been failing for two weeks. I believe this results in no new tokens being added to optimism.tokenlist.json. Is someone working on fixing this?

The Uniswap app fails to load the latest Optimism token list v3.2.2 due to error:

List at url https://static.optimism.io/optimism.tokenlist.json could not automatically update because the version bump was only PATCH/MINOR while the update had breaking changes and should have been MAJOR

Describe the request
At Uniswap we expect a major version bump when tokens are removed from a token list. It seems this list removed tokens recently, so would you be able to bump the major version number?

To Reproduce
Note that the token removal caused only a minor version change.

Expected behavior
The token removal should cause a major version change.

Description:
bot(ci): generate token list is failing to Publish due to missing credentials in GitHub Actions.

Steps to reproduce:

1. Go to Token List Merged PR
2. Scroll down to "Login to DockerHub"
3. See error: "Username and password required."

Screenshots

See screenshot of publish-bot.

Additional context

The NFTEarth team is intending to bridge from Mainnet to Optimism as soon as possible. Thank you OP team!

          We are gonna change this folder name to `heart` since a :heart: as a file name is not ideal

Originally posted by @roninjin10 in #637 (comment)

Hi,

When the folder name it the GitHub repo was changed from “❤️” to “Like” the json file was also changed in error, specifically the token symbol was changed from “❤️” to “LIKE”. This token symbol change was an error and results in the token symbol now being inconsistent across chains, please revert the token symbol back to “❤️”

Bug Description

CI doesn't seem to be picking up "nonstandard": true despite being present in the metadata

Example: #695

Steps to Reproduce

Try to validate #695

Expected behavior

Validation should pass

Environment Information:

N/A

Configurations:

N/A

Logs:

[ 'DF' ]
error: final token list is invalid
warning: DF on chain ethereum token 0x431ad2ff6a9C365805eBaD47Ee021148d6f7DBe0 is a nonstandard token
warning: DF on chain optimism token 0x9e5AAC1Ba1a2e6aEd6b32689DFcF62A509Ca96f3 is a nonstandard token
warning: DF on chain sepolia token 0x4ed818eDd4a0c36A3F43826A60630879b8164401 is a nonstandard token
warning: DF on chain base-sepolia token 0x0d73bEC7B116c3053b7F0fa108e45A8Ae9A038e9 is a nonstandard token
warning: DF on chain base token 0x178929287b25fe1aC9e0b112CE3899312b6d0557 is a nonstandard token

Additional context

N/A

⚠️ Notice: Issues that do not include the following sections will be subject to closure:

• Bug Description
• Steps to Reproduce
• Environment Information

Please ensure all required sections are filled out accurately to expedite the debugging process and improve issue resolution efficiency.

Describe the bug

This repository claims the baseBridgeAddress for DAI is 0xD0204B9527C1bA7bD765Fa5CCD9355d38338272b.

This is neither the L1StandardBridge address specified in the Base documentation nor is it the address called via bridge.base.org when depositing DAI.

If bridges are done programmatically via 0xD0204B9527C1bA7bD765Fa5CCD9355d38338272b I believe they will fail on the L2 side and funds will be lost.

Describe the bug

Hi team, I added EQB & ePendle token a week ago, but the tokens still didn't appear in the brige token list.

Here's my PR and commit.

Do I need to take any other actions?

To Reproduce
N/A

Expected behavior
EQB & EPendle should be in the bridge token list as PENDLE does.

Screenshots

Both EQB & EPendle show No Results

System Specs:
N/A

Additional context
Pls help investigate! Thanks!

Submit RFP for evaluating the tradeoffs of different voting mechanisms for retro funding. Output should be a table comparing different voting mechanisms (eg, median, approval voting, etc) against a few high-priority requirements that align with our goals (COI-resistance, incentive compatibility, ease of voting process). The table data should be based on simulations, shared in an appendix, and there should also be a section describing the key takeaways in terms of tradeoffs.

Task list:

• Draft RFP

• Share draft with relevant collaborators and internal team members

• Legal review

• Publish RFP

• Directly share RFP with appropriate teams

Relevant docs:

• In progress draft here: https://www.notion.so/DRAFT-Foundation-Mission-Request-Evaluating-Voting-Mechanism-Trade-offs-for-Retro-Funding-6ef32832c3424f39a47d312fc57fd7ce?pvs=4

• Forum discussion on rPGF voting mechanisms: https://gov.optimism.io/t/retropgf-experimentation-voting-algorithms/7216

• Internal brainstorming doc here: https://www.notion.so/Self-dealing-in-Retro-Funding-5-5a411b6dea434aff99f8682f72da5dc6?pvs=4

Complete https://github.com/ethereum-optimism/ethereum-optimism.github.io/tree/10-31-feat_Update_validation

Hi, we want to add our rETH token(https://etherscan.io/address/0x9559aaa82d9649c7a7b220e7c461d2e74c9a3593#code) to the list, but it is duplicated with existing directory because the same symbol. So what should we do?

Btw, about this request: L2 token was deployed by the StandardTokenFactory (requires manual review). Can we manually deploy the L2StandardERC20 contract directly? (https://github.com/ethereum-optimism/optimism/blob/develop/packages/contracts/contracts/standards/L2StandardERC20.sol)

Hi, when I select rETH(StaFi) here(https://app.optimism.io/bridge/deposit), it doesn't work, seems it selects rETH(Rocket Pool ETH).