ethereum / ercs Goto Github PK

The Ethereum Request for Comment repository

License: Creative Commons Zero v1.0 Universal

HTML 1.38% Ruby 0.03% SCSS 0.07% Solidity 66.55% TypeScript 19.98% JavaScript 9.08% C++ 0.78% TeX 1.56% Jupyter Notebook 0.49% CSS 0.08%

ercs's Introduction

Ethereum Request for Comments (ERCs)

Please note that ERCs were recently separated from the EIPs repo.

The goal of ERCs is to standardize and provide high-quality documentation for the Ethereum application layer. This repository tracks past and ongoing improvements application standards in the form of ERCs. EIP-1 governs how EIPs and ERCs are published.

The status page tracks and lists both EIPs and ERCs, which can be divided into the following categories:

Core EIPs are improvements to the Ethereum consensus protocol.
Networking EIPs specify the peer-to-peer networking layer of Ethereum.
Interface EIPs standardize interfaces to Ethereum, which determine how users and applications interact with the blockchain.
ERCs specify application layer standards, which determine how applications running on Ethereum can interact with each other.
Meta EIPs are miscellaneous improvements that nonetheless require some sort of consensus.
Informational EIPs are non-standard improvements that do not require any form of consensus.

Before you write an ERC, ideas MUST be thoroughly discussed on Ethereum Magicians or Ethereum Research. Once consensus is reached, thoroughly read and review EIP-1, which describes the EIP/ERC process.

Please note that this repository is for documenting standards and not for help implementing them. These types of inquiries should be directed to the Ethereum Stack Exchange. For specific questions and concerns regarding ERCs, it's best to comment on the relevant discussion thread of the ERC denoted by the discussions-to tag in the ERC's preamble.

If you would like to become an EIP Editor, please read EIP-5069.

Preferred Citation Format

The canonical URL for an ERC that has achieved draft status at any point is at https://eips.ethereum.org/. For example, the canonical URL for EIP-1 is https://eips.ethereum.org/EIPS/eip-1.

Consider any document not published at https://eips.ethereum.org/ as a working paper. Additionally, consider published EIPs with a status of "draft", "review", or "last call" to be incomplete drafts, and note that their specification is likely to be subject to change.

ercs's People

Contributors

Stargazers

Watchers

Forkers

lightclient generationsoftware screaminghawk rmrk-team dexaran erc4626-alliance kassandraoftroy onireimu quyphandang netwalker108 edoumou nand2 spherity zakrad sandy-sung-lb zoniqx finmath kaihiroi ryanio sullof vittominacori snickerdoodlelabs mpeyfuss samwilsn divide-by-0 dhl artifactlabsofficial xiyu1984 ohhkaneda saitama2009 authenticvision erc-3643 piyush-chittara nexeraprotocol wenzhenxiang coburncoburn xeway nkrishang jaydenwindle 360core joachim-lebrun jxrow lanyinzly tsengmj randomishwalk numbersprotocol fewwwww tokenforge cryptitalk v1d0r just-a-node connext jjmr007 ra-phael asghaier76 paradigmxyz andrefenti gregthegreek frangio essential-contributions 0xclarity woodpile37 eth-infinitism dadudida-com asggwa hethm999 abhik-99 erc6900 hyoungsungkim apache31500 straitsx sharpycobra etan-status adityashukla700 jtriley-eth xiaolou86 misslov3ly alicesof arvolear shadow-hq c1ick aigc-nft kopy-kat oli-art azteccem nnsw3 zia999 garyghayrat zeroknots wartstone jircs1 newt0 nerolation liammichael nerderlyne yoheinishikubo shalom-ins insevm derion-io linagee-name-registrar

ercs's Issues

`eipw` fails to resolve requires in preamble

Pull Request

No response

What happened?

I assume this is an additional problem, adding to #45

When Walidator verifies the preamble, in the requires: 165, 721 it tries to open ERCS/eip-165.md and ERCS/eip-721.md.
This should rather be ERCs/erc-165.md and ERCs/erc-721.md`

Observed here:
46ed905

Relevant log output

No response

Authors should be able to merge PRs not changing the status

Pull Request

#123

What happened?

In this PR I just updated the comments in the interface to clarify some doubts raised by the community. According to the rules, I should be able to merge it without requiring an intervention by one of the editors. However, neither me nor my co-author have that possibility. It looks to me like a bug

Relevant log output

No response

Milehigh.world

          ```suggestion

Needs discussion


_Originally posted by @SamWilsn in https://github.com/ethereum/ERCs/pull/320#discussion_r1619319408_

Incorrect comment in EIP-3448 implementation

Pull Request

No response

What happened?

This comment defines deploy code size:

  function _metaProxyFromMemory (address targetContract, uint256 offset, uint256 length) internal returns (address addr) {
    ...
@>    // The size is deploy code + contract code + calldatasize - 4 + 32.
      addr := create(0, start, sub(ptr, start))
    }
  }

Struggled some time to figure out what is calldata in this context. Eventually this comment was copied from previous function where it used the whole calldata except 4 bytes selector.

This will be right comment because length exactly defines metadata length:

  function _metaProxyFromMemory (address targetContract, uint256 offset, uint256 length) internal returns (address addr) {
   ...
-     // The size is deploy code + contract code + calldatasize - 4 + 32.
+     // The size is deploy code + contract code + length + 32.
      addr := create(0, start, sub(ptr, start))
    }
  }

Relevant log output

No response

may shed a teartoken

MINOR: Broken Doc Link on EIP

Pull Request

No response

What happened?

In the EIP-6865 Doc the link to EIP-712 is broken. It leads to 404 Page. Issue present on master branch.

Relevant log output

No response

G

Fix assets redirect

Pull Request

#242

What happened?

I make assets/erc-#/. Then I hyperlink to text in my docs. It errors with HTML Proofer since file doesn't exist.

In this commit, we fix it by changing erc-# to eip-#, even though that folder doesn't exist.

On compilation, I think assets/erc-# should automatically ln/symlink to assets/eip-# so that behavior is always intuitive.

Relevant log output

At ./_site/EIPS/eip-7524.html:252:
internally linking to ../assets/erc-7524/sec2-v2.pdf, which does not exist
At ./_site/EIPS/eip-7524.html:281:
internally linking to ../assets/erc-7524/sec1-v2.pdf, which does not exist

I get this issue from HTMLProofer when hyperlinking intuitively for the way it compiles in VSCode.

Run summary using wrong repo

Pull Request

#10

What happened?

If you click the link "Run summary" in the comment here: #10 (comment)

It will take you to ethereum/eips#10 instead of this repo.

Relevant log output

No response

Quota Limits reached in Walidator

Pull Request

What happened?

EIP Walidator fails to run, as it hits quota limits;
Refer https://github.com/ethereum/ERCs/actions/runs/6664676695/job/18112762062?pr=43

2023-10-27T08:17:18.7430627Z ##[group]Run ethereum/eipw-action@6858f56d1d9e5cbe49a0afd85150669f6983ed20
2023-10-27T08:17:18.7431484Z with:
2023-10-27T08:17:18.7432800Z   token: ***
2023-10-27T08:17:18.7433175Z   unchecked: 1
2023-10-27T08:17:18.7433562Z   path: ERCS/
2023-10-27T08:17:18.7433976Z   options-file: config/eipw.toml
2023-10-27T08:17:18.7434476Z ##[endgroup]
2023-10-27T08:17:19.4213347Z Request quota exhausted for request GET https://api.github.com/repos/ethereum/ERCs/pulls/43/files
2023-10-27T08:17:19.4214730Z Retrying after 1751 seconds!
2023-10-27T08:46:30.6570178Z Request quota exhausted for request GET https://api.github.com/repos/ethereum/ERCs/pulls/43/files
2023-10-27T08:46:30.6571285Z Retrying after 0 seconds!

Relevant log output

2023-10-27T08:17:18.2926106Z Resolving deltas:  95% (92/96)
2023-10-27T08:17:18.2926598Z Resolving deltas:  96% (93/96)
2023-10-27T08:17:18.2927103Z Resolving deltas:  97% (94/96)
2023-10-27T08:17:18.2968699Z Resolving deltas:  98% (95/96)
2023-10-27T08:17:18.2969660Z Resolving deltas: 100% (96/96)
2023-10-27T08:17:18.2970193Z Resolving deltas: 100% (96/96), done.
2023-10-27T08:17:18.3648393Z From https://github.com/ethereum/ERCs
2023-10-27T08:17:18.3649969Z  * [new ref]         ed28201473f772b953998fe7e49f3a284a655866 -> pull/43/merge
2023-10-27T08:17:18.3680115Z ##[endgroup]
2023-10-27T08:17:18.3681065Z ##[group]Determining the checkout info
2023-10-27T08:17:18.3683078Z ##[endgroup]
2023-10-27T08:17:18.3683994Z ##[group]Checking out the ref
2023-10-27T08:17:18.3690140Z [command]/usr/bin/git checkout --progress --force refs/remotes/pull/43/merge
2023-10-27T08:17:18.6841119Z Note: switching to 'refs/remotes/pull/43/merge'.
2023-10-27T08:17:18.6841912Z 
2023-10-27T08:17:18.6842930Z You are in 'detached HEAD' state. You can look around, make experimental
2023-10-27T08:17:18.6844180Z changes and commit them, and you can discard any commits you make in this
2023-10-27T08:17:18.6845373Z state without impacting any branches by switching back to a branch.
2023-10-27T08:17:18.6846151Z 
2023-10-27T08:17:18.6852155Z If you want to create a new branch to retain commits you create, you may
2023-10-27T08:17:18.6853525Z do so (now or later) by using -c with the switch command. Example:
2023-10-27T08:17:18.6854492Z 
2023-10-27T08:17:18.6854846Z   git switch -c <new-branch-name>
2023-10-27T08:17:18.6855315Z 
2023-10-27T08:17:18.6855575Z Or undo this operation with:
2023-10-27T08:17:18.6856016Z 
2023-10-27T08:17:18.6856242Z   git switch -
2023-10-27T08:17:18.6856573Z 
2023-10-27T08:17:18.6857136Z Turn off this advice by setting config variable advice.detachedHead to false
2023-10-27T08:17:18.6857941Z 
2023-10-27T08:17:18.6858811Z HEAD is now at ed28201 Merge ba664d607145f45456d605275c3841afe2b49d5f into a5f4f4632e6df7915343fdbfa57ce4d270cf2562
2023-10-27T08:17:18.6877596Z ##[endgroup]
2023-10-27T08:17:18.6936305Z [command]/usr/bin/git log -1 --format='%H'
2023-10-27T08:17:18.6976128Z 'ed28201473f772b953998fe7e49f3a284a655866'
2023-10-27T08:17:18.7430627Z ##[group]Run ethereum/eipw-action@6858f56d1d9e5cbe49a0afd85150669f6983ed20
2023-10-27T08:17:18.7431484Z with:
2023-10-27T08:17:18.7432800Z   token: ***
2023-10-27T08:17:18.7433175Z   unchecked: 1
2023-10-27T08:17:18.7433562Z   path: ERCS/
2023-10-27T08:17:18.7433976Z   options-file: config/eipw.toml
2023-10-27T08:17:18.7434476Z ##[endgroup]
2023-10-27T08:17:19.4213347Z Request quota exhausted for request GET https://api.github.com/repos/ethereum/ERCs/pulls/43/files
2023-10-27T08:17:19.4214730Z Retrying after 1751 seconds!
2023-10-27T08:46:30.6570178Z Request quota exhausted for request GET https://api.github.com/repos/ethereum/ERCs/pulls/43/files
2023-10-27T08:46:30.6571285Z Retrying after 0 seconds!
2023-10-27T08:46:30.8135944Z Request quota exhausted for request GET https://api.github.com/repos/ethereum/ERCs/pulls/43/files
2023-10-27T08:46:30.8137215Z Retrying after 0 seconds!
2023-10-27T08:46:30.9641981Z Request quota exhausted for request GET https://api.github.com/repos/ethereum/ERCs/pulls/43/files
2023-10-27T08:46:30.9700847Z RequestError [HttpError]: API rate limit exceeded for installation ID 2246695. If you reach out to GitHub Support for help, please include the request ID 7C80:4BF1:169136D:176DA4E:653B78E6.
2023-10-27T08:46:30.9703860Z     at /home/runner/work/_actions/ethereum/eipw-action/6858f56d1d9e5cbe49a0afd85150669f6983ed20/dist/index.js:6691:25
2023-10-27T08:46:30.9705643Z     at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
2023-10-27T08:46:30.9707818Z     at async Job.doExecute (/home/runner/work/_actions/ethereum/eipw-action/6858f56d1d9e5cbe49a0afd85150669f6983ed20/dist/index.js:8747:22) {
2023-10-27T08:46:30.9709374Z   status: 403,
2023-10-27T08:46:30.9710259Z   response: {
2023-10-27T08:46:30.9711902Z     url: 'https://api.github.com/repos/ethereum/ERCs/pulls/43/files',
2023-10-27T08:46:30.9712700Z     status: 403,
2023-10-27T08:46:30.9713144Z     headers: {
2023-10-27T08:46:30.9713650Z       'access-control-allow-origin': '*',
2023-10-27T08:46:30.9722362Z       'access-control-expose-headers': 'ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Used, X-RateLimit-Resource, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type, X-GitHub-SSO, X-GitHub-Request-Id, Deprecation, Sunset',
2023-10-27T08:46:30.9725524Z       'content-encoding': 'gzip',
2023-10-27T08:46:30.9726256Z       'content-security-policy': "default-src 'none'",
2023-10-27T08:46:30.9727125Z       'content-type': 'application/json; charset=utf-8',
2023-10-27T08:46:30.9727919Z       date: 'Fri, 27 Oct 2023 08:46:30 GMT',
2023-10-27T08:46:30.9728994Z       'referrer-policy': 'origin-when-cross-origin, strict-origin-when-cross-origin',
2023-10-27T08:46:30.9729973Z       server: 'GitHub.com',
2023-10-27T08:46:30.9730895Z       'strict-transport-security': 'max-age=31536000; includeSubdomains; preload',
2023-10-27T08:46:30.9731876Z       'transfer-encoding': 'chunked',
2023-10-27T08:46:30.9732643Z       vary: 'Accept-Encoding, Accept, X-Requested-With',
2023-10-27T08:46:30.9733442Z       'x-content-type-options': 'nosniff',
2023-10-27T08:46:30.9736040Z       'x-frame-options': 'deny',
2023-10-27T08:46:30.9736770Z       'x-github-media-type': 'github.v3; format=json',
2023-10-27T08:46:30.9737712Z       'x-github-request-id': '7C80:4BF1:169136D:176DA4E:653B78E6',
2023-10-27T08:46:30.9738517Z       'x-ratelimit-limit': '1000',
2023-10-27T08:46:30.9739129Z       'x-ratelimit-remaining': '0',
2023-10-27T08:46:30.9739757Z       'x-ratelimit-reset': '1698396390',
2023-10-27T08:46:30.9740415Z       'x-ratelimit-resource': 'core',
2023-10-27T08:46:30.9741039Z       'x-ratelimit-used': '1003',
2023-10-27T08:46:30.9741607Z       'x-xss-protection': '0'
2023-10-27T08:46:30.9742074Z     },
2023-10-27T08:46:30.9742403Z     data: {
2023-10-27T08:46:30.9744379Z       message: 'API rate limit exceeded for installation ID 2246695. If you reach out to GitHub Support for help, please include the request ID 7C80:4BF1:169136D:176DA4E:653B78E6.',
2023-10-27T08:46:30.9746692Z       documentation_url: 'https://docs.github.com/rest/overview/resources-in-the-rest-api#rate-limiting'
2023-10-27T08:46:30.9747744Z     }
2023-10-27T08:46:30.9748045Z   },
2023-10-27T08:46:30.9748370Z   request: {
2023-10-27T08:46:30.9748783Z     method: 'GET',
2023-10-27T08:46:30.9749506Z     url: 'https://api.github.com/repos/ethereum/ERCs/pulls/43/files',
2023-10-27T08:46:30.9750280Z     headers: {
2023-10-27T08:46:30.9750818Z       accept: 'application/vnd.github.v3+json',
2023-10-27T08:46:30.9751759Z       'user-agent': 'octokit-core.js/3.6.0 Node.js/20.8.1 (linux; x64)',
2023-10-27T08:46:30.9752636Z       authorization: 'token [REDACTED]'
2023-10-27T08:46:30.9753182Z     },
2023-10-27T08:46:30.9753503Z     request: {
2023-10-27T08:46:30.9753928Z       agent: [Agent],
2023-10-27T08:46:30.9754424Z       hook: [Function: bound bound register],
2023-10-27T08:46:30.9755006Z       retryCount: 2
2023-10-27T08:46:30.9755390Z     }
2023-10-27T08:46:30.9755716Z   }
2023-10-27T08:46:30.9756008Z }
2023-10-27T08:46:30.9795088Z ##[error]API rate limit exceeded for installation ID 2246695. If you reach out to GitHub Support for help, please include the request ID 7C80:4BF1:169136D:176DA4E:653B78E6.
2023-10-27T08:46:30.9948397Z Post job cleanup.
2023-10-27T08:46:31.1356185Z [command]/usr/bin/git version
2023-10-27T08:46:31.1415055Z git version 2.42.0
2023-10-27T08:46:31.1469921Z Temporarily overriding HOME='/home/runner/work/_temp/356dc8ac-02e1-4d8d-a597-143f04bf7d0d' before making global git config changes
2023-10-27T08:46:31.1471950Z Adding repository directory to the temporary git global config as a safe directory
2023-10-27T08:46:31.1478690Z [command]/usr/bin/git config --global --add safe.directory /home/runner/work/ERCs/ERCs
2023-10-27T08:46:31.1532604Z [command]/usr/bin/git config --local --name-only --get-regexp core\.sshCommand
2023-10-27T08:46:31.1580892Z [command]/usr/bin/git submodule foreach --recursive sh -c "git config --local --name-only --get-regexp 'core\.sshCommand' && git config --local --unset-all 'core.sshCommand' || :"
2023-10-27T08:46:31.1912725Z [command]/usr/bin/git config --local --name-only --get-regexp http\.https\:\/\/github\.com\/\.extraheader
2023-10-27T08:46:31.1957589Z http.https://github.com/.extraheader
2023-10-27T08:46:31.1973757Z [command]/usr/bin/git config --local --unset-all http.https://github.com/.extraheader
2023-10-27T08:46:31.2021639Z [command]/usr/bin/git submodule foreach --recursive sh -c "git config --local --name-only --get-regexp 'http\.https\:\/\/github\.com\/\.extraheader' && git config --local --unset-all 'http.https://github.com/.extraheader' || :"
2023-10-27T08:46:31.2739924Z Cleaning up orphan processes

Node.js actions are deprecated

Pull Request

#202

What happened?

The EIP 7595 was filed around Jan 2024. We have been going thru all changes requested by admins. When we checked with the progress in June 2024, we got the following error:

"Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: ...."

It seems like there are changes on the side of EIP/ERC filing process. Can you please advise as to the next steps to ensure we finalize the filing or refile?

Relevant log output

No response

Migrating Pull Requests from `ethereum/EIPs` to `ethereum/ERCs`

If you are trying to move a PR you made to ethereum/eips over to ethereum/ercs, the steps below will guide you through the process:

Fork this repository within GitHub:
1. Navigate to ethereum/ERCs.
2. Find the "Fork" button in the upper right side of the screen and click it.
3. Proceed with repository creation.
Clone your fork locally:
1. git clone https://github.com/{user}/ercs
Enter the newly created ercs folder:
1. cd ercs
Add your fork of the EIPs repository as a remote:
1. git remote add eips https://github.com/{user}/eips
Fetch that remote to download your branches:
1. git fetch eips
Now checkout the branch related to your original PR:
1. git checkout {branch}
Rebase your branch against the ERCs repo:
1. git rebase master
2. Please note, you do not need to update any references of EIP to ERC; particularly in the relative links. Even though [ERC-X](./eip-x.md) doesn't correctly render in this repository, we're currently building the full eips.ethereum.org still in the ethereum/eips repository. So until we resolve this in #1, we will continue using this relative linking format.
Push your branch to your ERCs fork:
1. git push -u origin {branch}
Now you can recreate your pull request:
1. Navigate to https://github.com/ethereum/ERCs/compare
2. Select your newly created fork and branch
3. open a new PR to this repo.

Additional notes:

Do NOT link to ERCs using their filename. Link to ERCs using [ERC-XXXX](./eip-XXXX.md).

Typo in ERC-1046

Pull Request

No response

What happened?

Typo in ERC-1046

https://github.com/ethereum/ercs/blob/master/ERCS/erc-1046.md

CTRL+F for Interoperabiliy

Relevant log output

No response

Pending tasks for ERC migration

TODO

HTML Proofer bug

Pull Request

#44

What happened?

The HTML proofer is still looking for the files in ../assets/eip-XXX while the files have been all updated to ../assets/erc-XXX during the split. Same happens for files ./erc-XXX that generate errors too as the HTML Proofer says they don't exist.
In the PR #44 i updated the path of all assets files and HTML proofer bot blocks the PR with errors.

Relevant log output

Checking 5415 internal links
Checking internal link hashes in 700 files
Ran on 740 files!


For the Links > Internal check, the following failures were found:

* At ./_site/EIPS/eip-3643.html:251:

  internally linking to ./erc-3643.md, which does not exist

* At ./_site/EIPS/eip-3643.html:268:

  internally linking to ./erc-20.md, which does not exist

* At ./_site/EIPS/eip-3643.html:309:

  internally linking to ./erc-173.md, which does not exist

* At ./_site/EIPS/eip-3643.html:364:

  internally linking to ../assets/erc-3643/ONCHAINID/IERC735.sol, which does not exist

* At ./_site/EIPS/eip-3643.html:405:

  internally linking to ../assets/erc-3643/interfaces/IERC3643.sol, which does not exist

* At ./_site/EIPS/eip-3643.html:473:

  internally linking to ../assets/erc-3643/interfaces/IIdentityRegistry.sol, which does not exist

* At ./_site/EIPS/eip-3643.html:475:

  internally linking to ../assets/erc-3643/ONCHAINID/IClaimIssuer.sol, which does not exist

* At ./_site/EIPS/eip-3643.html:475:

  internally linking to ../assets/erc-3643/ONCHAINID/IIdentity.sol, which does not exist

* At ./_site/EIPS/eip-3643.html:528:

  internally linking to ../assets/erc-3643/interfaces/IIdentityRegistryStorage.sol, which does not exist

* At ./_site/EIPS/eip-3643.html:572:

  internally linking to ../assets/erc-3643/interfaces/ICompliance.sol, which does not exist

* At ./_site/EIPS/eip-3643.html:605:

  internally linking to ../assets/erc-3643/ONCHAINID/IClaimIssuer.sol, which does not exist

* At ./_site/EIPS/eip-3643.html:605:

  internally linking to ../assets/erc-3643/ONCHAINID/IIdentity.sol, which does not exist

* At ./_site/EIPS/eip-3643.html:609:

  internally linking to ../assets/erc-3643/interfaces/ITrustedIssuersRegistry.sol, which does not exist

* At ./_site/EIPS/eip-3643.html:641:

  internally linking to ../assets/erc-3643/ONCHAINID/IIdentity.sol, which does not exist

* At ./_site/EIPS/eip-3643.html:645:

  internally linking to ../assets/erc-3643/interfaces/IClaimTopicsRegistry.sol, which does not exist

* At ./_site/EIPS/eip-3643.html:727:

  internally linking to ../assets/erc-3643/ONCHAINID/IERC735.sol, which does not exist

* At ./_site/EIPS/eip-3643.html:728:

  internally linking to ../assets/erc-3643/ONCHAINID/IIdentity.sol, which does not exist

* At ./_site/EIPS/eip-5564.html:289:

  internally linking to ../assets/erc-5564/scheme_ids.md, which does not exist

* At ./_site/EIPS/eip-5564.html:372:

  internally linking to ./erc-6538, which does not exist

* At ./_site/EIPS/eip-5564.html:384:

  internally linking to ../assets/erc-5564/scheme_ids.md, which does not exist

* At ./_site/EIPS/eip-5564.html:575:

  internally linking to ./erc-4337, which does not exist


HTML-Proofer found 21 failures!
Error: Process completed with exit code 1.

Pull request stuck at "Merging can be performed automatically with 0 approving reviews"

Pull Request

#221

What happened?

I submitted a request on Jan 26. It was a migration from the EIP repository to ERC. This pull request (221) was stuck at the error "Merging can be performed automatically with 0 approving reviews" with no further attention. It seems that the EIP bot should automatically merge the pull request, but it didn't happen. Can someone please advise on how we can proceed from here?

Relevant log output

No response

Add support for rendering interfaces in multiple languages when YAML ABIs are used in ERCs

A suggestion per EIP-2069 (which should be taken up as a separate issue to migrate existing ERCs to this standard) is to write ABIs for ERC interfaces in a YAML format (for example, ERC-4626)

There are lots of benefits of this (can lint ABI interfaces, can directly lift them into external tools, use them directly within different languages, host an ERCs package, etc) but a really big benefit is that we can easily render these interfaces into different smart contract languages when providing examples

So, someone reading up on ERC4626 can click a button and see all the examples in Solidity or Vyper (or other languages such as Huff, Fe, etc), or even as JS/Python/Rust objects and import them easily with how they would like to use it

Suggesting or enforcing YAML ABIs also has the side benefit of ensuring that an ERC is well formed, and not prescriptive of particular language features

Unrelated errors reported from HTML Proofer

Pull Request

#91

What happened?

The validation of HTML Proofer output a bunch of errors that have nothing to do with the files changed in my PR.

https://github.com/ethereum/ERCs/actions/runs/6929548434/job/18847469212

Relevant log output

Run bundle exec htmlproofer --allow-missing-href --disable-external --assume-extension '.html' --log-level=:info --cache='{"timeframe":{"external":"6w"}}' --checks 'Links,Images,Scripts,OpenGraph' --no-check-sri --ignore-empty-alt --no-enforce_https ./_site
Running 4 checks (Images, Links, OpenGraph, Scripts) in ["./_site"] on *.html files ...


Checking 5425 internal links
Checking internal link hashes in 703 files
Ran on 743 files!


For the Images check, the following failures were found:

* At ./_site/EIPS/eip-6358.html:226:

  internal image ../assets/erc-6358/img/o-dlt.png does not exist

For the Links > Internal check, the following failures were found:

* At ./_site/EIPS/eip-7066.html:219:

  internally linking to ./erc-721.md, which does not exist

* At ./_site/EIPS/eip-7066.html:229:

  internally linking to ./erc-721.md, which does not exist

* At ./_site/EIPS/eip-7066.html:237:

  internally linking to ./erc-721.md, which does not exist

* At ./_site/EIPS/eip-7066.html:264:

  internally linking to ./erc-721.md, which does not exist

* At ./_site/EIPS/eip-7066.html:284:

  internally linking to ./erc-721.md, which does not exist

* At ./_site/EIPS/eip-7066.html:372:

  internally linking to ./erc-721.md, which does not exist

* At ./_site/EIPS/eip-7066.html:374:

  internally linking to ./erc-721.md, which does not exist

* At ./_site/EIPS/eip-7066.html:384:

  internally linking to ../assets/erc-7066/test/test.js, which does not exist

* At ./_site/EIPS/eip-7066.html:394:

  internally linking to ../assets/erc-7066/IERC7066.sol, which does not exist

* At ./_site/EIPS/eip-7066.html:396:

  internally linking to ../assets/erc-7066/ERC7066.sol, which does not exist

* At ./_site/EIPS/eip-7066.html:406:

  internally linking to ./erc-721.md, which does not exist

* At ./_site/EIPS/eip-7092.html:228:

  internally linking to ./erc-3475.md, which does not exist

* At ./_site/EIPS/eip-7092.html:240:

  internally linking to ./erc-165.md, which does not exist

* At ./_site/EIPS/eip-7092.html:655:

  internally linking to ./erc-20.md, which does not exist

* At ./_site/EIPS/eip-7092.html:655:

  internally linking to ./erc-1155.md, which does not exist

* At ./_site/EIPS/eip-7092.html:665:

  internally linking to ../assets/erc-7092/ERC7092.sol, which does not exist

* At ./_site/EIPS/eip-7092.html:667:

  internally linking to ../assets/erc-7092/ERC7092.sol, which does not exist


HTML-Proofer found 18 failures!
Error: Process completed with exit code 1.

ethereum / ercs Goto Github PK

ercs's Introduction

Ethereum Request for Comments (ERCs)

Preferred Citation Format

ercs's People

Contributors

Stargazers

Watchers

Forkers

ercs's Issues

Pull Request

What happened?

Relevant log output

Pull Request

What happened?

Relevant log output

Pull Request

What happened?

Relevant log output

Pull Request

What happened?

Relevant log output

Pull Request

What happened?

Relevant log output

Pull Request

What happened?

Relevant log output

Pull Request

What happened?

Relevant log output

Pull Request

What happened?

Relevant log output

Pull Request

What happened?

Relevant log output

TODO

Pull Request

What happened?

Relevant log output

Pull Request

What happened?

Relevant log output

Pull Request

What happened?

Relevant log output

Recommend Projects

Recommend Topics

Recommend Org