WARNING: ethjs v0.3.8 is adding web3@1.0.0-beta34 to deps !!!,about ethjs/ethjs

SilentCicero commented on May 27, 2024

Oh boy! Sorry, that was pull request from the MetaMask team, we will patch immediately tomorrow! My apologies, my size checking should have caught this.

…

Sent from my iPhone

On May 9, 2018, at 8:40 PM, Victor ***@***.***> wrote: I just couldn't figure why between two run of my CI build system I had completely different npm install log result... I finally figured out that ethjs has just been updated, and I don't know how you managed guys, but ***@***.*** is now a DEPENDENCY of EthJS!!! :D └─┬ ***@***.*** └─┬ ***@***.*** └─┬ ***@***.*** └─┬ ***@***.*** └── ***@***.*** So its a reminder for always using npm i --save-exact... — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.

from ethjs.

SilentCicero commented on May 27, 2024

I'm going to have words with Aaron tomorrow, fire and fury I tell you!

…

Sent from my iPhone

On May 9, 2018, at 8:40 PM, Victor ***@***.***> wrote: I just couldn't figure why between two run of my CI build system I had completely different npm install log result... I finally figured out that ethjs has just been updated, and I don't know how you managed guys, but ***@***.*** is now a DEPENDENCY of EthJS!!! :D └─┬ ***@***.*** └─┬ ***@***.*** └─┬ ***@***.*** └─┬ ***@***.*** └── ***@***.*** So its a reminder for always using npm i --save-exact... — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.

from ethjs.

SilentCicero commented on May 27, 2024

Patched in 0.3.9, thanks Victor!!

…

Sent from my iPhone

On May 9, 2018, at 8:40 PM, Victor ***@***.***> wrote: I just couldn't figure why between two run of my CI build system I had completely different npm install log result... I finally figured out that ethjs has just been updated, and I don't know how you managed guys, but ***@***.*** is now a DEPENDENCY of EthJS!!! :D └─┬ ***@***.*** └─┬ ***@***.*** └─┬ ***@***.*** └─┬ ***@***.*** └── ***@***.*** So its a reminder for always using npm i --save-exact... — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.

from ethjs.

kumavis commented on May 27, 2024

not sure why these were installed for you, they should be dev-deps

from ethjs.

sulliwane commented on May 27, 2024

Ahah, thanks for your quick update. I confirm it's not reproducible using v0.3.9 ! Many thanks

Sorry it was late night when I discovered what was causing my CI to fail, and I didn't check that indeed, it was only affecting dev dependencies. I'm doing transpilation in my CI system, which is why I'm also installing dev-deps...

I love the great work you are doing with EthJS. It's light, it's pure js (js-sha over keccack, elliptic over secp256k1...etc), and it's totally modular. Thanks for that

from ethjs.

roschler commented on May 27, 2024

After reading this issue I updated to 0.3.9. As soon as I did that I started getting a run-time error about "babel" when I tried to run my Node.js app. I reverted back to 0.3.6 and the error went away and I could run my app again:

module.js:549
throw err;
^

Error: Cannot find module 'babel-runtime/regenerator'
at Function.Module._resolveFilename (module.js:547:15)
at Function.Module._load (module.js:474:25)
at Module.require (module.js:596:17)
at require (internal/module.js:11:18)
at Object. (/home/use/Documents/GitHub/node_modules/ethjs-query/lib/index.js:3:20)
at Module._compile (module.js:652:30)
at Object.Module._extensions..js (module.js:663:10)
at Module.load (module.js:565:32)
at tryModuleLoad (module.js:505:12)
at Function.Module._load (module.js:497:3)
Waiting for the debugger to disconnect...

from ethjs.

SilentCicero commented on May 27, 2024

Will patch that today, thanks guys for the instant feedback, there were lots of changes so we are just stabilizing now! Can you expand on how your trying to run it Robert?

…

Sent from my iPhone

On May 10, 2018, at 8:30 AM, Robert Oschler ***@***.***> wrote: After reading this issue I updated to 0.3.9. As soon as I did that I started getting a run-time error about "babel" when I tried to run my Node.js app. I reverted back to 0.3.6 and the error went away and I could run my app again: module.js:549 throw err; ^ Error: Cannot find module 'babel-runtime/regenerator' at Function.Module._resolveFilename (module.js:547:15) at Function.Module._load (module.js:474:25) at Module.require (module.js:596:17) at require (internal/module.js:11:18) at Object. (/home/use/Documents/GitHub/node_modules/ethjs-query/lib/index.js:3:20) at Module._compile (module.js:652:30) at Object.Module._extensions..js (module.js:663:10) at Module.load (module.js:565:32) at tryModuleLoad (module.js:505:12) at Function.Module._load (module.js:497:3) Waiting for the debugger to disconnect... — You are receiving this because you commented. Reply to this email directly, view it on GitHub, or mute the thread.

from ethjs.

roschler commented on May 27, 2024

Can you expand on how your trying to run it Robert?

I have a feeling that I don't really know what you're asking but here goes. I'm simply executing my Node.js app and the error happens in the web page that requires eth.js when the require operation takes place.

from ethjs.

SilentCicero commented on May 27, 2024

Okay, just any more steps to recreate would be super helpful!

…

Sent from my iPhone

On May 10, 2018, at 12:19 PM, Robert Oschler ***@***.***> wrote: Can you expand on how your trying to run it Robert? I have a feeling that I don't really know what you're asking but here goes. I'm simply executing my Node.js app and the error happens in the web page that requires eth.js when the require operation takes place. — You are receiving this because you commented. Reply to this email directly, view it on GitHub, or mute the thread.

from ethjs.

roschler commented on May 27, 2024

That's what I'm saying, there aren't any other steps to reproduce, it's very straightforward. I just executed "*npm i [email protected]*" from a terminal window and the error happened immediately when the *require *statement for the *ethjs* package executed as soon as I ran my app. You can see this in my original stack trace. What else can I tell you? A fast guess would be that one of the packages you you added to your package.json between 0.3.6 and 0.3.9 is pulling in babel, and I don't have that package in mine. Perhaps you might check the Git commit history for package.json between 0.3.6 and 0.3.9? I really don't know what else to offer as far as information. On Thu, May 10, 2018 at 12:41 PM, Nick Dodson <[email protected]> wrote:

…

Okay, just any more steps to recreate would be super helpful! Sent from my iPhone > On May 10, 2018, at 12:19 PM, Robert Oschler ***@***.***> wrote: > > Can you expand on how your trying to run it Robert? > > I have a feeling that I don't really know what you're asking but here goes. I'm simply executing my Node.js app and the error happens in the web page that requires eth.js when the require operation takes place. > > — > You are receiving this because you commented. > Reply to this email directly, view it on GitHub, or mute the thread. > — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#29 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AEcdB1dDIoCLhje7eLbTJp3znd6a57wuks5txG2kgaJpZM4T5Mbw> .

-- Thanks, Robert Oschler Twitter: https://twitter.com/roschler <http://twitter.com/roschler> LinkedIn: https://www.linkedin.com/in/natlang/

from ethjs.

artem-a commented on May 27, 2024

Hi, I have the same problem. I installed the latest version in an empty application, ran and got an error

2018-05-10T18:29:43.802Z - debug:  Error: Cannot find module 'babel-runtime/regenerator'
    at Function.Module._resolveFilename (internal/modules/cjs/loader.js:571:15)
    at Function.Module._load (internal/modules/cjs/loader.js:497:25)
    at Module.require (internal/modules/cjs/loader.js:626:17)
    at require (internal/modules/cjs/helpers.js:20:18)
    at Object.<anonymous> (........node_modules/ethjs-query/lib/index.js:3:20)
    at Module._compile (internal/modules/cjs/loader.js:678:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:689:10)
    at Module.load (internal/modules/cjs/loader.js:589:32)
    at tryModuleLoad (internal/modules/cjs/loader.js:528:12)
    at Function.Module._load (internal/modules/cjs/loader.js:520:3)

from ethjs.

artem-a commented on May 27, 2024

versions 0.3.6, 0.3.8 work fine
versions 0.3.7, 0.3.9 broken

from ethjs.

vldmkr commented on May 27, 2024

@roschler @artem-a As a workaround, you can install babel-plugin-transform-runtime next to the [email protected] as dev dependency. It solves the problem. But something is wrong, since the guilty ethjs-query module already contains this dependency.

from ethjs.

roschler commented on May 27, 2024

Thanks. Is there a special NPM command to install something as a dependency? Or do I just do "npm i" on the *babel-plugin-transform-runtime *package?

…

On Thu, May 10, 2018 at 6:31 PM, Vladyslav Makarian < ***@***.***> wrote: @roschler <https://github.com/roschler> @artem-a <https://github.com/artem-a> As a workaround, you can install *babel-plugin-transform-runtime* next to the ***@***.**** as dev dependency. It solves the problem. But something is wrong, since the guilty *ethjs-query* module already contains this dependency. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#29 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AEcdB2RPUUjjWvp1PPz5TjEQomHM6F5tks5txL_ZgaJpZM4T5Mbw> .

-- Thanks, Robert Oschler Twitter: https://twitter.com/roschler <http://twitter.com/roschler> LinkedIn: https://www.linkedin.com/in/natlang/

from ethjs.

SilentCicero commented on May 27, 2024

Will start patching now, it seems like somewhere along the line babel has been pulled in, thanks guys!

…

Sent from my iPhone

On May 10, 2018, at 8:09 PM, Robert Oschler ***@***.***> wrote: Thanks. Is there a special NPM command to install something as a dependency? Or do I just do "npm i" on the *babel-plugin-transform-runtime *package? On Thu, May 10, 2018 at 6:31 PM, Vladyslav Makarian < ***@***.***> wrote: > @roschler <https://github.com/roschler> @artem-a > <https://github.com/artem-a> As a workaround, you can install > *babel-plugin-transform-runtime* next to the ***@***.**** as dev > dependency. It solves the problem. But something is wrong, since the guilty > *ethjs-query* module already contains this dependency. > > — > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub > <#29 (comment)>, or mute > the thread > <https://github.com/notifications/unsubscribe-auth/AEcdB2RPUUjjWvp1PPz5TjEQomHM6F5tks5txL_ZgaJpZM4T5Mbw> > . > -- Thanks, Robert Oschler Twitter: https://twitter.com/roschler <http://twitter.com/roschler> LinkedIn: https://www.linkedin.com/in/natlang/ — You are receiving this because you commented. Reply to this email directly, view it on GitHub, or mute the thread.

from ethjs.

SilentCicero commented on May 27, 2024

Found the issue, will patch tomorrow. For now, we will have to install babel runtime until I upgrade to babel 7. This should not effect size dramatically.

…

Sent from my iPhone

On May 10, 2018, at 8:09 PM, Robert Oschler ***@***.***> wrote: Thanks. Is there a special NPM command to install something as a dependency? Or do I just do "npm i" on the *babel-plugin-transform-runtime *package? On Thu, May 10, 2018 at 6:31 PM, Vladyslav Makarian < ***@***.***> wrote: > @roschler <https://github.com/roschler> @artem-a > <https://github.com/artem-a> As a workaround, you can install > *babel-plugin-transform-runtime* next to the ***@***.**** as dev > dependency. It solves the problem. But something is wrong, since the guilty > *ethjs-query* module already contains this dependency. > > — > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub > <#29 (comment)>, or mute > the thread > <https://github.com/notifications/unsubscribe-auth/AEcdB2RPUUjjWvp1PPz5TjEQomHM6F5tks5txL_ZgaJpZM4T5Mbw> > . > -- Thanks, Robert Oschler Twitter: https://twitter.com/roschler <http://twitter.com/roschler> LinkedIn: https://www.linkedin.com/in/natlang/ — You are receiving this because you commented. Reply to this email directly, view it on GitHub, or mute the thread.

from ethjs.

SilentCicero commented on May 27, 2024

Try 4.0. Temporary size increase until I reconfigure babel and dump the polyfill. My apologies everyone. Ethjs should never be down. These were outside commits I accepted without thinking. We will and can do better. Thank you!

…

Sent from my iPhone

On May 10, 2018, at 8:09 PM, Robert Oschler ***@***.***> wrote: Thanks. Is there a special NPM command to install something as a dependency? Or do I just do "npm i" on the *babel-plugin-transform-runtime *package? On Thu, May 10, 2018 at 6:31 PM, Vladyslav Makarian < ***@***.***> wrote: > @roschler <https://github.com/roschler> @artem-a > <https://github.com/artem-a> As a workaround, you can install > *babel-plugin-transform-runtime* next to the ***@***.**** as dev > dependency. It solves the problem. But something is wrong, since the guilty > *ethjs-query* module already contains this dependency. > > — > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub > <#29 (comment)>, or mute > the thread > <https://github.com/notifications/unsubscribe-auth/AEcdB2RPUUjjWvp1PPz5TjEQomHM6F5tks5txL_ZgaJpZM4T5Mbw> > . > -- Thanks, Robert Oschler Twitter: https://twitter.com/roschler <http://twitter.com/roschler> LinkedIn: https://www.linkedin.com/in/natlang/ — You are receiving this because you commented. Reply to this email directly, view it on GitHub, or mute the thread.

from ethjs.

WARNING: ethjs v0.3.8 is adding [email protected] to deps !!! about ethjs HOT 17 CLOSED

Comments (17)

Related Issues (20)

Recommend Projects

React

Vue.js

Typescript

TensorFlow

Django

Laravel

D3

Recommend Topics

javascript

web

server

Machine learning

Visualization

Game

Recommend Org

Facebook

Microsoft

Google

Alibaba

D3

Tencent