Build error while applying the patch about polygon_coverage_planning HOT 7 CLOSED

Nice introspection!

It would be awesome, if you can fix the patch such that it runs with your newer cmake version and open a PR :)

from polygon_coverage_planning.

Hi @hardesh

I just ran a successful build on the build server (gcc version 7.4.0 (Ubuntu 7.4.0-1ubuntu1~18.04.1) ). But I think @stlucas44 recently had the same issue as you because his machine did not run stock cmake. @stlucas44 can you confirm that it was the same error?

For reference, my personal machine is running cmake version 3.10.2 and it seems to build fine as well.

from polygon_coverage_planning.

Hi @rikba

Yes, I may not have the stock cmake. I had recently updated the cmake while installing Open3D. I have cmake version 3.18 on my machine.

[ 25%] Built target polygon_coverage_solvers
patching file GkMa/OurHeuristic/Algorithm.cs
Hunk #2 FAILED at 33.
Hunk #3 FAILED at 37.
Hunk #4 succeeded at 120 (offset 44 lines).

The error is occurring while applying the patch on Algorithms.cs. So, I checked that file and in fact, the line numbers are different than those mentioned in the patch.

from polygon_coverage_planning.

Sure!
I'll give it a try over the weekend. 😃

from polygon_coverage_planning.

Hi @rikba

I wasn't able to find a solution for this on my Ubuntu 18.04. But I did build the package on Ubuntu 20 with default cmake and it's working. Thanks!

from polygon_coverage_planning.

Good to know, that it still builds on Ubuntu 20. Thank you!

from polygon_coverage_planning.

Hello @hardesh @rikba

Recently I also met this problem when I build this project on Ubuntu 18.04, ROS melodic and camke(version 3.18). Then I try to reinstall cmake(version 3.10.2), and I solved this problem. I hope this will help you.

from polygon_coverage_planning.