Giter VIP home page Giter VIP logo

Comments (7)

PMSeitzer avatar PMSeitzer commented on August 25, 2024

Please see https://github.com/PMSeitzer/maven/issues/5 for more information.

from maven.

PMSeitzer avatar PMSeitzer commented on August 25, 2024

I have reanalyzed using 20190509-Calico-Lipids-neg.msp, and I can confirm that the bug still exists.
PI(18_2_18_0)_in_new_library

from maven.

PMSeitzer avatar PMSeitzer commented on August 25, 2024

Compound_Search_Widget
The problem seems to be this:
a peakgroup matches to multiple compounds. One matches higher than all the others.
In the compoundSearch widget, this appears to be working correctly.
However, in the DB Search widget, this is incorrect - all candidates show the score
of the top-scoring match, instead of the score associated with that candidate.

The correct behavior would be to exclude the rows of all matches except for the top matches.
These matches can always be retrieved using the 'Compound Search' widget.

from maven.

PMSeitzer avatar PMSeitzer commented on August 25, 2024

Alternatively, we could take a "compound-centric" view, where we are interested in the top-scoring feature for a compound.

from maven.

PMSeitzer avatar PMSeitzer commented on August 25, 2024

Desired options in GUI for peakgroup <--> compound+adduct matches:

Offer options to

  • return all compound+adduct matches for peak group
  • return one top hit (in the event of a tie, choose alphabetical)
  • return all compounds with highest score

Offer option to retain peak groups that do not match to any compounds

from maven.

PMSeitzer avatar PMSeitzer commented on August 25, 2024

This work will be done in issue-24.

from maven.

PMSeitzer avatar PMSeitzer commented on August 25, 2024

Waiting to close this bug to see if Eugene would like any adjustments.

from maven.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.