Comments (7)
Please see https://github.com/PMSeitzer/maven/issues/5 for more information.
from maven.
I have reanalyzed using 20190509-Calico-Lipids-neg.msp
, and I can confirm that the bug still exists.
from maven.
The problem seems to be this:
a peakgroup matches to multiple compounds. One matches higher than all the others.
In the compoundSearch widget, this appears to be working correctly.
However, in the DB Search widget, this is incorrect - all candidates show the score
of the top-scoring match, instead of the score associated with that candidate.
The correct behavior would be to exclude the rows of all matches except for the top matches.
These matches can always be retrieved using the 'Compound Search' widget.
from maven.
Alternatively, we could take a "compound-centric" view, where we are interested in the top-scoring feature for a compound.
from maven.
Desired options in GUI for peakgroup <--> compound+adduct matches:
Offer options to
- return all compound+adduct matches for peak group
- return one top hit (in the event of a tie, choose alphabetical)
- return all compounds with highest score
Offer option to retain peak groups that do not match to any compounds
from maven.
This work will be done in issue-24
.
from maven.
Waiting to close this bug to see if Eugene would like any adjustments.
from maven.
Related Issues (20)
- Factor out PeakContainer merging step from EIC::mergedEICToGroups() HOT 2
- Option to transfer, combine properties from peaks properties during merging step HOT 1
- Implement IsotopicEnvelopeAdjuster::condenseTheoreticalIsotopes() HOT 2
- Isotopic Correction incorrect HOT 3
- Clicking through spectral library with no samples selected can cause program to hang HOT 6
- Implement data-specific computation of isotopes HOT 1
- Unload Selected Sample causing bad memory access crash HOT 2
- Clean up isotopes widget using new peakgroup pullIsotopes HOT 1
- Phantom peakgroup points (peak dots) showing when navigating to isotopic peaks in the dock widget. HOT 2
- Regression bugs 2.10.7, 2.10.8, and 2.10.9 HOT 2
- CLOSE FIGURED IT OUT HOT 2
- MAVEN Crashing on default included Compound List HOT 4
- Possible bug: Program crashing after click "sample alignment." HOT 5
- MS1 Peak Detection Crash HOT 4
- Natural Abundance Correction Giving Strange Values HOT 1
- Maven crashed when analyzing lipids data HOT 1
- Add new fields to `Scan` to pass along to maldesi
- Type in any formula in the top search bar causes program to hang HOT 2
- 12345
- Change csv output to area HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from maven.