eugeneware / changeset Goto Github PK

Do you think that this could be used, potentially, for diffing/patching minidoms?

Trying, first thing I ran into was infinite recursion in compare, due to a _documentOwner key pointing to the parent (or grandparent, is it?).

If this is fixed, how much more issues do you assume will come up?

Hi team,

Can you please contact me by mail - [email protected]

Thanks,

@eugeneware would you be happy if I introduced a PR with string diff/patching, using probably diff?

Currently, there is an issue when diffing and patching an object where the types of a field changes from an object to a string.

That is, I would expect the following to work:

    var a = {hello: {nested: 2}};
    var b = {hello: 3};
    var changeset = diff(a, b);
    var b_ = diff.apply(changeset, a);
    expect(b).to.deep.equals(b_);

However, b_ is set to {hello: {}} following the above operations.

It would be great if deletion operations for arrays were presented in reverse order to ensure that they are deleted from the end rather than from the start. For regular JSON, the current approach is fine but the current approach is problematic when using this to edit a more complex object which does not provide the same low-level access since it might automatically shift the indices down for us.

A concrete example where this is problematic can be found here.

Hi, would you mind adding a LICENSE file to the repo? I see BSD listed in the package.json but I'm in the process of open sourcing some stuff out of my company that uses your module and my legal department will have issue with the license text not actually being included.

Thanks!