evanthegrayt / ro_sham_bo Goto Github PK

Just for fun. Make it so either player can always win. Make it "play fair" until the to-be loser gets enough points to almost win. Then sweep the rest of the round. This will make it still seem random.

Add rdoc documentation.

Installation should just require gem install rock-paper-scissors or something.

The cheating isn't actually being tested properly. This...

    game = RoShamBo.new(cheater: :user)
    50.times do
      game.play(:rock) until game.over?
      assert_equal(:user, game.winner)
    end

...should be...

    50.times do
      game = RoShamBo.new(cheater: :user)
      game.play(:rock) until game.over?
      assert_equal(:user, game.winner)
    end

Only 2.6 is tested. We need to test 2.7, 3.0, and 3.1.

Change one of them to -C

Make the output look better. Maybe add some color to make the score more visible.

Track number of draws.

This could use more objects. I think Rules and Score could be their own class. The bin/ro_sham_bo executable should also be extracted to a class so we can test it.

Also, the only thing you can do is play the game via the command line; the API doesn't play the game. You should be able to play the game via CLI, or a ruby console, via RoShamBo.play.

Add tests, along with simplecov.

After #6, add CI that ensures tests are passing.

There currently are no validations for types in initialize.

Make the readme more complete. Installation instructions, etc.