eventespresso / ee4-mer Goto Github PK

Issue Overview

We want to show all sub-items of a particular Ticket ( like price modifier discount ) from the event in event cart page before a user register.

Bug report or feature request?

• Feature

Environment Data:

Version of EE core: 4.9.68.p

Version of this addon: 2.0.14.p (MER Version)

Version of WordPress:4.9

Browser used: Chrome

Expected Behaviour

All the sub-items of a ticket should be visible before a user register.
Example: Price Modifier Discount or Promotion ( On a Specific ticket and not on overall cart )

Current Behaviour

After registration user can see all the sub-items of tickets.

Related Information:

As shown in below screenshots, Before Registration user is not able to see Early Bird Discount ( Price Modifier Discount ) as soon as user complete registation user get deatiled about Early Bird Discount for that ticket.

For back story, plz see:

Currently, the Invisible reCaptcha code hard codes a reference to an MER constant to detect if MER is active, like so:

'disable_submit'   => defined('EE_EVENT_QUEUE_BASE_URL')

but we don't want hard coupling like this to exist, but also don't want to force an update of MER just for the sake of this one little boolean value.

This ticket should hook into the localized vars array in \EventEspresso\caffeinated\modules\recaptcha_invisible\InvisibleRecaptcha::getLocalizedVars() and set the value of the disable_submit to true from within MER. Then we can remove the above hard coupling in core and replace it with a default value of false.

Codebase https://events.codebasehq.com/projects/event-espresso/tickets/8047

Garth Koyle commented on Wednesday 29th April 2015 at 1:52pm
It makes it easier to understand which tickets are for which event if they are grouped together. We do this in the registration step, can we do it this way in the cart?

Steps to reproduce issue:

1. Create an event with multiple tickets and set the Maximum number of tickets allowed per order for this event: to 1.
2. Go to Event Espresso > Events > Templates and set Display Ticket Selector to Yes, under Event List Pages
   On the event list page you'll see a radio button for each ticket, like this:
   

Select the first ticket and add it to the cart. You'll get the MER popup and can select what to do, chose to return to event list

Now select a different ticket and click 'View Event Cart'

The page refreshes and you can see the event list again, now do the same for another ticket if you have one -

So now because we have all 3 tickets from this event selected it won't matter which you chose next, but select a ticket you previously 'added' to the cart and click to view the cart

You can't use the + button for any ticket, they correctly show the notice -

An error has occurred: You have attempted to purchase 1 ticket but
that would result in too many tickets in the Event Cart for this
event. The registration limit for this event is 1 ticket per
transaction, therefore the total number of tickets you may purchase at
any time can not exceed 1.

From Codebase: https://events.codebasehq.com/projects/event-espresso/tickets/8473

This is similar to the issue reported in #8451, the difference being instead of clicking on the + button, you input a bigger number than allowed in the quantity input field.

1. Set the Maximum number of tickets allowed per order for this event: setting to something like 5, save
2. Set up two tickets for the event
3. Go to view the event and select 2 tickets of each (total 4 tickets)
4. Click add to cart
5. Click view event cart
6. Type 3 in the inputs field where it says 2 to add more tickets to the cart (more than allowed)
7. Click Update Event Cart
8. Proceed to registration

The unexpected result is it lets you add more tickets to the cart than allowed and checkout.
reported here:
http://eventespresso.com/topic/bug-maximum-number-of-tickets-not-working-on-event-cart/

Brent Christensen commented on Wednesday 8th July 2015 at 12:17pm
#branch MER addon master

###Testing

• follow the steps outlined above by Josh
• confirm that event max tickets is not exceeded

Josh Feck commented on Wednesday 8th July 2015 at 12:29pm
This fixes the issue originally reported here. Is it expected to throw the error if you try to update quantities for both tickets and update the cart? For example, if I start with 2 of ticket A and 3 of ticket B, but I try to type in 3 for ticket A and 2 for ticket B, it gives me the error when I update the cart. Here's a link to a little video that shows the scenario:

http://screencast.com/t/lVjDXzOT

Lorenzo Caum commented on Monday 18th January 2016 at 6:15am
A report through Help Scout sales:

https://secure.helpscout.net/conversation/161835334/178580/?folderId=100617

Lorenzo Caum commented on Monday 28th March 2016 at 11:51am
One more report:

https://eventespresso.com/topic/customer-can-change-quantity-for-graduated-pricing-other-than-maxmin/

Josh Feck commented on Wednesday 29th June 2016 at 4:21pm
related to #9450 - Fix MER cart so it doesn't allow adding more tickets to the cart allowed per event per order from the event list

Josh Feck commented on Wednesday 7th September 2016 at 7:27am
reported again here:

https://eventespresso.com/topic/min-max-ticket-qty/

Josh Feck commented on Monday 17th April 2017 at 9:30am
Reported again in the forums here:

https://eventespresso.com/topic/minimum-and-maximum-ticket-quantity-bug-in-event-cart/

Lorenzo Caum commented on Monday 24th July 2017 at 8:02am
https://secure.helpscout.net/conversation/387224000/386913/

Josh Feck commented on Friday 8th June at 11:28am
update about this issue requested here:

https://eventespresso.com/topic/minimum-ticket-bug-update-request/

From Codebase: https://events.codebasehq.com/projects/event-espresso/tickets/8772

Tony Warwick commented on Tuesday 1st September 2015 at 9:02am
If you set the alt registration page within an event the event list (both /events/ and ESPRESSO_EVENTS) will still continue to display 'Add to Cart' for that event.

Clicking on it shows the spinner but does not actually do anything.

From Codebase: https://events.codebasehq.com/projects/event-espresso/tickets/11198

Tony Warwick commented on Thursday 23rd November 2017 at 3:16am
Reported here: https://eventespresso.com/topic/how-to-change-mer-popup-text-x-items-were-successfully-added-for-this-event/

To reproduce add some tickets to the cart from one event, let's use a qty of 4 from a single ticket - http://take.ms/ir2ty

Now on another event select another 4 tickets - http://take.ms/TZx20

If you add another 1 ticket you'll get '9 items were successfully added for this event.' and so on.

It looks this is from #8698 - Add checks for ticket availability at each step of SPCO and its this commit - 75f9d60

Tony Warwick commented on Wednesday 11th April at 3:17am
Another report here: https://eventespresso.com/topic/calculation-and-output-error-x-items-were-successfully-added-for-this-event/#post-266879

Josh Feck commented today at 8:26am
I think the poster of this topic is conflating another issue, and the bug reported here is causing the issue they've reported:

https://eventespresso.com/topic/custom-message-for-added-to-cart-popup/

Josh Feck commented today at 9:17am
This appears to be the commit that broke this:

75f9d60#diff-48cccd72a633e83ceaebd161d9316352

(the first group of changes within the process_ticket_selections() method)

Per a customer request, displaying the event dates on the Cart page would prevent confusion from their attendees purchasing the wrong event's dates.

Suggestion
Add the event date below the event title.

Codebase ticket: https://events.codebasehq.com/projects/event-espresso/tickets/9579

Josh Feck commented on Friday 8th April 2016 at 3:47pm (edited on 08 Apr 2016 at 4:21pm)
There's more work to this than the ticket title initially suggests because of the way the ticket selector + MER work together right now. The idea behind this ticket is for making a new (old if you consider EE3) way to add tickets to the cart. So you can add tickets to the cart without first selecting quantities.

So the flow would be:

1. view a list or a table of events where each event has a button to add it to the cart.
2. the add to cart link changes to a view cart button
3. Cart view: Display all of the ticket options for the selected events in the cart view, with qty set to 1 or 0. Ideally if there's only one ticket option, it should automatically set it to 1. If there are many ticket options for the event, set the qty to 0 to let the ticket buyer choose.

Here's a screenshot of an EE3 site that got me thinking about this:

https://www.evernote.com/shard/s4/sh/24473ada-d6bb-4e72-a460-6748c8777c88/bf5495f7beec870de9e17d6d217e7a64

Steps to replicate the issue:

1. Set up a ticket bundle or similar ticket that has a min and or max quantity. You could follow either of the examples from these guides:

https://eventespresso.com/wiki/create-ticket-bundle/

https://eventespresso.com/wiki/set-graduated-ticket-pricing/

2. After setting up the event with the bundle price ( like 10 tickets at a lower price ), then go to the event page and add that bundle to your cart

3. then go to view the cart,
4. then set the quantity in the cart to 1; You can use either the text input or the + - inputs
   Unexpected result:
   You get the bundle price but only buy 1 ticket.

The reverse is also possible where you can add more tickets than the max quantity limit for that ticket.

Brent mentioned that a possible solution would be "if a ticket can have a qty between 5 and 10, then we can just disable the buttons when it hits those limits.

It may also require some validation for the text input fields too.

Reported in these topics:

https://eventespresso.com/topic/minimum-and-maximum-quantity-not-respected-on-cart-page/
https://eventespresso.com/topic/bundle-pricing/#post-234433
https://eventespresso.com/topic/buy-one-get-one-free/#post-256166
https://eventespresso.com/topic/minimum-ticket-bug-update-request/

Creating an Epic for much needed MER updates.

Issue Overview

It is not currently possible to override event name rows in the cart and cart widget like what is possible for ticket line items.

Bug report or feature request?

Feature Request

Environment Data:

Version of EE core: 4.10.26.p

Version of this addon: 2.0.18.p

Version of WordPress: 5.9.1

Related Information:

We use Event Espresso for RSVPs and event registrations for our Scout units. Twice a year we have major fundraising, where we run multiple locations on Saturdays and Sundays. Each of these locations and dates has its own event, partly so we can set limits on certain ticket types to ensure that we have enough adult leadership to meet Youth Protection standards.

To create a better user experience in the cart, we would like to customize it to display Events as "Event Name - Venue Name - Start Date" so that before checking out, people know what fundraising locations and dates they are signing up for. It looks like this is possible today for the ticket line items by overriding "FHEE__EE_Mini_Cart_Table_Line_Item_Display_Strategy___ticket_row__line_item_name" and over similar hooks. Since it is not possible to do for the event name, which looks much nicer than appending every ticket line item, we currently have customized the plugin files to meet our needs.

This was done by modifying the _event_row() function in the following files:

• EE_Event_Cart_Line_Item_Display_Strategy.php
• EE_Mini_Cart_List_Line_Item_Display_Strategy.php
• EE_Mini_Cart_Table_Line_Item_Display_Strategy.php

Ideally, we'd like to see hooks created so that we can merely override them in our website's child theme instead of making sure we reapply the changes every time the plug-in updates.

Reported here: https://eventespresso.com/topic/return-to-event-cart-button-missing-at-payment-checkout-page/#post-281040

This was also reproduced here: eventespresso/eea-paypal-smart-buttons#25
However at the time only appeared to effect PayPal Smart Buttons, I didn't realised it wasn't loading initially.

Issue Overview

If you have MER enabled, add some registrations to your cart, proceed through until you get to the payment options, the 'Return to cart' button is not within the page source - http://take.ms/L37ds

Refresh the page and the button appears - http://take.ms/ZV2QM

Using the latest master of EE core and MER.

Issue Overview

When adding events to the cart using MER, it now shows

0 items were successfully added for this event.
https://monosnap.com/file/h4cRaZfnT8iFajjE7JizynfITOjDIu

This works if I checkout 4.10.13.p so looks like it's from the decaf changes.

Bug report or feature request?

• Bug

Steps to Reproduce (for bugs)

Use master branch of MER and you'll need https://github.com/eventespresso/event-espresso-core/tree/BUG/rmv-debug-code for Core (unless it's been merged already).

Add a ticket to the cart and view the modal, it will show as above.

Darren Ethier commented on Monday 6th April 2015 at 11:44am
To reproduce:

Start with an event that has multiple ticket options.
Add one of one ticket option to the cart. Return to event list.
The button now has the text "View Cart". If you select another ticket option and click that button it will add an additional ticket to the cart for that ticket option, but it's not intuitive.
The first time I noticed this, I "assumed" one could not add additional ticket options from an event to the cart because of that button text, but after pointing this out to @br3nt he challenged me to try it and it worked! But yeah, I don't think it's intuitive to have "View Cart" alone.

Brent suggested two options for this in chat:

Have two buttons (view cart appears when there are things in the cart"
Have js dynamically change the button from "View Cart" to "Add to cart" when there are ticket options selected.
Personally I like option one better - it allows people to play with the css colouring for the buttons to see what performs better for their site.

Brent Christensen commented on Tuesday 7th April 2015 at 10:18pm
which do you prefer? Option 1 or 2 ?

Josh Feck commented on Tuesday 12th May 2015 at 3:07pm (edited on 12 May 2015 at 3:23pm)
I don't have a strong preference one way or another.

A few considerations:

1. Button sizes compared with screen size/column size and how that might affect the layout. Let's say the buttons are kind of big and if they're placed side by side, one button will end up sitting on top of the other.
   One dynamic button might have the advantage here.

2. I think option 2 allows people to play with CSS colouring so long as the buttons have a unique class to match the current state.

3. There's the possibility of confusion over what happens when you have the "Add to Event Cart" button display for an event with tickets in the cart already. For example, if you add 2 tickets to the cart, then add 1 ticket and click "Add to Event Cart" does it change the cart ticket total to 3 or 1? We know that it's 3, but is it obvious to the end user what's happening?
   With this scenario, maybe it'd be good to try something where the js dynamically changes the button text as tickets are selected. So instead of "Add to Event Cart", it would say something like "Add 1 more ticket to the cart" if 1 ticket x qty 1 is selected, "Add 2 more tickets to the cart" if 2 tickets are selected, and so on.

There are some unexpected shenanigans when a ticket is required and the View Event Cart button is clicked. What happens is the View Event Cart button submits the ticket selector form again and adds the required ticket to the cart again.

Steps to replicate the issue:

1. Set up an event with a required ticket

2. Set the required ticket's Maximum Quantity field to 1
   

3. Go to the front end and add the ticket to the cart

4. Close the modal and click the View Event Cart button

The unexpected result is an additional required ticket is added to the cart in step 4. This is particularly bad if the the required ticket has a maximum quantity limit of 1.

One possible solution may be to change the behavior of MER so that the View Event Cart button doesn't resubmit the ticket selector form and instead behaves more like a link to the cart page. Or possibly check first (i.e. Does adding this ticket quantity go over a limit? yes/OK add it || no/don't add it) then proceed to the cart.