Giter VIP home page Giter VIP logo

Comments (4)

eXaminator avatar eXaminator commented on July 27, 2024

Hi @jonepatr,

there are 2 reasons I haven't done this yet:

  1. I felt that GMs usually want some control of what gets synced and what doesn't, especially since a large number of entries (not just in the journal but also Actors, Items etc.) can slow down Foundry on startup because everything has to be downloaded (that's why foundry has compendiums, which aren't downloaded on startup).
  2. I'm always concerned about the number of requests the module has to make to the Kanka API with a timeframe of 60 seconds, because there is a rate limit in place that forbids more than 30 requests (I think 90 for subscribers) per minute. That being said, I usually don't load every entity individually, so this should only be a concern for pretty large campaigns (I'd say upwards of 1000 entities, but it depends on different factors).

I'll look into this, it shouldn't be hard to implement in general. So I'll probably add this sometime soon.

from kanka-foundry.

jonepatr avatar jonepatr commented on July 27, 2024

One option could be to sync in the background and notify the user when the sync is done through a notification. That way the time it takes and the rate limit is not as noticable. The kanka-foundry window could have a percentage showing how much of the content is synced, so that if you have a really big kanka campaign you can actually see that things are happening, but if it's relatively small it should happen almost instantenously.

from kanka-foundry.

eXaminator avatar eXaminator commented on July 27, 2024

I have thought about a progress bar before. I have even build a small debug tool in the module that shows the current rate limit at all times (though only in debug mode, to help me in development). I have marked this feature for 2.1.0 as I intend to implemented it (once I have more time so spend on this).

from kanka-foundry.

github-actions avatar github-actions commented on July 27, 2024

🎉 This issue has been resolved in version 2.1.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

from kanka-foundry.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.