examinator / kanka-foundry Goto Github PK

Seems like kanka made some changes and are not allowing to pin notes anymore. Could it be possible to have an option in the settings to always pin all notes, since it's really nice to have them on the first page of the journal entry.

It's a great way to see which entries came from Kanka and which ones were made directly in Foundry. However, when an entire campaign is made in Kanka then it's kind of redundant.
Maybe have an option in settings to remove this, make it smaller (like [K]) or an icon (I don't think Foundry Allows this) to make it less intrusive would be nice.

Error: The request to https://github.com/eXaminator/kanka-foundry/releases/download/__VERSION__/module.json did not provide a valid manifest file.

This needs research. But it would be great if maps could be imported as scenes, probably with matching journal entries on the scene map where PINs were placed.

• Automatically build releases and create changelog based on conventional commits
• Update module.json based on release and README
• publish version to foundry

In KankaApi.ts, single entities are inconsistently fetched from the API. Currently, when trying to fetch a single race from Kanka, I'm getting the error n.ancestors is undefined. When I have multiple outdated races, it seems to work fine. Other entities also work fine with single results. I believe it's the inconsistent matter of fetching that's the issue.

Hope I'm not annoying you with the amount of issues I'm posting.

An Idea could be to use foundry hosted images in the text using a tag. Say for example {path/to/image/on/foundry/server.webp} could be used to display such a picture.

Environment Details

Foundry VTT Version: 0.8.8

Operating System: [Linux]

How Are You Using Foundry: [Linux,Native Application (Electron), Chrome]

Which Game System: Dungeons and Dragons 5th Edition, version 1.3.6

Modules Enabled?: Yes (if you need i can give you the full list)

Module version: 3.2.1

OS, Hosting, Browser (if applicable): Linux/Node/Chrome

Description of the issue:

So I checked the bug with the 'Characters' category, but it might be present in the others as well.

Kanka provides two methods to upload images either by uploading from a local image or via web url.

In the first case everything works perfectly in the second when I make the 'link' of the character (with the image retrieved from a web url on Kanka) I import it successfully, but without the image, if I click on the 'update' it gives me an exception that I report below.

It's strange because I don't understand at the import level what can change, in both upload cases Kanka should create her own web link for the entity in question.

This is one of the url generated by Kanka that gives the error:

https://images.kanka.io/user/k9UFBC3o61jsoxuMoTCKJDEnn00=/smart/src/characters%2F60fc48a705efd_qoh1hnwpng?webpfallback

as you can see the ".png" extension is "hidden" with the text '' nwpng "which is the cause of the error, the browser then realizes that it is a valid image and displays it correctly if you use the link.

Following these steps,

• adding an entity (e.g. character) in kanka
• linking it in foundry
• removing it in kanka

Pressing "update outdated" or anything else does not remove that entity. Seems like only manual removal is possible

There is an issue with running this mod together with PF2 system - entries do not sync correctly, only main text is displayed without tabs/images/entity notes.

I did test with only this mod installed on 0.8.8 version.

Race ancestors are found using the race_id property. The sheet template for races displays both race_id and ancestors. Because of that, ancestors are effectively displayed twice. Only showing ancestors should be enough.

If it is possible please add some way of differentiating completed quests from incomplete ones in the sidebar - like and icon or color. Ones there is tone of them it gets hard for players to keep track :)

There are cases where referenced entities might not be available anymore. Currently this just crashes the import and leaves the Browser in a broken state.

If a referenced entity cannot be resolved the importer should just skip it and display a warning notification when it's done.

KankaBrowser wraps each entity type in a detail tag which allows the user to collapse the list. It should remember which lists were opened/closed via the user and restore that on each render.

Environment Details

Foundry VTT Version: 0.8.8

Operating System: [Linux]

How Are You Using Foundry: [Linux,Native Application (Electron), Chrome]

Which Game System: Dungeons and Dragons 5th Edition, version 1.4.1

Modules Enabled?: Yes (if you need i can give you the full list)

Module version: 2.3.7

OS, Hosting, Browser (if applicable): Linux/Node/Chrome

Description of the issue:

When i click on the image panel of the standard journal of Foundry now i see the "embedded" version of the image with no url at the bottom.

This error was not present this Wednesday when I did the session, so it must be something inserted after version 2.3.5 / 2.3.6, or maybe some conflict with the update of the module _document-sheet-registrar

Confirmed with some test is something done between 2.3.6. and 2.3.7 version (tested with last version of _document-sheet-registrar 0.5.0 ).

The tree structure of kanka elements should be kept using folders.

Some things to consider:

• Do folders need to be maintained after initial import? (naming)
• What if a folder was renamed in foundry?
• What if a folder was moved?

This should reduce the number of requests

Would be great to add notes from within foundry. Both gm notes that are hidden, but also to players when they have "limited" permission to the journal entry. As in, there might be a location entity, and the players want to write down the facts they know about the location as a note through foundry

First of all: Thanks for that plugin! I was thinking to do something similar, but your's seem to be very helplfull already! :)

My suggestion: The plugin can update all content when changed in Kanka. When adding new entries, it will distribute permissions as expelcted. Very nice!

But when updating entities it won't change permissions. This might be by feature in order to not override permissions already set manually. Perhaps have a configuration or a flag on the main Kanka dialogue?

There should be ways to only show or hide entities with certain tags

I keep getting the migration dialog box on starting my world telling me I have 1 journal entry that needs updating https://i.imgur.com/5oeJ45B.png. I only have a single campaign in Kanka https://i.imgur.com/vXbNSdb.png Updating and overwriting my entries gives an error message of not finding entries to migrate. https://i.imgur.com/HMXtyce.png

If the kanka entity is set to public or player read, then set the permission of the journal entries to "observer" for all players.

Hi! Would be really cool if it was possible to attach an ID to either an audio item or a macro, and have a button saying "execute" or something.

Don't really have a specific usecase for the macro in mind, but for audio I have plenty of locations, and instead of creating a scene for a location, I use the plugin "Journal to canvas slideshow" which let's me show images from journal entries for the players. So it would be really nice to be able to quickly play a sound associated with that scene.

Currently the image_full property contains the path to a 400x400px image. There should be a way to access the full size image instead.

It might make sense to use the thumbnail next to the text entry thought.

It would also be awesome to find a way to run some simple e2e tests...

Loving this plugin. Thanks for the works so far. I would find it really helpful if you could optionally import a list of members to an organization in the same way that Characters can import a list of organizations to which the belong.

Subscribed Kanka users have a higher API rate limit which should be used if possible.

Each entity can have up to three attachments as well as some additional images (especially for boosted campaigns). I'm open to ideas what to do with them. Maybe I should just display them if they are images or link to them otherwise underneath the entity entry.

This might be a bug / missing feature in Kanka. I'll have to check it and see if there's anything I can do.

Example to repro:

1. Create Quest with link to a location in its entry
2. Link quest in Foundry
3. In Foundry journal entry, click link to location
4. End up on Kanka's 404 page

Problem is it seems to be missing the /en-US/ part of the link and it doesn't end up in the correct place. I assume that's something injected on Kanka's side. If it matters, I used a [location:xxx] style link, not an @ link.

Similar issue on the import UI for links to Races/Quests/etc. Clicking on one of the titles attempts to open Kanka with a language of null.

I have to look into this. This would probably require some configuration to define how to map fields. It would also be great to allow mapping of any character sheet field with any kanka attribute.

Suddenly this evening, I get an error trying to sync Foundry with Kanka.

Error:
Access to fetch at 'https://kanka.io/api/1.0/campaigns/{my-campaign}?related=1' from origin 'http://localhost:30000' has been blocked by CORS policy: Response to preflight request doesn't pass access control check: No 'Access-Control-Allow-Origin' header is present on the requested resource. If an opaque response serves your needs, set the request's mode to 'no-cors' to fetch the resource with CORS disabled.

I regenerated an API key, but I'm getting the same response.

Currently there is a button for updating outdated, and then each category has a linking/update buttons. Would be nice with one button which just syncs everything.

Hi,

I have a character in Kanka with Attributes.

When I link/update tis character I get the following under attributes:

It seems to be picking up the 'Section' titles in Kanka, but not the attributes with values.

Sam.

Examples for this:

• Parent entities
• Race and families for characters

This would probably need some sort of mapping between character sheet properties and kanka properties (and maybe attributes).

The warning should be prominent in the Browser Application.

I think it does not work properly.

This should have support for personality / appearance sections. Maybe I can implement a reusable "section" feature for metadata that can also be used for attributes.

Hi,

Not sure exactly what's going on here. I have used this amazing module for a while now - it all worked great, and was one of my favourite modules! But at some point in the last month or so the module has stopped functioning...

So - I have both it and its dependency (lib doc-) listed as active modules on module management. But when I go to configure settings - module settings, neither are showing up on my list. I also don't have the kanka button on my journal entry tab. It's just not appearing anywhere.

I have disabled and re-enabled the module, same with lib document sheet registrar. I'm on foundry v.0.8.8, D&D 5e v.1.4.1. Removed all my outdated modules (re-enabled when that didn't help).
Not sure what else to try? Any ideas would be greatly appreciated!

Thanks!

• Immediately open browser application and show loading indicator while loading lists
• Evaluate if it makes sense to load lists only when user opens the details

This needs a change in the Kanka API first, because right now it's not possible to get this information.

Environment Details

Foundry VTT Version: 0.8.8

Operating System: [Linux]

How Are You Using Foundry: [Linux,Native Application (Electron), Chrome]

Which Game System: Dungeons and Dragons 5th Edition, version 1.3.6

Modules Enabled?: No

Module version: 2.2.0

OS, Hosting, Browser (if applicable): Linux/Node/Chrome

Description of the issue:

When the module is active I am no longer able to edit the text of the Foundry journals

Without the module.

With the module.

Entries sync correctly but only main text is displayed without tabs/images/entity notes/links. Uses PF2e default styling or Foundry styling based on which setting is enabled.

Tested with Kanka as only active module on Foundry Version 0.8.8, PF2e Version 2.9.1

I'm seeing Not allowed to re-assign the global instance of libWrapper while both this module and LibWrapper is installed. I confirmed with ruipin and this is because the libwrapper shim is expected to be used as an imported esmodule.

I'm guessing this is from the JE shim, which will be obsolete soon anyway?