Comments (3)
🎉 This issue has been resolved in version 2.3.5 🎉
The release is available on GitHub release
Your semantic-release bot 📦🚀
from kanka-foundry.
The problem is that this file is loaded as scripts
, rather than esmodules
. As such, it is running in global scope, and the libWrapper
symbol it creates will be visible by every other module, even though it is not the full library.
While the shim will check for libWrapper.is_fallback
before using it, many modules that do not use the shim might not, and as such this might actually cause modules to believe the library is installed when it is not.
In addition, if more than one module does this, it is unknown which module will run later and thus which shim will "win out". As such, you cannot predict which implementation the shim has. It is possible another module would run after yours with an older version of the shim that does not support something you rely on, or that is missing bugfixes, breaking your module.
These reasons are why the libWrapper documentation states in bold:
Please do not make your custom shim available in the global scope.
It is also why the default shim exports libWrapper
, rather than assigning it to global scope. You removed all this from your shim.
I would ask that you change this whenever possible so that this file is import
ed, rather than loading it in global scope as a script. It is better for your module, and also for other modules.
from kanka-foundry.
Thanks for letting me know, looking at the discord there seems to have been a bit of confusion around this issue in this regard.
Well, I didn't want to update this package to use the new (soon to be released) sheet registrar lib until I actually had a bug or feature to release with it... I guess I have a bug fix on my hands now ;)
I'll fix this as soon as I can, hopefully (but not quite guaranteed) sometime tonight (CEST).
from kanka-foundry.
Related Issues (20)
- Add Kanka 1.33 features HOT 1
- Relations always show as hidden HOT 3
- Journal assets aren't opening correctly
- Some items that are live in Kanka are showing as deleted in Foundry HOT 1
- Security issue! HOT 6
- Creatures for the foundry
- Missing the Creatures entry.
- Infinite Loading HOT 7
- Convo: api.kanka.io HOT 7
- [Feature Request] Integration with MJE (Even on Commission) HOT 1
- [Documentation] Can you explain how to activate/use the developing on the readme ? HOT 3
- Kanka 2.0 broke something. HOT 12
- Linked entities opens directly in Kanka HOT 1
- Update to 3.1.12 broke self-hosted Kanka HOT 3
- Allow Editing Of Kanka.io Journals In Foundry? HOT 1
- Tree limitation HOT 1
- Cannot read properties of undefined (reading '0') HOT 19
- New Kanka journal options? HOT 2
- Kanka Characters Won't Link to Foundry HOT 12
- Show entity events HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from kanka-foundry.