excaliburpartners / polycomphones Goto Github PK

module doesn't populate extensions dropdown when adding a line to a phone in FreePBX 14.

The issue seems to be that the SQL in functions.inc.php/polycomphones_dropdown_lines only selects devices/users of "tech" type "sip". FreePBX 14 encourages you to use pjsip as the default. updating the SQL as follows fixes this issue.

original code:

	$results = sql("SELECT devices.id, devices.description, users.extension, users.name FROM devices 
		LEFT OUTER JOIN users on devices.user = users.extension
		WHERE tech = 'sip' ORDER BY devices.id",'getAll',DB_FETCHMODE_ASSOC);

modified code

	$results = sql("SELECT devices.id, devices.description, users.extension, users.name FROM devices 
		LEFT OUTER JOIN users on devices.user = users.extension
		WHERE tech IN ('sip','pjsip') ORDER BY devices.id",'getAll',DB_FETCHMODE_ASSOC);

I'd make a pull request, but I'm in the middle of rebuilding a pbx that has to go live in a few hours and do not have the time right now.

I will update this issue if i find any side effects or other incompatibilities.

Use of undefined constant id - assumed 'id' (this will throw an Error in a future version of PHP)

Is there a feature to add a paging soft-button?