Giter VIP home page Giter VIP logo

Comments (6)

excid3 avatar excid3 commented on August 31, 2024 1

That's exactly what I was imagining. Figured we could just keep it clean and simple that way.

from noticed.

excid3 avatar excid3 commented on August 31, 2024 1

Just pushed b3517e1 that makes each delivery method it's own job so they can be retried independently.

from noticed.

excid3 avatar excid3 commented on August 31, 2024

Agreed! That's one of my todos.

I was thinking that we'd probably make Noticed::Base inherit from ActiveJob to handle that.

from noticed.

BilalBudhani avatar BilalBudhani commented on August 31, 2024

That's a clever idea. How would the API look like then? notify will directly call perform_later internally?

from noticed.

excid3 avatar excid3 commented on August 31, 2024

Alright, initial prototype of jobs is pushed up. I wrote it so that the entire delivery of the notification is a job.

Thinking on it, we probably should change that to be each delivery method as it's own job. That way if your SMS fails and the job retries, you wouldn't create duplicate database records or emails.

from noticed.

BilalBudhani avatar BilalBudhani commented on August 31, 2024

That was super quick @excid3, Thank you!

from noticed.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.