Comments (6)
That's exactly what I was imagining. Figured we could just keep it clean and simple that way.
from noticed.
Just pushed b3517e1 that makes each delivery method it's own job so they can be retried independently.
from noticed.
Agreed! That's one of my todos.
I was thinking that we'd probably make Noticed::Base
inherit from ActiveJob to handle that.
from noticed.
That's a clever idea. How would the API look like then? notify
will directly call perform_later
internally?
from noticed.
Alright, initial prototype of jobs is pushed up. I wrote it so that the entire delivery of the notification is a job.
Thinking on it, we probably should change that to be each delivery method as it's own job. That way if your SMS fails and the job retries, you wouldn't create duplicate database records or emails.
from noticed.
That was super quick @excid3, Thank you!
from noticed.
Related Issues (20)
- trouble reading from `record` in custom ActionCable formatter HOT 3
- [BUG] Generator did not include `include Noticed::Model` in the Notification model HOT 2
- Mention the User association setup in the docs
- [BUG] Can't use Pathname credentials in FCM delivery method, when defining them in a method
- V2 Delivery Method Config Options Presence Validation? HOT 4
- Not able to get recipient in the mailer method HOT 1
- recipient id vary HOT 5
- Noticed v2 Update Instructions / Sample Code HOT 29
- Twilio messaging will no longer work after their migration to content templates for Whatsapp HOT 1
- [BUG] Rspec running infinitely HOT 5
- [BUG] failing zeitwerk check
- [BUG] FCM Delivery Method errors when config[:json] is a method HOT 1
- [BUG] Inaccurate recipient_type class name for STI model, when delivering the notification
- Rails crashes when not using ActionCable on 2.0.2 and above. HOT 6
- [BUG] Second migration file not necessary when installing noticed on a new app
- [BUG] Updating to ~> 2.1 - Unknown migration version "7.1"
- [BUG] Getting an undefined method gsub error when trying to use the twilio_messaging delivery method upon upgrade to V2 HOT 2
- [BUG] Params not being forwarded to mailer HOT 12
- `notification_methods` not working when used on `ApplicationNotifier` HOT 1
- [BUG?] Cannot create Noticed::Event in MariaDB HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from noticed.