Giter VIP home page Giter VIP logo

Comments (6)

excid3 avatar excid3 commented on August 31, 2024

Yeah, we could move that file and only require it if ActionCable exists.

You're running Rails 6.0 though right? (I believe that's a requirement in the gemspec). I would guess that the app/channels folder isn't in your app or doesn't contain the application_channel.rb file.

I think it's reasonable to move that file so it's only required if ApplicationCable::Channel is defined.

from noticed.

kylekeesling avatar kylekeesling commented on August 31, 2024

That's correct, I'm running on Rails 6, I just didn't have a file at app/channels/application_cable/channel.rb.

from noticed.

excid3 avatar excid3 commented on August 31, 2024

Makes sense. We probably can't provide the class as part of the Rails engine anymore in that case or we have to have a conditional parent class which probably is fine.

from noticed.

excid3 avatar excid3 commented on August 31, 2024

@kylekeesling want to give the handle-actioncable-missing branch a try?

from noticed.

kylekeesling avatar kylekeesling commented on August 31, 2024

This seems to have done the trick! I removed the boilerplate channels/application_cable/channel.rb class and I can still get the app to boot up.

Thanks for your work on this!

from noticed.

excid3 avatar excid3 commented on August 31, 2024

Great! I will merge that and create a new release. 👍

from noticed.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.