Comments (6)
Yeah, we could move that file and only require it if ActionCable exists.
You're running Rails 6.0 though right? (I believe that's a requirement in the gemspec). I would guess that the app/channels
folder isn't in your app or doesn't contain the application_channel.rb file.
I think it's reasonable to move that file so it's only required if ApplicationCable::Channel
is defined.
from noticed.
That's correct, I'm running on Rails 6, I just didn't have a file at app/channels/application_cable/channel.rb
.
from noticed.
Makes sense. We probably can't provide the class as part of the Rails engine anymore in that case or we have to have a conditional parent class which probably is fine.
from noticed.
@kylekeesling want to give the handle-actioncable-missing branch a try?
from noticed.
This seems to have done the trick! I removed the boilerplate channels/application_cable/channel.rb
class and I can still get the app to boot up.
Thanks for your work on this!
from noticed.
Great! I will merge that and create a new release. 👍
from noticed.
Related Issues (20)
- Noticed v2 Update Instructions / Sample Code HOT 29
- Twilio messaging will no longer work after their migration to content templates for Whatsapp HOT 1
- [BUG] Rspec running infinitely HOT 5
- [BUG] failing zeitwerk check
- [BUG] FCM Delivery Method errors when config[:json] is a method HOT 1
- [BUG] Inaccurate recipient_type class name for STI model, when delivering the notification
- Rails crashes when not using ActionCable on 2.0.2 and above. HOT 6
- [BUG] Second migration file not necessary when installing noticed on a new app
- [BUG] Updating to ~> 2.1 - Unknown migration version "7.1"
- [BUG] Getting an undefined method gsub error when trying to use the twilio_messaging delivery method upon upgrade to V2 HOT 2
- [BUG] Params not being forwarded to mailer HOT 12
- `notification_methods` not working when used on `ApplicationNotifier` HOT 1
- [BUG?] Cannot create Noticed::Event in MariaDB HOT 1
- Unclear section in the upgrade guide about polymorphic record association
- [BUG] Forbidden nil access when using action_cable default channel HOT 14
- [BUG] NoMethodError .to_notifier HOT 1
- [BUG] Noticed seems incompatible with MS SQL server (undefined method `has_key?' for an instance of String) HOT 21
- [BUG] Events created in nested transactions can fail to deliver HOT 2
- [BUG] Documentation FCM delivery method HOT 1
- [BUG] ArgumentError (wrong number of arguments (given 0, expected 1)) HOT 5
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from noticed.