exozonedev / wsabi-client Goto Github PK

As beam now uses 204 status codes
https://github.com/ExoZoneDev/wsabi-client/blob/master/ts/src/client.ts#L52

Will reject on some requests.

When you send a request to a server the client should have an inbuilt timeout for not getting a response back. Either using Promises or a setTimeout. Example being if you send a request using an uppercase on the method or a URL which the API / site takes a while to resolve. (Basically sites that don't force a timeout) the Promise sits for ages w/o timing out.

Obviously the application can do the timeout's is self but in theory the module should be also handling timeouts / dead responses from the live socket.

I'd like to be able to catch error messages that come from the server on a call to .live

I was making a silly mistake, (omitting one set of :'s from a slug) on call to .live

wsabi.live(`user:000update`).subscribe(....)

And there's currently no way to catch or even investigate a failed promise from a call to .live.

https://github.com/ExoZoneDev/wsabi-client/blob/master/src/client.js#L100 doesn't expose the promise back to the implementation.

The same problem doesn't occur with .put,.get etc as the request promises are returned.

I'm not sure on the best way to resolve this without breaking existing API so i'm opening an issue. For now I've got a rejection handler and some console.logs manually inserted within my projects node_modules/ not ideal.