experiandataquality / aperture-data-studio-sdk Goto Github PK

Example step gradle builds currently use 'com.github.johnrengelman.shadow' version '5.2.0', which will cause dependency log4j-core and log4j-api 2.11 to be downloaded to the build machine.

Upgrade to 7.1.2 so that log4j 2.17.1 is used instead: https://github.com/johnrengelman/shadow/releases

For this change we'll also need to upgrade to Gradle v7. In gradle-wrapper.properties:
distributionUrl=https://services.gradle.org/distributions/gradle-7.5.1-bin.zip

Adding debugging section into the docs would be beneficial for integrator/clients alike.

Pull Request#13

Hi,

it would be great if we publish the SDK into public maven repository (Maven Central and Bintray jCenter).

I see benefits of doing this:

1. Client and integrator doesn't have to copy the SDK jar manually into their project.
2. Easily leverage transitive dependency resolution done via Gradle / Maven.
3. Better versioning of the SDK. As of now the SDK jar naming itself doesn't indicate the version. You can only get the version if you extract the pom.properties file from the Jar.

The gradle version in gradle-wrapper.properties is pretty old. The distribution URL needs to be updated distributionUrl=https://services.gradle.org/distributions/gradle-4.1-all.zip would suffice.

Hi,

• BooleanParametersTest and StepTemplate has a wrong package thus causing compilation error.
• Override of getValueAt should throws SDKException instead of Exception

I've created a pull request for this:

Pull Request #9

On GitHub readme: The getValueAt object is called for each cell when generating the view or executing the workflow. Should read “The getValueAt method is called for each cell when generating the view or executing the workflow”

RestServiceSampleStep still uses getConstantByName():

            if (this.getConstantByName(COLOR_SERVICE_URL_KEY) != null) {
                this.colorService.setBaseUri(this.getConstantByName(COLOR_SERVICE_URL_KEY).toString());
            }

Should be updated to use ServerValueUtil.getGlossaryConstant(...), something like this:

            final Optional<String> baseUri = ServerValueUtil.getGlossaryConstant("COLOR_SERVICE_URL_KEY");
            baseUri.ifPresent(b -> this.colorService.setBaseUri(b));