Giter VIP home page Giter VIP logo

Comments (3)

nfriedly avatar nfriedly commented on May 18, 2024

hey @henriquea I think I follow what you're talking about, it sounds like you're trying to use this for the "business logic" of your app, limiting how many times a user can cast a vote on a given instance of the widget, correct?

That's not really what express-rate-limit is designed for - it's intended to block/slow down abusive end-users. So if a user is abusing your project on a.com by voting a bajillion times, you would probably also want to block that user on b.com, right?

You're welcome to fork the code and adjust it to do your business logic - I think you could just change line 37 to

 var ip = req.ip + '-' + req.query.url;

But that will automatically reset after a while, so it might not be what you actually want.

Or am I misunderstanding you entirely?

from express-rate-limit.

hnqlv avatar hnqlv commented on May 18, 2024

Thanks for the quick response @nfriedly 😎

Yes exactly! It's hard to come up with a limit number. Let's say this gets popular and is in a lot of posts. I might read ~20 articles during the day, if each article has 5 widgets isn't that hard to hit 100 requests.

So if a user is abusing your project on a.com by voting a bajillion times, you would probably also want to block that user on b.com, right?

You made a fair point I agree. I wouldn't mind if reset after a while, I think this is the right behaviour.

Cheers

from express-rate-limit.

hnqlv avatar hnqlv commented on May 18, 2024

@nfriedly closing this issue now, since we have an alternative. Thanks again!

from express-rate-limit.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.