V3 Goals about express-rate-limit HOT 7 CLOSED

That's interesting, I didn't know about the change in convention.

(Sorry, I just realized that the rest of the reply didn't make any sense in the context of this module.)

from express-rate-limit.

Hey @nfriedly thanks for the quick reply, don't worry i understand you are bussy 😄

I might drop a quick pr for a start on v3 but I will mostly focus on removing complexity that I don't think is necessairy (such as the delay stuff)

When that is out we can start looking ahead at how to re-implement lacking functionality in ways that make the most sense.

from express-rate-limit.

For v3 should we consider deprecating headers named X-... and effectively remove the X from all the custom header names? It's the convention now:

SHOULD NOT prefix their parameter names with "X-" or similar constructs.

RFC 6648

Not a major issue or anything but if you're gonna upgrade to a new major version this could be something easy to add.

from express-rate-limit.

What is the status on this?
Especially the first point is of interest to me as i find it strange that the default behaviour of this middleware is to start delaying requests by one second after the first request, which I don't think is a common usecase for most users of a rate limit middleware 😕

from express-rate-limit.

Hey,

Things are kind of in maintenance mode right now. I changed jobs so I can no longer work on this during working hours, and I don't have a lot of time available outside of work.

I know a lot of people use this, so I basically accept most PRs that don't break backwards compatibility. Even for a v3 release, where it's OK to remove or break some features, I'd still like to keep compatibility with the existing stores that people have written.

If you're interested and available, I'd love some support with creating a v3 that made a little more sense. It wouldn't have to hit all of the above points, anything would be progress.

I just reworded the ticket to make a little more sense (and I removed the idea of dropping support for external stores - that wouldn't be a good idea at this point.)

from express-rate-limit.

@nfriedly

• Make onLimitReached only fire once before an IP resets

That is literally just one additional if , may be set it for first-timer-only or something like that.

@tjallingt if you started the v3 branch, I could help with one or two checkboxes :)

from express-rate-limit.

It's done!

from express-rate-limit.