Giter VIP home page Giter VIP logo

Comments (4)

nfriedly avatar nfriedly commented on May 18, 2024

Yea, there's a couple of vectors there:

  • If the attacker knows a third party's IP, they can use spoofing to make the server deny service to that third party.
  • If the attacker doesn't need the servers response to carry out the attack, then IP spoofing will effectively bypass this module.

For something like a login or password reset form, you could mitigate the second attack vector by putting a CSRF token in the form and rate-limiting that.

Old

from express-rate-limit.

nfriedly avatar nfriedly commented on May 18, 2024

Sorry. typing this on a phone...

Old versions of the library had a global: true option, which would basically lock it down for everyone if an attacker hit the site too hard with spoofed IPs, but it wasn't that useful in practice and got removed from v2.

from express-rate-limit.

Stellaverse avatar Stellaverse commented on May 18, 2024

Aces. Thanks for the quick, helpful reply.

from express-rate-limit.

kevinwheeler avatar kevinwheeler commented on May 18, 2024

I apologize, I don't understand the bit about a CSRF token and rate limiting that. What would the attacker be trying to accomplish with a login form if he doesn't need the response? Certainly not logging in/cracking the password since he won't have the response. Also, what value does the CSRF token provide other than its standard use of making sure a user doesn't unintentionally submit a form?

from express-rate-limit.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.