Incompatible with latest rate-limit-redis RedisStore about express-slow-down HOT 7 CLOSED

Step 1 is done - we now have full test coverage across windows, mac, and linux with multiple versions of node.js tested on each.

I'm toying with the idea of rebuilding express-slow-down on top of express-rate-limit, essentially as just a custom handler callback that delays the request instead of responding with an error page. I think it would solve the store compatibility issue once and for all, while at the same time making this repo smaller and simpler.

from express-slow-down.

@nfriedly i couldnt agree more about your idea of rebuilding express-slow-down into express-rate-limit, that would make things way easier to handle with only one package to use by everyone. After all slowing down request usually go with rate limit

from express-slow-down.

For now, you should go with the older version of rate-limit-redis.

This project should get updated to support the new API, but that is going to be a fairly involved process and won't happen very quickly.

from express-slow-down.

@nfriedly The problem here is that your other package https://github.com/nfriedly/express-rate-limit is compatible with latest version of rate-limit-redis and make it very uncomfortable to use both library in a same project if we want latest version on each of them :/
Maybe i can help to make it usable for both old and new api of store ?

from express-slow-down.

Well, the latest version express-rate-limit is backwards compatible with the older version of rate-limit-redis, so that shouldn't be an issue. rate-limit-redis is the only one you'll need to pin to an older version for now.

But, yes, if you can update express-slow-down to support the newer API, I would appreciate that.

The roadmap in my mind was to fix up the test reliability first, and then update the API, possibly converting to typescript at the same time as the API update. That's the basic path we took for express-rate-limit.

from express-slow-down.

when this could be solved? it does not work out of the box, maybe there is some glue code someone have?

from express-slow-down.

Thanks to @AdrianoRuberto v1.6.0 now has support for the newer promise-based Store API that express-rate-limit now uses. It should also retain backwards compatibility with older stores.

Please test it out and let me know if you run into any issues.

from express-slow-down.