Comments (5)
Oof, I'm sorry, I didn't think about that.
Here's a couple of options that are both a little dumb, but might be good enough:
-
Add a custom middleware that runs after
express-slow-down
and checksreq.slowDown
:app.use(slowDown({ // ... })); app.use((req, res, next) => { if (request.slowDown.current === request.slowDown.limit + 1) { // onLimitReached code here } next(); }));
The gotcha with this approach is that it now fires after the delay, whereas
onLimitReached
fired before the delay. That might be acceptable for logging purposes, though. -
Drop
express-slow-down
, and instead useexpress-rate-limit
with a custom handler as shown in the docs. However, make the custom handler slow down responses instead of blocking them:app.use(rateLimit({ // ... max: 1, // previous delayAfter value here handler: (request, response, next, options) => { if (request.rateLimit.used === request.rateLimit.limit + 1) { // onLimitReached code here } const delay = (request.used - request.limit) * 1000 const timerId = setTimeout(next, delay) response.on('close', () => clearTimeout(timerId)) }, })
(Basically recreate a simpler version of express-slow-down v2.0.0.)
from express-slow-down.
thanks, made do with a variation based on 1. Found a bug see #46.
from express-slow-down.
Related Issues (17)
- Look into using req.rateLimit / req.slowDown to share data with express-rate-limit instead of needing a second store HOT 1
- Logging when threshold met HOT 1
- delayAfter = 0 does not disable rate slowdown HOT 1
- Allow failed requests to count twice HOT 2
- Rationale behind linear backoff HOT 3
- Incompatible with latest rate-limit-redis RedisStore HOT 7
- Question: Is delay per IP or for all IPs? HOT 1
- Release v1.4.1 fails test HOT 6
- On v1.4.1 when slow delay is triggered the http request end up hanging up indefinitly and never being resolved HOT 19
- TypeError: Cannot read properties of undefined (reading 'toString') HOT 3
- Add support for modern store interface HOT 1
- user passed in validate overwrites `limit: false` HOT 4
- CVE-2024-29041 vulnerability of Express.js HOT 1
- Add maximum value to slow down delay
- maxDelayMs missing from @types/express-slow-down HOT 1
- req.ip is undefiend on production HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from express-slow-down.