Giter VIP home page Giter VIP logo

sniffles's Issues

Stop checking CMS's once one is found

A page can only belong to one CMS, so I think it seems smart to stop checking if it's another CMS if one is detected. However with the way things are currently implemented, I'm not sure on the best way to add this.

That way the sniffer response object could be something along the lines of

:cms => {:platform=>:wordpress, :version=>false, :feed=>"http://feeds.feedburner.com/pearsonified", :theme=>"thesis_17", :pingback=>"http://www.pearsonified.com/xmlrpc.php"}

Rather than

:phpbb=>{:found=>false}, :vbulletin=>{:found=>false}, :wordpress=>{:found=>true, :version=>false, :feed=>"http://feeds.feedburner.com/pearsonified", :theme=>"thesis_17", :pingback=>"http://www.pearsonified.com/xmlrpc.php"}}

I'm not entirely sure on the best implementation either. But currently the only way to find out what CMS a site actually was would be to look through all the CMS keys, and find which were true? Unless I'm overlooking something.

WordPress implementation is flawed

The current WordPress implementation is flawed, it simply checks for "wp-content" anywhere within the source. This will pick up things such as hotlinking to images within the wp-content folder on your domain, or any other domain for that matter.

Suggestion is to use Nokogiri to parse the document, and then check if any link tags(CSS) contain "wp-content".

New Name for Library

I tried to create a new github organization and the name sniffles is already taken. Not really a big deal as it isn't a Ruby library, but I'm thinking it might be prudent to change the name of the library to something unique, at least in the context of github. I've also grown to dislike the repetition in the namespace.

I'm open to suggestion.

/cc @JakeAustwick, @dchuk

Depth / Detail Option

Not sure on the best implementation, but maybe an "depth" option could be added, which affects how much analysis is actually run. You may only want to find the platform of the site for instance, or may not be interested in that at all and only actually want to know what javascript libraries it uses.

Not sure what you think of this, or it you have ideas on the best way to implement this?

Update and Improve Documentation

The v0.1.0 release includes some pretty dramatic changes to the API. I need to reflect this in the documentation. While I'm at it, I'd like to figure out a good way to organize the documentation now that the feature-set is becoming a bit more rich.

Break functionality into sub-libraries

Thinking about breaking each sniffing "pattern" into individual modules; i.e. sniffles-wordpress or sniffles-jquery. The base module would provide the parsers and query methods for common HTML nodes. Thinking mostly about making it easy to extend.

Any feedback on this kind of design @JakeAustwick and @dchuk?

Document w/ TomDoc

I should have done this from the beginning, but I'd like to start using TomDoc for library documentation. It is simple and expressive on top of being easy to remember and implement.

I'm going to make TomDoc a requirement for the v0.2.0 release.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.