It would be nice for the users who forgets the -u flag to be able see the qr code after they have input their username.

If I try to purchase a product I cannot afford, I currently get the following message:

$ sts classic
Du har ikke købt din vare. Prøv igen 402

I would suggest printing a better message. Possibly with a QR code to pay.

Because STS knows of the location for plugins (If this has been set) STS knows where to put downloaded plugins by itself.
This allows for expansion on the notion that STS is its own package manager, because we can pull plugins directly from github.

Floating points are a pain. They are never accurate. We must round these off for sts to seem pure and complete

Currently, not many people know about the .sts files. It would be beneficial for the user to be able to generate it automatically, with correct formatting.

As a user
I want to have a setup flag that generates a .sts file
So it is placed in the right directory

When a user wants to insert F$ onto their account, but do not have a .sts file, they are prompted to enter their username.
Currently we do not validate this username meaning you can insert money into a non-existing account.

As a user
I want to ensure the money are sent to an existing account
So that the TREO will not be bothered

@SEbbaDK from #33

Opdateringsfunktionaliteten fra #32 virker ikke i nixos pr. design, siden programmet bliver lagt i read-only hukommelse.
Så det kunne være en idé at checke for om file kan skrives til.

#13 added shorthand which was great.
Unfortunately, I find myself: is there a shorthand for this id?

I would suggest adding an option to print all of the shorthands to the user so they can make an informed decision on what product to purchase.

to support terminals that do not have emoji support.

I wish to add a feature, where you can list your previous purchases.
Stegsystemet already has this data, by visiting /<roomID>/user/<userID>/ and it would be possible to get the userID from the test user function
From here we simply need to scrape the loaded website and parse the table, containing product, date, and price.

It would be nice if the HTML tags used to highlight products would removed from the CLI as it just looks bad (Such as <h1>). Alternatively the products with html tags could also be used to change the formatting of products with these tags.

Running the Stregsystem CLI on Windows results in the following error:
NameError: name 'is_windows_terminal' is not defined

This can be fixed if the reference to is_windows_terminal is replaced with is_windows. I imagine that short-circuiting prevents the error from being found from a Linux system.

As a fember I want a QR code to insert money in my terminal, so I don't have to remember the phone number and my username.

ctrl+d in most shells issue an EOF character, which is a relatively universal way of ending a shell or other text input (like the buy menu in sts).
We should just gracefully handle this character and exit.

Id> Traceback (most recent call last):
File "/bin/sts", line 416, in <module>
    main()
File "/bin/sts", line 400, in main
    user_buy(args.user)
File "/bin/sts", line 294, in user_buy
    item, count = get_item([x[0] for x in wares])
File "/bin/sts", line 260, in get_item
    item_id = input('Id> ')
    
EOFError

When creating a new installation of STS, running the -s flag produces the following stacktrace:

Traceback (most recent call last):
  File "/opt/homebrew/bin/sts", line 1032, in <module>
    sts.load()
  File "/opt/homebrew/bin/sts", line 643, in load
    self._argument_handler.handle_stopping(self, self._user_manager, self._request_handler)
  File "/opt/homebrew/bin/sts", line 296, in handle_stopping
    self.setup_sts(user_manager, request_handler, Configuration())
  File "/opt/homebrew/bin/sts", line 395, in setup_sts
    configuration.write()
  File "/opt/homebrew/bin/sts", line 162, in write
    with open(paths[0], 'w') as configfile:
IndexError: list index out of range

This has been tested on MacOS

For new users who are unfamiliar with the code, they might want to explore what the tool can do.

I would suggest adding a --dry-run option for the script.
Example usage:

$ sts classic --dry-run
Username 'abba' would purchase 1x 14 Øl(Grøn/Classic/Rød/Rå) (excl. pant) for 6.67 kr

Another example:

$ sts -u johannes 1837 --dry-run
Username 'johannes' would purchase 1x 1837 Monster / cola energy (excl. pant) for 12.10 kr

More reading on general usage of --dry-run here

STS writes the following when 'plugin_dir' is not set:
STS now supports plugins. Add "plugin_dir=~/.sts_plugins/" to your .sts file

However, (on my system at least) the expansion of home (~) does not work and I have to give it a FQN (/home/$user/.config/sts/plugins/etc).

Having some way to supress the "heyo, we got plugins" message without having to setup plugins would be nice, since you can know of the support but choose not to use it.

Fembers have been crashing the sts CRT terminal by trying to use multibuy in the username prompt. While this does make a sale, and should do so, we need to implement support for this, such that the system will not crash when a request like that is made

When i try and run sts

SyntaxError: Non-ASCII character '\xc3' in file /usr/bin/sts on line 28, but no encoding declared; see http://python.org/dev/peps/pep-0263/ for details

Running the setup -s process creates a .sts file containing two [sts], resulting in an error the next time you run "sts".

Terminal:

sts -s
Hvad er dit bruger navn? <Username>

~/.sts

[sts]
[sts]
<username>

To fix the problem i removed one instance of [sts] in the .sts file.

~/.sts

- [sts]
  [sts]
  <username>

sts must be dependency free. Therefore the requests module must be replaced with raw urllib3 calls. Pure python is a requirement

Currently I'm trying to create a rofi script for STS. In this regard, I would like to use the get-wares-functionality.
However this function is tightly bound to the main python file.
I suggest splitting the functionality into the following files:

• stslib.py - A general library containing interaction with stregsystemet. So: test_user, get_wares, get_history, sale and possibly get_qr
• sts.py - The current implemention, but calling the library instead
• sts-strandvejen.py - The special case of the strandvejen

And here is where I would be able to create sts-rofi.py which interacts with rofi.

This split does however come with a drawback: The update script needs to support updating multiple files.

Currently it is only a suggestion. I don't know if there is even any support a change like this.