f1f7y / better.serverbrowser Goto Github PK

I did play around with string.find yesterday and it seems it returns first occurrence or null if not found (see http://squirrel-lang.org/squirreldoc/reference/language/builtin_functions.html#string)
If you did what I did if (str.find(subStr) that would explains why your string.find did only works like 10% of the time.
Tested it and if (str.find(subStr) != null) { /* filter matched */ } works perfectly fine for me.

Won't open a PR for this, just leaving it here in case you want to clean up your code.

If possible it would be better to give the buttons an inactive background colour, or outline, or something that makes them stand out from just regular text, more specifically the "DESCRIPTION" and "MODS" buttons don't look like they are buttons

I get this error every time I press the scroll bar

• ver. 1.2.3

Hello, and thanks for the mod!

Could you export all of its texts into a located file, just like Northstar client (https://github.com/R2Northstar/NorthstarMods/blob/main/Northstar.Client/mod/resource/northstar_client_localisation_english.txt) ?

It would allow translation of the mod and thus greater usage/integration among players base.

(I'm willing to translate your mod to French btw)

Instead of listening for the enter key to filter the displayed servers its possible to use Hud_AddEventHandler( element, UIE_CHANGE, Callback ) on the text box (found that after some digging in other files).
Could then filter every time the box changes, not only if the user presses enter.
Only concern would be that if the server list is like SUPER long, it might lead to performance issues if its filtered every time the user types a single character into the filter box.

This would also free the enter key for other purposes (like connect to selected server), but I don't think there is a need for that.

Could add that myself, if you want.

Just open the server browser and press arrow up (or down) till you reach either end of the list, then press the same arrow key again (maybe more than once) as if you wanted to navigate further in the same direction.
It will connect you to a server (I'm pretty sure its the one at the end of the list I navigated to).

Its not possible to navigate the filter settings using the keyboard.
Also if any of the filter settings fields has focus and you do use the arrow keys it scrolls the list.
I think that could be fixed by check if any server list element has focus and only if so reacting to keyboard input by scrolling.