DH2.1 to DH3 migration questions about dart HOT 4 CLOSED

Hi @markchristopherng !

1. Yes, with D&H3 all components where you want to be able to navigate to must use NavigationModels. That way we encapsulate our navigation info in one single place. It also allows D&H3 to be compatible with modularized apps.

2. You need to create a NavigationModel as well.

3. There are 2 ways to bind NavigationModels at runtime on the version 3:

class MyFragment {
    @DartModel MyFragmentNavigationModel nm;

   onCreate() {
       Dart.bind(this); // It will create the navigation model and bind the fields inside it to the fragment arguments.
   }
}

class MyFragment {
    MyFragmentNavigationModel nm = new MyFragmentNavigationModel();

   onCreate() {
       Dart.bindNavigationModel(nm, this); // It will bind the fields inside the navigation model to the fragment arguments.
   }
}

I think you are looking for the second one option.

4. Actually this is an issue, we never updated it and we should have. The fix is just to update the reference inside the Dart class. You wanna give it a try and open a PR?

from dart.

Hi Daniel, thanks for answering all our questions really promptly. It's going to save us a lot of time. We will try to put a PR for issue 4. Just wondering why jeftifier failed to convert it to Android X.

from dart.

Cause we are actually using the one from android.app 😅...

At Groupon we do not bind fragment extras, so we didn't encounter the issue...

from dart.

I spoke to a few of the other senior developers in our team and we are going down the approach of removing the @InjectExra now @BindView annotations from our fragments, we believe that is a cleaner solution than creating NavigationModels. Thanks again for your assistance.

from dart.